Skip to content

Commit 6160f09

Browse files
authored
Enforce legacy UX for new tab and focussed view (#4785)
Task/Issue URL: https://app.asana.com/0/608920331025315/1207866714282844/f ### Description Enforces legacy UX for new tab and focussed views. We will probably have to revisit this in future to give the _new_ UX for internal users because this PR will enforce legacy experience regardless. ### Steps to test this PR - [ ] Clean install - [ ] Complete onboarding - [ ] Add a favorite - [ ] Open a new tab; verify you see the _old_ UX for new tab screen
1 parent f777c5c commit 6160f09

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

app/src/main/java/com/duckduckgo/app/browser/newtab/FocusedViewProvider.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ class RealFocusedViewProvider @Inject constructor(
4949
@ContributesActivePlugin(
5050
scope = ActivityScope::class,
5151
boundType = FocusedViewPlugin::class,
52+
priority = 0,
5253
)
5354
class FocusedLegacyPage @Inject constructor() : FocusedViewPlugin {
5455

@@ -62,6 +63,8 @@ class FocusedLegacyPage @Inject constructor() : FocusedViewPlugin {
6263
@ContributesActivePlugin(
6364
scope = ActivityScope::class,
6465
boundType = FocusedViewPlugin::class,
66+
priority = 100,
67+
defaultActiveValue = false,
6568
)
6669
class FocusedPage @Inject constructor() : FocusedViewPlugin {
6770

app/src/main/java/com/duckduckgo/app/browser/newtab/NewTabPageProvider.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ class RealNewTabPageProvider @Inject constructor(
4848
@ContributesActivePlugin(
4949
scope = AppScope::class,
5050
boundType = NewTabPagePlugin::class,
51+
priority = 0,
5152
)
5253
class NewTabLegacyPage @Inject constructor() : NewTabPagePlugin {
5354

new-tab-page/new-tab-page-impl/src/main/java/com/duckduckgo/newtabpage/impl/NewTabPage.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ import javax.inject.Inject
2828
@ContributesActivePlugin(
2929
scope = AppScope::class,
3030
boundType = NewTabPagePlugin::class,
31-
priority = 100, // higher to come last in the list of plugins
31+
priority = 100, // higher to come last in the list of plugins,
32+
defaultActiveValue = false,
3233
)
3334
class NewTabPage @Inject constructor() : NewTabPagePlugin {
3435

0 commit comments

Comments
 (0)