Skip to content

Commit 63ad354

Browse files
authored
Fix landscape layout's squished controls; add scroll view to menu items (#197)
* Fix landscape layout's squished controls; add scroll view to menu items * Formatting only
1 parent 0bd436a commit 63ad354

File tree

1 file changed

+41
-32
lines changed

1 file changed

+41
-32
lines changed

app/src/main/res/layout/popup_window_browser_menu.xml

Lines changed: 41 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,19 @@
1616

1717
<android.support.constraint.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
1818
xmlns:app="http://schemas.android.com/apk/res-auto"
19-
android:layout_width="wrap_content"
19+
android:layout_width="match_parent"
2020
android:layout_height="wrap_content"
2121
android:background="@color/white">
2222

2323
<LinearLayout
2424
android:id="@+id/header"
25-
android:layout_width="match_parent"
25+
android:layout_width="0dp"
2626
android:layout_height="50dp"
2727
android:background="@color/white"
2828
android:gravity="center"
29-
android:orientation="horizontal">
29+
android:orientation="horizontal"
30+
app:layout_constraintEnd_toEndOf="parent"
31+
app:layout_constraintStart_toStartOf="parent">
3032

3133
<ImageButton
3234
android:id="@+id/backPopupMenuItem"
@@ -63,38 +65,45 @@
6365
android:background="@color/white_two"
6466
app:layout_constraintBottom_toBottomOf="@+id/header" />
6567

66-
<LinearLayout
67-
android:layout_width="wrap_content"
68+
<ScrollView
69+
android:layout_width="match_parent"
6870
android:layout_height="wrap_content"
69-
android:orientation="vertical"
70-
android:paddingBottom="20dp"
71-
android:paddingTop="13dp"
7271
app:layout_constraintTop_toBottomOf="@id/header">
7372

74-
<TextView
75-
android:id="@+id/bookmarksPopupMenuItem"
76-
style="@style/BrowserTextMenuItem"
77-
android:enabled="false"
78-
android:text="@string/bookmarksMenuTitle" />
79-
80-
<TextView
81-
android:id="@+id/addBookmarksPopupMenuItem"
82-
style="@style/BrowserTextMenuItem"
83-
android:enabled="false"
84-
android:text="@string/addBookmarkMenuTitle" />
85-
86-
<TextView
87-
android:id="@+id/findInPageMenuItem"
88-
style="@style/BrowserTextMenuItem"
89-
android:enabled="false"
90-
android:text="@string/find_in_page" />
91-
92-
<TextView
93-
android:id="@+id/settingsPopupMenuItem"
94-
style="@style/BrowserTextMenuItem"
95-
android:enabled="false"
96-
android:text="@string/settingsMenuItemTitle" />
73+
<LinearLayout
74+
android:layout_width="wrap_content"
75+
android:layout_height="wrap_content"
76+
android:orientation="vertical"
77+
android:paddingBottom="20dp"
78+
android:paddingTop="13dp">
79+
80+
<TextView
81+
android:id="@+id/bookmarksPopupMenuItem"
82+
style="@style/BrowserTextMenuItem"
83+
android:enabled="false"
84+
android:text="@string/bookmarksMenuTitle" />
85+
86+
<TextView
87+
android:id="@+id/addBookmarksPopupMenuItem"
88+
style="@style/BrowserTextMenuItem"
89+
android:enabled="false"
90+
android:text="@string/addBookmarkMenuTitle" />
91+
92+
<TextView
93+
android:id="@+id/findInPageMenuItem"
94+
style="@style/BrowserTextMenuItem"
95+
android:enabled="false"
96+
android:text="@string/find_in_page" />
97+
98+
<TextView
99+
android:id="@+id/settingsPopupMenuItem"
100+
style="@style/BrowserTextMenuItem"
101+
android:enabled="false"
102+
android:text="@string/settingsMenuItemTitle" />
103+
104+
</LinearLayout>
105+
106+
</ScrollView>
97107

98-
</LinearLayout>
99108

100109
</android.support.constraint.ConstraintLayout>

0 commit comments

Comments
 (0)