Skip to content

Commit 686949c

Browse files
authored
Fix unit tests with subscriptions staging patch (#6868)
Task/Issue URL: https://app.asana.com/1/137249556945/project/1209991789468715/task/1211521379345860?focus=true ### Description ### Steps to test this PR - [x] Apply patch from https://app.asana.com/1/137249556945/project/1209991789468715/task/1210448620621729?focus=true - [x] Verify tests in RealSubscriptionsTest class are green ### No UI changes
1 parent e7be3ff commit 686949c

File tree

1 file changed

+15
-4
lines changed

1 file changed

+15
-4
lines changed

subscriptions/subscriptions-impl/src/test/java/com/duckduckgo/subscriptions/impl/RealSubscriptionsTest.kt

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,10 @@ class RealSubscriptionsTest {
272272
subscriptions.launchPrivacyPro(context, "https://duckduckgo.com/pro?featurePage=duckai".toUri())
273273

274274
verify(globalActivityStarter, times(2)).startIntent(eq(context), captor.capture())
275-
assertEquals("${subscriptionsUrlProvider.buyUrl}?featurePage=duckai", (captor.lastValue as SubscriptionsWebViewActivityWithParams).url)
275+
assertEquals(
276+
subscriptionsUrlProvider.buyUrl.appendQueryParams("featurePage=duckai"),
277+
(captor.lastValue as SubscriptionsWebViewActivityWithParams).url,
278+
)
276279
}
277280

278281
@Test
@@ -285,7 +288,7 @@ class RealSubscriptionsTest {
285288

286289
verify(globalActivityStarter, times(2)).startIntent(eq(context), captor.capture())
287290
assertEquals(
288-
"${subscriptionsUrlProvider.buyUrl}?usePaidDuckAi=true&featurePage=duckai",
291+
subscriptionsUrlProvider.buyUrl.appendQueryParams("usePaidDuckAi=true&featurePage=duckai"),
289292
(captor.lastValue as SubscriptionsWebViewActivityWithParams).url,
290293
)
291294
}
@@ -299,7 +302,10 @@ class RealSubscriptionsTest {
299302
subscriptions.launchPrivacyPro(context, "https://duckduckgo.com/subscriptions?featurePage=duckai".toUri())
300303

301304
verify(globalActivityStarter, times(2)).startIntent(eq(context), captor.capture())
302-
assertEquals("${subscriptionsUrlProvider.buyUrl}?featurePage=duckai", (captor.lastValue as SubscriptionsWebViewActivityWithParams).url)
305+
assertEquals(
306+
subscriptionsUrlProvider.buyUrl.appendQueryParams("featurePage=duckai"),
307+
(captor.lastValue as SubscriptionsWebViewActivityWithParams).url,
308+
)
303309
}
304310

305311
@Test
@@ -312,7 +318,7 @@ class RealSubscriptionsTest {
312318

313319
verify(globalActivityStarter, times(2)).startIntent(eq(context), captor.capture())
314320
assertEquals(
315-
"${subscriptionsUrlProvider.buyUrl}?usePaidDuckAi=true&featurePage=duckai",
321+
subscriptionsUrlProvider.buyUrl.appendQueryParams("usePaidDuckAi=true&featurePage=duckai"),
316322
(captor.lastValue as SubscriptionsWebViewActivityWithParams).url,
317323
)
318324
}
@@ -342,4 +348,9 @@ class RealSubscriptionsTest {
342348
private fun fakeIntent(): Intent {
343349
return Intent().also { it.addFlags(FLAG_ACTIVITY_NEW_TASK) }
344350
}
351+
352+
private fun String.appendQueryParams(queryParams: String): String {
353+
val separator = if (this.contains("?")) "&" else "?"
354+
return this + separator + queryParams
355+
}
345356
}

0 commit comments

Comments
 (0)