Skip to content

Commit 6b0b243

Browse files
authored
Update content scope scripts workflow description (#6387)
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1210785772751175?focus=true ### Description This PR enhances the automated content scope scripts update workflow by: 1. Clarifying when tests need to run: - Tests will only run if the `node_modules/@duckduckgo/content-scope-scripts` folder content has changed - If only the package version changed, tests don't need to run 2. Adding clearer PR checklist with two scenarios: - When content-scope-scripts folder is updated: all tests and privacy tests must pass - When only the package version is updated: all tests must pass but privacy tests can be skipped 3. Updating the Asana task description to include the same clarification about when tests need to run ### Steps to test this PR _Workflow Changes_ - [x] Confirm PR description includes the correct checklist based on what was updated
1 parent fbf0b29 commit 6b0b243

File tree

1 file changed

+16
-1
lines changed

1 file changed

+16
-1
lines changed

.github/workflows/update-content-scope.yml

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,20 @@ jobs:
7070
- Automated content scope scripts dependency update
7171
7272
This PR updates the content scope scripts dependency to the latest available version and copies the necessary files.
73+
74+
Tests will only run if something has changed in the `node_modules/@duckduckgo/content-scope-scripts` folder.
75+
76+
If only the package version has changed, there is no need to run the tests.
77+
7378
If tests have failed, see https://app.asana.com/0/1202561462274611/1203986899650836/f for further information on what to do next.
7479
80+
_`content-scope-scripts` folder update_
81+
- [ ] All tests must pass
82+
- [ ] Privacy tests must pass
83+
84+
_Only `content-scope-scripts` package update_
7585
- [ ] All tests must pass
86+
- [ ] Privacy tests do not need to run
7687
7788
- name: Create Asana task in Android App project
7889
if: ${{ steps.update-check.outcome == 'failure' }}
@@ -86,7 +97,11 @@ jobs:
8697
asana-task-description: |
8798
Content scope scripts have been updated and a PR created.
8899
89-
If tests failed check out https://app.asana.com/0/1202561462274611/1203986899650836/f for further information on what to do next.
100+
Tests will **only** run if something has changed in the `node_modules/@duckduckgo/content-scope-scripts` folder.
101+
102+
If only `content-scope-scripts` package version has changed, there is no need to run the tests.
103+
104+
If tests have failed, see https://app.asana.com/0/1202561462274611/1203986899650836/f for further information on what to do next.
90105
91106
See ${{ steps.create-pr.outputs.pull-request-url }}
92107
action: 'create-asana-task'

0 commit comments

Comments
 (0)