Skip to content

Commit 6b0f4d6

Browse files
Disable use our app flow experiment and enable serp variants. (#910)
1 parent d7a875e commit 6b0f4d6

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ class VariantManagerTest {
3232
@Test
3333
fun serpControlVariantHasExpectedWeightAndNoFeatures() {
3434
val variant = variants.first { it.key == "sc" }
35-
assertEqualsDouble(0.0, variant.weight)
35+
assertEqualsDouble(1.0, variant.weight)
3636
assertEquals(0, variant.features.size)
3737
}
3838

3939
@Test
4040
fun serpExperimentalVariantHasExpectedWeightAndNoFeatures() {
4141
val variant = variants.first { it.key == "se" }
42-
assertEqualsDouble(0.0, variant.weight)
42+
assertEqualsDouble(1.0, variant.weight)
4343
assertEquals(0, variant.features.size)
4444
}
4545

@@ -160,14 +160,14 @@ class VariantManagerTest {
160160
@Test
161161
fun inBrowserControlVariantHasExpectedWeightAndNoFeatures() {
162162
val variant = variants.first { it.key == "zj" }
163-
assertEqualsDouble(1.0, variant.weight)
163+
assertEqualsDouble(0.0, variant.weight)
164164
assertEquals(0, variant.features.size)
165165
}
166166

167167
@Test
168168
fun inBrowserSecondControlVariantHasExpectedWeightAndRemoveDay1And3NotificationsAndKillOnboardingFeatures() {
169169
val variant = variants.first { it.key == "zk" }
170-
assertEqualsDouble(1.0, variant.weight)
170+
assertEqualsDouble(0.0, variant.weight)
171171
assertEquals(2, variant.features.size)
172172
assertTrue(variant.hasFeature(KillOnboarding))
173173
assertTrue(variant.hasFeature(RemoveDay1AndDay3Notifications))
@@ -176,7 +176,7 @@ class VariantManagerTest {
176176
@Test
177177
fun inBrowserInAppUsageVariantHasExpectedWeightAndRemoveDay1And3NotificationsAndKillOnboardingAndInAppUsageFeatures() {
178178
val variant = variants.first { it.key == "zl" }
179-
assertEqualsDouble(1.0, variant.weight)
179+
assertEqualsDouble(0.0, variant.weight)
180180
assertEquals(3, variant.features.size)
181181
assertTrue(variant.hasFeature(KillOnboarding))
182182
assertTrue(variant.hasFeature(RemoveDay1AndDay3Notifications))

app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ interface VariantManager {
5252
val ACTIVE_VARIANTS = listOf(
5353
// SERP variants. "sc" may also be used as a shared control for mobile experiments in
5454
// the future if we can filter by app version
55-
Variant(key = "sc", weight = 0.0, features = emptyList(), filterBy = { noFilter() }),
56-
Variant(key = "se", weight = 0.0, features = emptyList(), filterBy = { noFilter() }),
55+
Variant(key = "sc", weight = 1.0, features = emptyList(), filterBy = { noFilter() }),
56+
Variant(key = "se", weight = 1.0, features = emptyList(), filterBy = { noFilter() }),
5757

5858
// Notification Drip Experiment
5959
Variant(
@@ -93,15 +93,15 @@ interface VariantManager {
9393
Variant(key = "zi", weight = 0.0, features = listOf(VariantFeature.SerpHeaderRemoval), filterBy = { noFilter() }),
9494

9595
// InAppUsage Experiments
96-
Variant(key = "zj", weight = 1.0, features = emptyList(), filterBy = { isEnglishLocale() }),
96+
Variant(key = "zj", weight = 0.0, features = emptyList(), filterBy = { isEnglishLocale() }),
9797
Variant(
9898
key = "zk",
99-
weight = 1.0,
99+
weight = 0.0,
100100
features = listOf(VariantFeature.KillOnboarding, VariantFeature.RemoveDay1AndDay3Notifications),
101101
filterBy = { isEnglishLocale() }),
102102
Variant(
103103
key = "zl",
104-
weight = 1.0,
104+
weight = 0.0,
105105
features = listOf(VariantFeature.KillOnboarding, VariantFeature.InAppUsage, VariantFeature.RemoveDay1AndDay3Notifications),
106106
filterBy = { isEnglishLocale() })
107107

0 commit comments

Comments
 (0)