Keep fallback for subscription events

Author: CrisBarreiro

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

@@ -1208,27 +1208,33 @@ class BrowserTabFragment :
     private fun onOmnibarCustomTabPrivacyDashboardPressed() {
         val params = PrivacyDashboardPrimaryScreen(tabId)
         val intent = globalActivityStarter.startIntent(requireContext(), params)
-        webViewClient.postMessage(createBreakageReportingEventData())
-        // contentScopeScripts.sendSubscriptionEvent(createBreakageReportingEventData())
+        postBreakageReportingEvent()
         intent?.let { activityResultPrivacyDashboard.launch(intent) }
         pixel.fire(CustomTabPixelNames.CUSTOM_TABS_PRIVACY_DASHBOARD_OPENED)
     }
 
+    private fun postBreakageReportingEvent() {
+        appCoroutineScope.launch {
+            val eventData = createBreakageReportingEventData()
+            webViewClient.postMessage(eventData) {
+                contentScopeScripts.sendSubscriptionEvent(eventData)
+            }
+        }
+    }
+
     private fun onFireButtonPressed() {
         val isFocusedNtp = omnibar.viewMode == ViewMode.NewTab && omnibar.getText().isEmpty() && omnibar.omnibarTextInput.hasFocus()
         browserActivity?.launchFire(launchedFromFocusedNtp = isFocusedNtp)
         viewModel.onFireMenuSelected()
     }
 
     private fun onBrowserMenuButtonPressed() {
-        webViewClient.postMessage(createBreakageReportingEventData())
-        // contentScopeScripts.sendSubscriptionEvent(createBreakageReportingEventData())
+        postBreakageReportingEvent()
         viewModel.onBrowserMenuClicked(isCustomTab = isActiveCustomTab())
     }
 
     private fun onOmnibarPrivacyShieldButtonPressed() {
-        webViewClient.postMessage(createBreakageReportingEventData())
-        // contentScopeScripts.sendSubscriptionEvent(createBreakageReportingEventData())
+        postBreakageReportingEvent()
         viewModel.onOmnibarPrivacyShieldButtonPressed()
         launchPrivacyDashboard(toggle = false)
     }

app/src/main/java/com/duckduckgo/app/browser/BrowserWebViewClient.kt

@@ -783,9 +783,14 @@ class BrowserWebViewClient @Inject constructor(
         }
     }
 
-    fun postMessage(eventData: SubscriptionEventData) {
+    fun postMessage(
+        eventData: SubscriptionEventData,
+        fallback: () -> Unit
+    ) {
         webMessagingPlugins.getPlugins().forEach {
-            it.postMessage(eventData)
+            if (!it.postMessage(eventData)) {
+                fallback()
+            }
         }
     }
 }

content-scope-scripts/content-scope-scripts-api/src/main/java/com/duckduckgo/contentscopescripts/api/WebMessagingPlugin.kt

@@ -30,5 +30,5 @@ interface WebMessagingPlugin {
         unregisterer: suspend (objectName: String) -> Boolean,
     )
 
-    fun postMessage(subscriptionEventData: SubscriptionEventData)
+    fun postMessage(subscriptionEventData: SubscriptionEventData): Boolean
 }

content-scope-scripts/content-scope-scripts-impl/src/main/java/com/duckduckgo/contentscopescripts/impl/messaging/WebCompatMessagingPlugin.kt

@@ -151,8 +151,8 @@ class WebCompatMessagingPlugin @Inject constructor(
     }
 
     @SuppressLint("RequiresFeature")
-    override fun postMessage(subscriptionEventData: SubscriptionEventData) {
-        runCatching {
+    override fun postMessage(subscriptionEventData: SubscriptionEventData): Boolean {
+        return runCatching {
             val subscriptionEvent = SubscriptionEvent(
                 context = context,
                 featureName = subscriptionEventData.featureName,
@@ -162,7 +162,9 @@ class WebCompatMessagingPlugin @Inject constructor(
                 moshi.adapter(SubscriptionEvent::class.java).toJson(it)
             }
 
-            globalReplyProxy?.postMessage(subscriptionEvent)
-        }
+            globalReplyProxy?.postMessage(subscriptionEvent)?.let {
+                true
+            } ?: false
+        }.getOrElse { false }
     }
 }

js-messaging/js-messaging-api/src/main/java/com/duckduckgo/js/messaging/api/AdsjsMessaging.kt

@@ -19,6 +19,18 @@ package com.duckduckgo.js.messaging.api
 import org.json.JSONObject
 
 interface WebViewCompatMessageCallback {
+    /**
+     * Processes a JavaScript message received by the WebView.
+     *
+     * This method is responsible for handling a message with the given parameters
+     * and invoking a callback to send a response back to the JavaScript code.
+     *
+     * @param featureName The name of the feature associated with the message.
+     * @param method The method name of the message.
+     * @param id An optional identifier for the message.
+     * @param data An optional JSON object containing additional data for the message.
+     * @param onResponse A callback function to send a response back to the JavaScript code.
+     */
     fun process(
         featureName: String,
         method: String,