Skip to content

Commit 6ea4eac

Browse files
committed
Amend as per PR comments
1 parent ec6b637 commit 6ea4eac

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

app/src/androidTest/java/com/duckduckgo/app/email/EmailJavascriptInterfaceTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class EmailJavascriptInterfaceTest {
4040

4141
@Before
4242
fun setup() {
43-
testee = EmailJavascriptInterface(mockEmailManager, { counter++ }, mockWebView, DuckDuckGoUrlDetector(), coroutineRule.testDispatcherProvider)
43+
testee = EmailJavascriptInterface(mockEmailManager, mockWebView, DuckDuckGoUrlDetector(), coroutineRule.testDispatcherProvider) { counter++ }
4444
}
4545

4646
@Test

app/src/main/java/com/duckduckgo/app/email/EmailInjector.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class EmailInjectorJs(private val emailManager: EmailManager, private val urlDet
3535
private val javaScriptInjector = JavaScriptInjector()
3636

3737
override fun addJsInterface(webView: WebView, onTooltipShown: () -> Unit) {
38-
webView.addJavascriptInterface(EmailJavascriptInterface(emailManager, onTooltipShown, webView, urlDetector, dispatcherProvider), JAVASCRIPT_INTERFACE_NAME)
38+
webView.addJavascriptInterface(EmailJavascriptInterface(emailManager, webView, urlDetector, dispatcherProvider, onTooltipShown), JAVASCRIPT_INTERFACE_NAME)
3939
}
4040

4141
@UiThread

app/src/main/java/com/duckduckgo/app/email/EmailJavascriptInterface.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ import kotlinx.coroutines.runBlocking
2424

2525
class EmailJavascriptInterface(
2626
private val emailManager: EmailManager,
27-
private val showNativeTooltip: () -> Unit,
2827
private val webView: WebView,
2928
private val urlDetector: DuckDuckGoUrlDetector,
30-
private val dispatcherProvider: DispatcherProvider
29+
private val dispatcherProvider: DispatcherProvider,
30+
private val showNativeTooltip: () -> Unit
3131
) {
3232

3333
private fun isUrlFromDuckDuckGoEmail(): Boolean {

0 commit comments

Comments
 (0)