Fix: Tab swiping taking over Duck Player (#6005)

Task/Issue URL:
https://app.asana.com/1/137249556945/project/488551667048375/task/1210107135506123?focus=true

### Description

This PR disables the tab swiping when the browser is in full-screen
mode. This fixes an issue when playing a video in Duck player in
full-screen mode and it is not possible to control the player.

### Steps to test this PR

- [x] Open a video in Duck player
- [x] Toggle the full-screen mode
- [x] Verify the tab swiping is completely disabled
- [x] Toggled off the full-screen mode
- [x] Verify the tab swiping on the omnibar works as expected

---------

Co-authored-by: Cris Barreiro <[email protected]>

Author: 0nko

app/src/main/java/com/duckduckgo/app/browser/BrowserActivity.kt

@@ -88,6 +88,7 @@ import com.duckduckgo.common.ui.experiments.visual.store.VisualDesignExperimentD
 import com.duckduckgo.common.ui.tabs.SwipingTabsFeatureProvider
 import com.duckduckgo.common.ui.view.dialog.TextAlertDialogBuilder
 import com.duckduckgo.common.ui.view.gone
+import com.duckduckgo.common.ui.view.isFullScreen
 import com.duckduckgo.common.ui.view.show
 import com.duckduckgo.common.ui.view.toPx
 import com.duckduckgo.common.ui.viewbinding.viewBinding
@@ -759,6 +760,14 @@ open class BrowserActivity : DuckDuckGoActivity() {
         )
     }
 
+    override fun toggleFullScreen() {
+        super.toggleFullScreen()
+
+        if (swipingTabsFeature.isEnabled) {
+            viewModel.onFullScreenModeChanged(isFullScreen())
+        }
+    }
+
     companion object {
 
         fun intent(

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

@@ -187,11 +187,8 @@ import com.duckduckgo.app.fire.fireproofwebsite.data.website
 import com.duckduckgo.app.global.model.PrivacyShield.UNKNOWN
 import com.duckduckgo.app.global.model.orderedTrackerBlockedEntities
 import com.duckduckgo.app.global.view.NonDismissibleBehavior
-import com.duckduckgo.app.global.view.isFullScreen
-import com.duckduckgo.app.global.view.isImmersiveModeEnabled
 import com.duckduckgo.app.global.view.launchDefaultAppActivity
 import com.duckduckgo.app.global.view.renderIfChanged
-import com.duckduckgo.app.global.view.toggleFullScreen
 import com.duckduckgo.app.pixels.AppPixelName
 import com.duckduckgo.app.privatesearch.PrivateSearchScreenNoParams
 import com.duckduckgo.app.settings.db.SettingsDataStore
@@ -236,6 +233,7 @@ import com.duckduckgo.browser.api.WebViewVersionProvider
 import com.duckduckgo.browser.api.brokensite.BrokenSiteData
 import com.duckduckgo.browser.api.brokensite.BrokenSiteData.ReportFlow.RELOAD_THREE_TIMES_WITHIN_20_SECONDS
 import com.duckduckgo.browser.api.ui.BrowserScreens.WebViewActivityWithParams
+import com.duckduckgo.common.ui.DuckDuckGoActivity
 import com.duckduckgo.common.ui.DuckDuckGoFragment
 import com.duckduckgo.common.ui.experiments.visual.store.VisualDesignExperimentDataStore
 import com.duckduckgo.common.ui.store.BrowserAppTheme
@@ -251,6 +249,8 @@ import com.duckduckgo.common.ui.view.getColorFromAttr
 import com.duckduckgo.common.ui.view.gone
 import com.duckduckgo.common.ui.view.hide
 import com.duckduckgo.common.ui.view.hideKeyboard
+import com.duckduckgo.common.ui.view.isFullScreen
+import com.duckduckgo.common.ui.view.isImmersiveModeEnabled
 import com.duckduckgo.common.ui.view.makeSnackbarWithNoBottomInset
 import com.duckduckgo.common.ui.view.show
 import com.duckduckgo.common.ui.view.toPx
@@ -4378,15 +4378,15 @@ class BrowserTabFragment :
         private fun goFullScreen() {
             omnibar.hide()
             binding.webViewFullScreenContainer.show()
-            activity?.toggleFullScreen()
+            (activity as? DuckDuckGoActivity)?.toggleFullScreen()
             showToast(R.string.fullScreenMessage, Toast.LENGTH_SHORT)
         }
 
         private fun exitFullScreen() {
             omnibar.show()
             binding.webViewFullScreenContainer.removeAllViews()
             binding.webViewFullScreenContainer.gone()
-            activity?.toggleFullScreen()
+            (activity as? DuckDuckGoActivity)?.toggleFullScreen()
             binding.focusDummy.requestFocus()
         }
     }

app/src/main/java/com/duckduckgo/app/browser/BrowserViewModel.kt

@@ -104,8 +104,11 @@ class BrowserViewModel @Inject constructor(
 
     data class ViewState(
         val hideWebContent: Boolean = true,
-        val isTabSwipingEnabled: Boolean = false,
-    )
+        private val isInEditMode: Boolean = false,
+        private val isInFullScreenMode: Boolean = false,
+    ) {
+        val isTabSwipingEnabled: Boolean = !isInEditMode && !isInFullScreenMode
+    }
 
     sealed class Command {
         data class Query(val query: String) : Command()
@@ -424,7 +427,11 @@ class BrowserViewModel @Inject constructor(
     }
 
     fun onOmnibarEditModeChanged(isInEditMode: Boolean) {
-        viewState.value = currentViewState.copy(isTabSwipingEnabled = !isInEditMode)
+        viewState.value = currentViewState.copy(isInEditMode = isInEditMode)
+    }
+
+    fun onFullScreenModeChanged(isFullScreen: Boolean) {
+        viewState.value = currentViewState.copy(isInFullScreenMode = isFullScreen)
     }
 
     // user has not tapped the Undo action -> purge the deletable tabs and remove all data

app/src/main/java/com/duckduckgo/app/fire/FireActivity.kt

@@ -23,8 +23,8 @@ import android.os.Bundle
 import androidx.appcompat.app.AppCompatActivity
 import com.duckduckgo.anvil.annotations.InjectWith
 import com.duckduckgo.app.browser.BrowserActivity
-import com.duckduckgo.app.global.view.fadeTransitionConfig
-import com.duckduckgo.app.global.view.noAnimationConfig
+import com.duckduckgo.common.ui.view.fadeTransitionConfig
+import com.duckduckgo.common.ui.view.noAnimationConfig
 import com.duckduckgo.di.scopes.ActivityScope
 
 /**

app/src/main/java/com/duckduckgo/app/generalsettings/GeneralSettingsActivity.kt

@@ -36,11 +36,11 @@ import com.duckduckgo.app.generalsettings.showonapplaunch.model.ShowOnAppLaunchO
 import com.duckduckgo.app.generalsettings.showonapplaunch.model.ShowOnAppLaunchOption.LastOpenedTab
 import com.duckduckgo.app.generalsettings.showonapplaunch.model.ShowOnAppLaunchOption.NewTabPage
 import com.duckduckgo.app.generalsettings.showonapplaunch.model.ShowOnAppLaunchOption.SpecificPage
-import com.duckduckgo.app.global.view.fadeTransitionConfig
 import com.duckduckgo.browser.api.ui.BrowserScreens.WebViewActivityWithParams
 import com.duckduckgo.common.ui.DuckDuckGoActivity
 import com.duckduckgo.common.ui.spans.DuckDuckGoClickableSpan
 import com.duckduckgo.common.ui.view.addClickableSpan
+import com.duckduckgo.common.ui.view.fadeTransitionConfig
 import com.duckduckgo.common.ui.viewbinding.viewBinding
 import com.duckduckgo.di.scopes.ActivityScope
 import com.duckduckgo.navigation.api.GlobalActivityStarter

app/src/main/java/com/duckduckgo/app/global/view/ActivityExtension.kt renamed to app/src/main/java/com/duckduckgo/app/global/view/LaunchActivityExtensions.kt

@@ -19,11 +19,7 @@ package com.duckduckgo.app.global.view
 import android.content.ActivityNotFoundException
 import android.content.Context
 import android.content.Intent
-import android.content.pm.ActivityInfo
-import android.os.Bundle
-import android.view.View
 import android.widget.Toast
-import androidx.core.app.ActivityOptionsCompat
 import androidx.fragment.app.FragmentActivity
 import com.duckduckgo.app.browser.R
 import com.duckduckgo.app.browser.defaultbrowsing.DefaultBrowserSystemSettings
@@ -47,34 +43,3 @@ fun Context.launchDefaultAppActivity() {
         Toast.makeText(this, errorMessage, Toast.LENGTH_SHORT).show()
     }
 }
-
-fun Context.fadeTransitionConfig(): Bundle? {
-    val config = ActivityOptionsCompat.makeCustomAnimation(this, android.R.anim.fade_in, android.R.anim.fade_out)
-    return config.toBundle()
-}
-
-fun Context.noAnimationConfig(): Bundle? =
-    ActivityOptionsCompat.makeCustomAnimation(this, 0, 0).toBundle()
-
-fun FragmentActivity.toggleFullScreen() {
-    if (isFullScreen()) {
-        // If we are exiting full screen, reset the orientation
-        requestedOrientation = ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED
-    }
-
-    val newUiOptions = window.decorView.systemUiVisibility
-        .xor(View.SYSTEM_UI_FLAG_HIDE_NAVIGATION)
-        .xor(View.SYSTEM_UI_FLAG_FULLSCREEN)
-        .xor(View.SYSTEM_UI_FLAG_IMMERSIVE_STICKY)
-
-    window.decorView.systemUiVisibility = newUiOptions
-}
-
-fun FragmentActivity.isFullScreen(): Boolean {
-    return window.decorView.systemUiVisibility.and(View.SYSTEM_UI_FLAG_FULLSCREEN) == View.SYSTEM_UI_FLAG_FULLSCREEN
-}
-
-fun FragmentActivity.isImmersiveModeEnabled(): Boolean {
-    val uiOptions = window.decorView.systemUiVisibility
-    return uiOptions or View.SYSTEM_UI_FLAG_IMMERSIVE_STICKY == uiOptions
-}

app/src/test/java/com/duckduckgo/app/browser/BrowserViewModelTest.kt

@@ -462,6 +462,50 @@ class BrowserViewModelTest {
         assertEquals(!isInEditMode, testee.viewState.value!!.isTabSwipingEnabled)
     }
 
+    @Test
+    fun whenBrowserIsNotInFullscreenModeTabSwipingIsEnabled() {
+        swipingTabsFeature.self().setRawStoredState(State(enable = true))
+
+        val isFullScreen = false
+        testee.onFullScreenModeChanged(isFullScreen)
+        assertEquals(true, testee.viewState.value!!.isTabSwipingEnabled)
+    }
+
+    @Test
+    fun whenBrowserIsInFullscreenModeTabSwipingIsDisabled() {
+        swipingTabsFeature.self().setRawStoredState(State(enable = true))
+
+        val isFullScreen = true
+        testee.onFullScreenModeChanged(isFullScreen)
+        assertEquals(false, testee.viewState.value!!.isTabSwipingEnabled)
+    }
+
+    @Test
+    fun whenOmnibarIsNotInEditModeAndBrowserIsInFullscreenModeTabSwipingIsDisabled() {
+        swipingTabsFeature.self().setRawStoredState(State(enable = true))
+
+        val isFullScreen = true
+        testee.onFullScreenModeChanged(isFullScreen)
+
+        val isInEditMode = false
+        testee.onOmnibarEditModeChanged(isInEditMode)
+
+        assertEquals(false, testee.viewState.value!!.isTabSwipingEnabled)
+    }
+
+    @Test
+    fun whenOmnibarIsInEditModeAndBrowserIsNotInFullscreenModeTabSwipingIsDisabled() {
+        swipingTabsFeature.self().setRawStoredState(State(enable = true))
+
+        val isFullScreen = false
+        testee.onFullScreenModeChanged(isFullScreen)
+
+        val isInEditMode = true
+        testee.onOmnibarEditModeChanged(isInEditMode)
+
+        assertEquals(false, testee.viewState.value!!.isTabSwipingEnabled)
+    }
+
     private fun initTestee() {
         testee = BrowserViewModel(
             tabRepository = mockTabRepository,

common/common-ui/src/main/java/com/duckduckgo/common/ui/DuckDuckGoActivity.kt

@@ -20,15 +20,18 @@ import android.annotation.SuppressLint
 import android.app.UiModeManager
 import android.content.BroadcastReceiver
 import android.content.Context
+import android.content.pm.ActivityInfo
 import android.os.Bundle
 import android.view.MenuItem
+import android.view.View
 import androidx.appcompat.widget.Toolbar
 import androidx.lifecycle.ViewModel
 import androidx.lifecycle.ViewModelProvider
 import androidx.localbroadcastmanager.content.LocalBroadcastManager
 import com.duckduckgo.common.ui.DuckDuckGoTheme.DARK
 import com.duckduckgo.common.ui.DuckDuckGoTheme.EXPERIMENT_DARK
 import com.duckduckgo.common.ui.store.ThemingDataStore
+import com.duckduckgo.common.ui.view.isFullScreen
 import com.duckduckgo.mobile.android.R
 import dagger.android.AndroidInjection
 import dagger.android.DaggerActivity
@@ -106,4 +109,18 @@ abstract class DuckDuckGoActivity : DaggerActivity() {
     protected inline fun <reified V : ViewModel> bindViewModel() = lazy {
         ViewModelProvider(this, viewModelFactory).get(V::class.java)
     }
+
+    open fun toggleFullScreen() {
+        if (isFullScreen()) {
+            // If we are exiting full screen, reset the orientation
+            requestedOrientation = ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED
+        }
+
+        val newUiOptions = window.decorView.systemUiVisibility
+            .xor(View.SYSTEM_UI_FLAG_HIDE_NAVIGATION)
+            .xor(View.SYSTEM_UI_FLAG_FULLSCREEN)
+            .xor(View.SYSTEM_UI_FLAG_IMMERSIVE_STICKY)
+
+        window.decorView.systemUiVisibility = newUiOptions
+    }
 }

common/common-ui/src/main/java/com/duckduckgo/common/ui/view/ActivityExtensions.kt

@@ -0,0 +1,40 @@
+/*
+ * Copyright (c) 2018 DuckDuckGo
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.duckduckgo.common.ui.view
+
+import android.content.Context
+import android.os.Bundle
+import android.view.View
+import androidx.core.app.ActivityOptionsCompat
+import androidx.fragment.app.FragmentActivity
+
+fun Context.fadeTransitionConfig(): Bundle? {
+    val config = ActivityOptionsCompat.makeCustomAnimation(this, android.R.anim.fade_in, android.R.anim.fade_out)
+    return config.toBundle()
+}
+
+fun Context.noAnimationConfig(): Bundle? =
+    ActivityOptionsCompat.makeCustomAnimation(this, 0, 0).toBundle()
+
+fun FragmentActivity.isFullScreen(): Boolean {
+    return window.decorView.systemUiVisibility.and(View.SYSTEM_UI_FLAG_FULLSCREEN) == View.SYSTEM_UI_FLAG_FULLSCREEN
+}
+
+fun FragmentActivity.isImmersiveModeEnabled(): Boolean {
+    val uiOptions = window.decorView.systemUiVisibility
+    return uiOptions or View.SYSTEM_UI_FLAG_IMMERSIVE_STICKY == uiOptions
+}