Fix download confirmation fragment illegal state exception

subsymbolic · subsymbolic · commit 7606bd68e398 · 2020-04-15T13:13:21.000+01:00
diff --git a/app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt b/app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt
@@ -1098,7 +1098,9 @@ class BrowserTabFragment : Fragment(), FindListener, CoroutineScope {
 
     private fun requestDownloadConfirmation(pendingDownload: PendingFileDownload, downloadListener: FileDownloadListener) {
         fragmentManager?.let {
-            DownloadConfirmationFragment.instance(pendingDownload, downloadListener).show(it, DOWNLOAD_CONFIRMATION_TAG)
+            if (!it.isStateSaved) {
+                DownloadConfirmationFragment.instance(pendingDownload, downloadListener).show(it, DOWNLOAD_CONFIRMATION_TAG)
+            }
         }
     }
 
diff --git a/app/version/version.properties b/app/version/version.properties
@@ -1 +1 @@
-VERSION=5.50.0
+VERSION=5.50.1

Original file line number	Diff line number	Diff line change
`@@ -1098,7 +1098,9 @@ class BrowserTabFragment : Fragment(), FindListener, CoroutineScope {`
`1098`	`1098`
`1099`	`1099`	`private fun requestDownloadConfirmation(pendingDownload: PendingFileDownload, downloadListener: FileDownloadListener) {`
`1100`	`1100`	`fragmentManager?.let {`
`1101`		`- DownloadConfirmationFragment.instance(pendingDownload, downloadListener).show(it, DOWNLOAD_CONFIRMATION_TAG)`
	`1101`	`+ if (!it.isStateSaved) {`
	`1102`	`+ DownloadConfirmationFragment.instance(pendingDownload, downloadListener).show(it, DOWNLOAD_CONFIRMATION_TAG)`
	`1103`	`+ }`
`1102`	`1104`	`}`
`1103`	`1105`	`}`
`1104`	`1106`