Skip to content

Commit 79e6c57

Browse files
authored
avoid keeping reference to dialog instance (#1126)
1 parent ae1a549 commit 79e6c57

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

app/src/main/java/com/duckduckgo/app/browser/BrowserActivity.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,6 @@ class BrowserActivity : DuckDuckGoActivity(), CoroutineScope by MainScope() {
9292

9393
private var lastIntent: Intent? = null
9494

95-
private var currentAppEnjoymentFragment: DialogFragment? = null
96-
9795
private lateinit var renderer: BrowserStateRenderer
9896

9997
private var openMessageInNewTabJob: Job? = null
@@ -433,9 +431,8 @@ class BrowserActivity : DuckDuckGoActivity(), CoroutineScope by MainScope() {
433431
get() = (flags and Intent.FLAG_ACTIVITY_LAUNCHED_FROM_HISTORY) == Intent.FLAG_ACTIVITY_LAUNCHED_FROM_HISTORY
434432

435433
private fun showAppEnjoymentPrompt(prompt: DialogFragment) {
436-
currentAppEnjoymentFragment?.dismiss()
434+
(supportFragmentManager.findFragmentByTag(APP_ENJOYMENT_DIALOG_TAG) as? DialogFragment)?.dismiss()
437435
prompt.show(supportFragmentManager, APP_ENJOYMENT_DIALOG_TAG)
438-
currentAppEnjoymentFragment = prompt
439436
}
440437

441438
private fun hideWebContent() {

0 commit comments

Comments
 (0)