Add ScrollView to fix Dax being cutoff when keyboard appears (#1238)

* Add ScrollView to fix Dax being cutoff when keyboard appears

* Fill viewport so that widget CTA dialog is shown at the bottom of the screen

Author: joshliebe

app/src/main/res/layout/include_new_browser_tab.xml

@@ -14,53 +14,59 @@
   ~ limitations under the License.
   -->
 
-<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:id="@+id/newTabLayout"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
-    android:layout_marginTop="?attr/actionBarSize"
-    android:foreground="@android:color/transparent"
+    android:fillViewport="true"
     tools:context="com.duckduckgo.app.browser.BrowserActivity"
     tools:showIn="@layout/fragment_browser_tab">
 
-    <ImageView
-        android:id="@+id/ddgLogo"
-        android:layout_width="0dp"
-        android:alpha="0"
-        android:layout_height="wrap_content"
-        android:contentDescription="@string/duckDuckGoLogoDescription"
-        android:src="@drawable/logo_full"
-        app:layout_constraintEnd_toEndOf="parent"
-        app:layout_constraintHeight_max="180dp"
-        app:layout_constraintStart_toStartOf="parent"
-        android:layout_marginTop="@dimen/homeTabDdgLogoTopMargin"
-        app:layout_constraintTop_toTopOf="parent"
-        app:layout_constraintWidth_max="180dp"
-        android:visibility="gone"/>
+    <androidx.constraintlayout.widget.ConstraintLayout
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:layout_marginTop="?attr/actionBarSize"
+        android:foreground="@android:color/transparent">
 
-    <include
-        layout="@layout/include_dax_dialog_cta"
-        android:layout_width="0dp"
-        android:layout_height="wrap_content"
-        android:layout_marginTop="40dp"
-        app:layout_constraintEnd_toEndOf="parent"
-        app:layout_constraintStart_toStartOf="parent"
-        app:layout_constraintTop_toTopOf="parent"
-        app:layout_constraintWidth_max="600dp"
-        android:visibility="gone"/>
+        <ImageView
+            android:id="@+id/ddgLogo"
+            android:layout_width="0dp"
+            android:alpha="0"
+            android:layout_height="wrap_content"
+            android:contentDescription="@string/duckDuckGoLogoDescription"
+            android:src="@drawable/logo_full"
+            app:layout_constraintEnd_toEndOf="parent"
+            app:layout_constraintHeight_max="180dp"
+            app:layout_constraintStart_toStartOf="parent"
+            android:layout_marginTop="@dimen/homeTabDdgLogoTopMargin"
+            app:layout_constraintTop_toTopOf="parent"
+            app:layout_constraintWidth_max="180dp"
+            android:visibility="gone"/>
 
-    <LinearLayout
-        android:id="@+id/ctaContainer"
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:orientation="vertical"
-        android:visibility="gone"
-        android:elevation="12dp"
-        android:outlineProvider="paddedBounds"
-        app:layout_constraintBottom_toBottomOf="parent"
-        app:layout_constraintEnd_toEndOf="parent"
-        app:layout_constraintStart_toStartOf="parent" />
+        <include
+            layout="@layout/include_dax_dialog_cta"
+            android:layout_width="0dp"
+            android:layout_height="wrap_content"
+            android:layout_marginTop="40dp"
+            app:layout_constraintEnd_toEndOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toTopOf="parent"
+            app:layout_constraintWidth_max="600dp"
+            android:visibility="gone"/>
+
+        <LinearLayout
+            android:id="@+id/ctaContainer"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:orientation="vertical"
+            android:visibility="gone"
+            android:elevation="12dp"
+            android:outlineProvider="paddedBounds"
+            app:layout_constraintBottom_toBottomOf="parent"
+            app:layout_constraintEnd_toEndOf="parent"
+            app:layout_constraintStart_toStartOf="parent" />
 
-</androidx.constraintlayout.widget.ConstraintLayout>
+    </androidx.constraintlayout.widget.ConstraintLayout>
+</ScrollView>