Skip to content

Commit 8f04621

Browse files
authored
Fix actionlint warnings (#6440)
Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1210856879005136?focus=true ### Description Fixes actionlint warnings - `android-large-runner` is a valid runner - Fix useless cat warning - Fix potential globbing of $Flank ### Steps to test this PR - [ ] No action lint warnings on this PR - [ ] Check command behaviours match previous ### UI changes N/A
1 parent 418d441 commit 8f04621

File tree

7 files changed

+16
-11
lines changed

7 files changed

+16
-11
lines changed

.github/actionlint.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
self-hosted-runner:
2+
labels:
3+
# Stops incorrect warning of android-large-runner being used
4+
- android-large-runner

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ jobs:
141141
- name: Decode secret
142142
env:
143143
FLANK: ${{ secrets.FLANK }}
144-
run: echo $FLANK > flank.json
144+
run: echo "$FLANK" > flank.json
145145

146146
- name: Setup Gradle
147147
uses: gradle/actions/setup-gradle@v3
@@ -185,7 +185,7 @@ jobs:
185185
if: |
186186
failure() &&
187187
steps.check-alignment.outcome == 'success'
188-
run: cat build/fladle/fladleResults/HtmlErrorReport.html | cut -d\` -f2 >> results.json
188+
run: cut -d\` -f2 < build/fladle/fladleResults/HtmlErrorReport.html >> results.json
189189

190190
- name: Print failure report
191191
if: |

.github/workflows/external-css-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
- name: Decode secret
5050
env:
5151
FLANK: ${{ secrets.FLANK }}
52-
run: echo $FLANK > flank.json
52+
run: echo "$FLANK" > flank.json
5353

5454
- name: Setup Gradle
5555
uses: gradle/actions/setup-gradle@v3
@@ -66,7 +66,7 @@ jobs:
6666

6767
- name: Generate json file with failures
6868
if: ${{ failure() }}
69-
run: cat build/fladle/fladleResults/HtmlErrorReport.html | cut -d\` -f2 >> results.json
69+
run: cut -d\` -f2 < build/fladle/fladleResults/HtmlErrorReport.html >> results.json
7070

7171
- name: Print failure report
7272
if: ${{ failure() }}

.github/workflows/external-ref-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ jobs:
8989
- name: Decode secret
9090
env:
9191
FLANK: ${{ secrets.FLANK }}
92-
run: echo $FLANK > flank.json
92+
run: echo "$FLANK" > flank.json
9393

9494
- name: Setup Gradle
9595
uses: gradle/actions/setup-gradle@v3
@@ -106,7 +106,7 @@ jobs:
106106

107107
- name: Generate json file with failures
108108
if: ${{ failure() }}
109-
run: cat build/fladle/fladleResults/HtmlErrorReport.html | cut -d\` -f2 >> results.json
109+
run: cut -d\` -f2 < build/fladle/fladleResults/HtmlErrorReport.html >> results.json
110110

111111
- name: Print failure report
112112
if: ${{ failure() }}

.github/workflows/nightly.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ jobs:
132132
- name: Decode secret
133133
env:
134134
FLANK: ${{ secrets.FLANK }}
135-
run: echo $FLANK > flank.json
135+
run: echo "$FLANK" > flank.json
136136

137137
- name: Setup Gradle
138138
uses: gradle/actions/setup-gradle@v3
@@ -149,7 +149,7 @@ jobs:
149149

150150
- name: Generate json file with failures
151151
if: ${{ failure() }}
152-
run: cat build/fladle/fladleResults/HtmlErrorReport.html | cut -d\` -f2 >> results.json
152+
run: cut -d\` -f2 < build/fladle/fladleResults/HtmlErrorReport.html >> results.json
153153

154154
- name: Print failure report
155155
if: ${{ failure() }}

.github/workflows/privacy.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
- name: Decode secret
5050
env:
5151
FLANK: ${{ secrets.FLANK }}
52-
run: echo $FLANK > flank.json
52+
run: echo "$FLANK" > flank.json
5353

5454
- name: Setup Gradle
5555
uses: gradle/actions/setup-gradle@v3
@@ -66,7 +66,7 @@ jobs:
6666

6767
- name: Generate json file with failures
6868
if: ${{ failure() }}
69-
run: cat build/fladle/fladleResults/HtmlErrorReport.html | cut -d\` -f2 >> results.json
69+
run: cut -d\` -f2 < build/fladle/fladleResults/HtmlErrorReport.html >> results.json
7070

7171
- name: Print failure report
7272
if: ${{ failure() }}

.github/workflows/validate_workflows.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,5 @@ jobs:
2626
github_token: ${{ secrets.GT_DAXMOBILE }}
2727
reporter: github-pr-review
2828
level: warning
29-
fail_level: warning
29+
fail_level: warning
30+
actionlint_flags: --config-file .github/actionlint.yaml

0 commit comments

Comments
 (0)