Make privacy grade clickable when grade is empty (#1088)

marcosholgado · web-flow · commit 8f49a787e2ad · 2021-02-10T09:16:31.000Z
diff --git a/app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt b/app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt
@@ -823,9 +823,9 @@ class BrowserTabViewModelTest {
     }
 
     @Test
-    fun whenShowEmptyGradeIsTrueThenIsEnableIsFalse() {
+    fun whenShowEmptyGradeIsTrueThenIsEnableIsTrue() {
         val testee = BrowserTabViewModel.PrivacyGradeViewState(PrivacyGrade.A, shouldAnimate = false, showEmptyGrade = true)
-        assertFalse(testee.isEnabled)
+        assertTrue(testee.isEnabled)
     }
 
     @Test
diff --git a/app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt b/app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
@@ -216,7 +216,7 @@ class BrowserTabViewModel(
         val shouldAnimate: Boolean = false,
         val showEmptyGrade: Boolean = true
     ) {
-        val isEnabled: Boolean = !showEmptyGrade && privacyGrade != PrivacyGrade.UNKNOWN
+        val isEnabled: Boolean = privacyGrade != PrivacyGrade.UNKNOWN
     }
 
     data class AutoCompleteViewState(

Original file line number	Diff line number	Diff line change
`@@ -823,9 +823,9 @@ class BrowserTabViewModelTest {`
`823`	`823`	`}`
`824`	`824`
`825`	`825`	`@Test`
`826`		`- fun whenShowEmptyGradeIsTrueThenIsEnableIsFalse() {`
	`826`	`+ fun whenShowEmptyGradeIsTrueThenIsEnableIsTrue() {`
`827`	`827`	`val testee = BrowserTabViewModel.PrivacyGradeViewState(PrivacyGrade.A, shouldAnimate = false, showEmptyGrade = true)`
`828`		`- assertFalse(testee.isEnabled)`
	`828`	`+ assertTrue(testee.isEnabled)`
`829`	`829`	`}`
`830`	`830`
`831`	`831`	`@Test`
Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ class BrowserTabViewModel(`
`216`	`216`	`val shouldAnimate: Boolean = false,`
`217`	`217`	`val showEmptyGrade: Boolean = true`
`218`	`218`	`) {`
`219`		`- val isEnabled: Boolean = !showEmptyGrade && privacyGrade != PrivacyGrade.UNKNOWN`
	`219`	`+ val isEnabled: Boolean = privacyGrade != PrivacyGrade.UNKNOWN`
`220`	`220`	`}`
`221`	`221`
`222`	`222`	`data class AutoCompleteViewState(`