Skip to content

Commit 97f1c23

Browse files
committed
Remove getAlias from JS interface
1 parent 9b66e7c commit 97f1c23

File tree

2 files changed

+0
-34
lines changed

2 files changed

+0
-34
lines changed

app/src/androidTest/java/com/duckduckgo/app/email/EmailJavascriptInterfaceTest.kt

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -34,29 +34,6 @@ class EmailJavascriptInterfaceTest {
3434
testee = EmailJavascriptInterface(mockEmailManager) { counter++ }
3535
}
3636

37-
@Test
38-
fun whenGetAliasThenGetAliasCalled() {
39-
givenAliasExists()
40-
41-
testee.getAlias()
42-
43-
verify(mockEmailManager).getAlias()
44-
}
45-
46-
@Test
47-
fun whenGetAliasThenReturnNextAliasWrappedInJsonObject() {
48-
givenAliasExists()
49-
50-
assertEquals("{\"nextAlias\": \"alias\"}", testee.getAlias())
51-
}
52-
53-
@Test
54-
fun whenGetAliasIfNextAliasDoesNotExistThenReturnEmpty() {
55-
givenAliasDoesNotExist()
56-
57-
assertEquals("", testee.getAlias())
58-
}
59-
6037
@Test
6138
fun whenIsSignedInThenIsSignedInCalled() {
6239
testee.isSignedIn()

app/src/main/java/com/duckduckgo/app/email/EmailJavascriptInterface.kt

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,6 @@ class EmailJavascriptInterface(
2929
Timber.i("EmailInterface $message")
3030
}
3131

32-
@JavascriptInterface
33-
fun getAlias(): String {
34-
val nextAlias = emailManager.getAlias()
35-
36-
return if (nextAlias.isNullOrBlank()) {
37-
""
38-
} else {
39-
"{\"nextAlias\": \"$nextAlias\"}"
40-
}
41-
}
42-
4332
@JavascriptInterface
4433
fun isSignedIn(): String = emailManager.isSignedIn().toString()
4534

0 commit comments

Comments
 (0)