Remove old password management list view implementation (#6473)

Task/Issue URL:
https://app.asana.com/1/137249556945/project/608920331025315/task/1209443099736785?focus=true

### Description
In #5654 we changed the
implementation of the password management screen so that everything was
rendered as a list item. We kept the old implementation around as a
fallback, guarded by a kill switch. There's been no reported issues with
the new approach.

This PR removes the old implementation. 

### Steps to test this PR

#### Normal Autofill
- [x] Smoke test normal Autofill screens, including password management
and password settings screens
- [x] Smoke test the `AutofillService` screen that happens when you to
choose to open the passwords screen to pick your own one to autofill.

---------

Co-authored-by: Craig Russell <[email protected]>

Author: CDRussell

autofill/autofill-api/src/main/java/com/duckduckgo/autofill/api/AutofillFeature.kt

@@ -131,12 +131,6 @@ interface AutofillFeature {
     @Toggle.DefaultValue(DefaultFeatureValue.TRUE)
     fun deepDomainComparisonsOnExistingCredentialsChecks(): Toggle
 
-    /**
-     * Kill switch for the new layout of list mode where everything is inside the recycler view
-     */
-    @Toggle.DefaultValue(defaultValue = DefaultFeatureValue.TRUE)
-    fun newScrollBehaviourInPasswordManagementScreen(): Toggle
-
     /**
      * Kill switch for making case insensitive checks on existing username matches
      */

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/service/AutofillSimpleCredentialsListFragment.kt

@@ -38,7 +38,9 @@ import com.duckduckgo.autofill.impl.R
 import com.duckduckgo.autofill.impl.databinding.FragmentAutofillProviderListBinding
 import com.duckduckgo.autofill.impl.deviceauth.DeviceAuthenticator
 import com.duckduckgo.autofill.impl.pixel.AutofillPixelNames.AUTOFILL_SERVICE_PASSWORDS_SEARCH
-import com.duckduckgo.autofill.impl.ui.credential.management.AutofillManagementRecyclerAdapterLegacy
+import com.duckduckgo.autofill.impl.ui.credential.management.AutofillManagementRecyclerAdapter
+import com.duckduckgo.autofill.impl.ui.credential.management.AutofillManagementRecyclerAdapter.AutofillToggleState
+import com.duckduckgo.autofill.impl.ui.credential.management.AutofillManagementRecyclerAdapter.CredentialsLoadedState.Loaded
 import com.duckduckgo.autofill.impl.ui.credential.management.sorting.CredentialGrouper
 import com.duckduckgo.autofill.impl.ui.credential.management.sorting.InitialExtractor
 import com.duckduckgo.autofill.impl.ui.credential.management.suggestion.SuggestionListBuilder
@@ -96,7 +98,7 @@ class AutofillSimpleCredentialsListFragment : DuckDuckGoFragment(R.layout.fragme
     }
 
     private val binding: FragmentAutofillProviderListBinding by viewBinding()
-    private lateinit var adapter: AutofillManagementRecyclerAdapterLegacy
+    private lateinit var adapter: AutofillManagementRecyclerAdapter
 
     private var searchMenuItem: MenuItem? = null
 
@@ -229,21 +231,35 @@ class AutofillSimpleCredentialsListFragment : DuckDuckGoFragment(R.layout.fragme
             logcat(INFO) { "DDGAutofillService showSuggestionsFor: $showSuggestionsFor" }
             val directSuggestions = suggestionMatcher.getDirectSuggestions(showSuggestionsFor, credentials)
             val shareableCredentials = suggestionMatcher.getShareableSuggestions(showSuggestionsFor)
-            adapter.updateLogins(credentials, directSuggestions, shareableCredentials, false)
+            val directSuggestionsListItems = suggestionListBuilder.build(directSuggestions, shareableCredentials, allowBreakageReporting = false)
+            val groupedCredentials = credentialGrouper.group(credentials)
+
+            withContext(dispatchers.main()) {
+                adapter.showLogins(
+                    credentialsLoadedState = Loaded(
+                        directSuggestionsListItems = directSuggestionsListItems,
+                        groupedCredentials = groupedCredentials,
+                        showGoogleImportPasswordsButton = false,
+                    ),
+                    autofillToggleState = AutofillToggleState(enabled = true, visible = false),
+                    promotionView = null,
+                )
+            }
         }
     }
 
     private fun configureRecyclerView() {
-        adapter = AutofillManagementRecyclerAdapterLegacy(
+        adapter = AutofillManagementRecyclerAdapter(
             this,
-            dispatchers = dispatchers,
             faviconManager = faviconManager,
-            grouper = credentialGrouper,
             initialExtractor = initialExtractor,
-            suggestionListBuilder = suggestionListBuilder,
             onCredentialSelected = this::onCredentialsSelected,
             onContextMenuItemClicked = { },
             onReportBreakageClicked = { },
+            onImportFromGoogleClicked = { },
+            onAutofillToggleClicked = { },
+            onImportViaDesktopSyncClicked = { },
+            launchHelpPageClicked = { },
         ).also { binding.logins.adapter = it }
     }
 

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/ui/credential/management/AutofillManagementActivity.kt

@@ -51,7 +51,6 @@ import com.duckduckgo.autofill.impl.ui.credential.management.AutofillPasswordsMa
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillPasswordsManagementViewModel.Command.ShowDeviceUnsupportedMode
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillPasswordsManagementViewModel.Command.ShowDisabledMode
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillPasswordsManagementViewModel.Command.ShowListMode
-import com.duckduckgo.autofill.impl.ui.credential.management.AutofillPasswordsManagementViewModel.Command.ShowListModeLegacy
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillPasswordsManagementViewModel.Command.ShowLockedMode
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillPasswordsManagementViewModel.Command.ShowUserPasswordCopied
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillPasswordsManagementViewModel.Command.ShowUserUsernameCopied
@@ -65,7 +64,6 @@ import com.duckduckgo.autofill.impl.ui.credential.management.viewing.AutofillMan
 import com.duckduckgo.autofill.impl.ui.credential.management.viewing.AutofillManagementDeviceUnsupportedMode
 import com.duckduckgo.autofill.impl.ui.credential.management.viewing.AutofillManagementDisabledMode
 import com.duckduckgo.autofill.impl.ui.credential.management.viewing.AutofillManagementListMode
-import com.duckduckgo.autofill.impl.ui.credential.management.viewing.AutofillManagementListModeLegacy
 import com.duckduckgo.autofill.impl.ui.credential.management.viewing.AutofillManagementLockedMode
 import com.duckduckgo.common.ui.DuckDuckGoActivity
 import com.duckduckgo.common.ui.view.SearchBar
@@ -198,8 +196,7 @@ class AutofillManagementActivity : DuckDuckGoActivity(), PasswordsScreenPromotio
             is ShowUserPasswordCopied -> showCopiedToClipboardSnackbar(CopiedToClipboardDataType.Password)
             is OfferUserUndoDeletion -> showUserCredentialDeletedWithUndoAction(command)
             is OfferUserUndoMassDeletion -> showUserCredentialsMassDeletedWithUndoAction(command)
-            is ShowListMode -> showListMode(legacyList = false)
-            is ShowListModeLegacy -> showListMode(legacyList = true)
+            is ShowListMode -> showListMode()
             is ShowDisabledMode -> showDisabledMode()
             is ShowDeviceUnsupportedMode -> showDeviceUnsupportedMode()
             is ShowLockedMode -> showLockMode()
@@ -250,19 +247,15 @@ class AutofillManagementActivity : DuckDuckGoActivity(), PasswordsScreenPromotio
         }.show()
     }
 
-    private fun showListMode(legacyList: Boolean) {
+    private fun showListMode() {
         resetToolbar()
         val currentUrl = extractSuggestionsUrl()
         val privacyProtectionStatus = extractPrivacyProtectionEnabled()
         val launchSource = extractLaunchSource()
-        logcat(VERBOSE) { "showListMode (isLegacy = $legacyList). currentUrl is $currentUrl" }
+        logcat(VERBOSE) { "showListMode. currentUrl is $currentUrl" }
 
         supportFragmentManager.commitNow {
-            val fragment = if (legacyList) {
-                AutofillManagementListModeLegacy.instance(currentUrl, privacyProtectionStatus, launchSource)
-            } else {
-                AutofillManagementListMode.instance(currentUrl, privacyProtectionStatus, launchSource)
-            }
+            val fragment = AutofillManagementListMode.instance(currentUrl, privacyProtectionStatus, launchSource)
             replace(R.id.fragment_container_view, fragment, TAG_ALL_CREDENTIALS)
         }
     }