Revert unnecesssary changes after refactor

Author: CrisBarreiro

app/src/main/java/com/duckduckgo/app/browser/BrowserWebViewClient.kt

@@ -482,14 +482,14 @@ class BrowserWebViewClient @Inject constructor(
 
         // See https://app.asana.com/0/0/1206159443951489/f (WebView limitations)
         if (webView.progress == 100) {
+            jsPlugins.getPlugins().forEach {
+                it.onPageFinished(
+                    webView,
+                    url,
+                    webViewClientListener?.getSite(),
+                )
+            }
             appCoroutineScope.launch {
-                jsPlugins.getPlugins().forEach {
-                    it.onPageFinished(
-                        webView,
-                        url,
-                        webViewClientListener?.getSite(),
-                    )
-                }
                 (webView as? DuckDuckGoWebView)?.let { duckDuckGoWebView ->
                     val activeExperiments = webViewClientListener?.getSite()?.activeContentScopeExperiments ?: listOf()
                     addDocumentStartJavascriptPlugins.getPlugins().forEach {

duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/ui/DuckChatWebViewClient.kt

@@ -20,16 +20,12 @@ import android.graphics.Bitmap
 import android.webkit.WebView
 import android.webkit.WebViewClient
 import androidx.annotation.UiThread
-import com.duckduckgo.app.di.AppCoroutineScope
 import com.duckduckgo.browser.api.JsInjectorPlugin
 import com.duckduckgo.common.utils.plugins.PluginPoint
 import javax.inject.Inject
-import kotlinx.coroutines.CoroutineScope
-import kotlinx.coroutines.launch
 
 class DuckChatWebViewClient @Inject constructor(
     private val jsPlugins: PluginPoint<JsInjectorPlugin>,
-    @AppCoroutineScope private val appCoroutineScope: CoroutineScope,
 ) : WebViewClient() {
 
     @UiThread
@@ -38,10 +34,8 @@ class DuckChatWebViewClient @Inject constructor(
         url: String?,
         favicon: Bitmap?,
     ) {
-        appCoroutineScope.launch {
-            jsPlugins.getPlugins().forEach {
-                it.onPageStarted(webView, url, null)
-            }
+        jsPlugins.getPlugins().forEach {
+            it.onPageStarted(webView, url, null)
         }
     }
 }

duckchat/duckchat-impl/src/test/kotlin/com/duckduckgo/duckchat/impl/ui/DuckChatWebViewClientTest.kt

@@ -18,27 +18,22 @@ package com.duckduckgo.duckchat.impl.ui
 
 import android.webkit.WebView
 import com.duckduckgo.browser.api.JsInjectorPlugin
-import com.duckduckgo.common.test.CoroutineTestRule
 import com.duckduckgo.common.utils.plugins.PluginPoint
 import kotlinx.coroutines.test.runTest
-import org.junit.Rule
 import org.junit.Test
 import org.mockito.kotlin.mock
 import org.mockito.kotlin.verify
 import org.mockito.kotlin.whenever
 
 class DuckChatWebViewClientTest {
 
-    @get:Rule
-    var coroutineRule = CoroutineTestRule()
-
     @Test
     fun whenOnPageStartedCalledThenJsPluginOnPageStartedInvoked() = runTest {
         val mockPlugin: JsInjectorPlugin = mock()
         val pluginPoint: PluginPoint<JsInjectorPlugin> = mock()
         whenever(pluginPoint.getPlugins()).thenReturn(listOf(mockPlugin))
 
-        val duckChatWebViewClient = DuckChatWebViewClient(pluginPoint, coroutineRule.testScope)
+        val duckChatWebViewClient = DuckChatWebViewClient(pluginPoint)
         val webView: WebView = mock()
         val url = "https://example.com"