Ship VPN exclude app prompt (#5028)

Task/Issue URL:
https://app.asana.com/0/1142021229838617/1208316612251365/f

### Description
Enable the exclude app prompt shown everytime the VPN is attempted to be
disabled by the user.

### Steps to test this PR
https://app.asana.com/0/1142021229838617/1208233455261636/f

Author: karlenDimla

network-protection/network-protection-impl/src/main/java/com/duckduckgo/networkprotection/impl/VpnRemoteFeatures.kt

@@ -26,7 +26,6 @@ import com.duckduckgo.di.scopes.AppScope
 import com.duckduckgo.feature.toggles.api.RemoteFeatureStoreNamed
 import com.duckduckgo.feature.toggles.api.Toggle
 import com.duckduckgo.feature.toggles.api.Toggle.DefaultValue
-import com.duckduckgo.feature.toggles.api.Toggle.InternalAlwaysEnabled
 import com.duckduckgo.feature.toggles.api.Toggle.State
 import com.squareup.anvil.annotations.ContributesBinding
 import com.squareup.moshi.JsonAdapter
@@ -46,8 +45,7 @@ interface VpnRemoteFeatures {
     @Toggle.DefaultValue(true)
     fun self(): Toggle
 
-    @DefaultValue(false)
-    @InternalAlwaysEnabled
+    @DefaultValue(true)
     fun showExcludeAppPrompt(): Toggle // kill switch
 }
 

network-protection/network-protection-impl/src/main/res/layout/dialog_vpn_disable.xml

@@ -42,24 +42,24 @@
         app:textType="secondary"
         app:typography="body1" />
 
+    <CheckBox
+        android:id="@+id/vpnDontShowAgainMessage"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_marginTop="@dimen/keyline_2"
+        android:checked="false"
+        android:orientation="horizontal"
+        android:text="@string/netpManagementExcludeAppPromptActionDisablePermanent"
+        app:layout_constraintTop_toBottomOf="@+id/vpnExcludeAppPromptMessage" />
+
     <LinearLayout
         android:id="@+id/vpnExcludeAppPromptDialogButtonLayout"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
-        android:layout_marginTop="@dimen/keyline_4"
         android:gravity="end"
         android:orientation="vertical"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
-        app:layout_constraintTop_toBottomOf="@+id/vpnExcludeAppPromptMessage" />
-
-    <CheckBox
-        android:id="@+id/vpnDontShowAgainMessage"
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:checked="false"
-        android:orientation="horizontal"
-        android:text="@string/netpManagementExcludeAppPromptActionDisablePermanent"
-        app:layout_constraintTop_toBottomOf="@+id/vpnExcludeAppPromptDialogButtonLayout" />
+        app:layout_constraintTop_toBottomOf="@+id/vpnDontShowAgainMessage" />
 
 </androidx.constraintlayout.widget.ConstraintLayout>

network-protection/network-protection-impl/src/main/res/values/donottranslate.xml

@@ -28,11 +28,11 @@
     <string name="netpManagementBetaDescription">DuckDuckGo VPN is currently in beta. <annotation type="report_issues_link">Share feedback</annotation> to help us improve!</string>
 
     <!-- Exclude App Prompt -->
-    <string name="netpManagementExcludeAppPromptTitle">App not working?</string>
-    <string name="netpManagementExcludeAppPromptSubtitle">If an app isn\'t working while the VPN is on, you can exclude that app from the VPN without turning the VPN off.</string>
+    <string name="netpManagementExcludeAppPromptTitle">Is the VPN causing problems with an app?</string>
+    <string name="netpManagementExcludeAppPromptSubtitle">You can exclude apps from the VPN without turning the VPN off.</string>
     <string name="netpManagementExcludeAppPromptActionDisableOne">Exclude an app</string>
     <string name="netpManagementExcludeAppPromptActionDisableAll">Turn off VPN</string>
-    <string name="netpManagementExcludeAppPromptActionDisablePermanent">Don\'t ask again</string>
+    <string name="netpManagementExcludeAppPromptActionDisablePermanent">Never ask again</string>
 
     <!-- Location -->
     <string name="netpManagementLocationHeaderVpnOff">Selected Location</string>

network-protection/network-protection-impl/src/test/java/com/duckduckgo/networkprotection/impl/management/NetworkProtectionManagementViewModelTest.kt

@@ -16,6 +16,7 @@
 
 package com.duckduckgo.networkprotection.impl.management
 
+import android.annotation.SuppressLint
 import android.content.Intent
 import androidx.lifecycle.LifecycleOwner
 import app.cash.turbine.test
@@ -195,8 +196,10 @@ class NetworkProtectionManagementViewModelTest {
         verify(networkProtectionState).start()
     }
 
+    @SuppressLint("DenyListedApi")
     @Test
     fun whenOnNetpToggleClickedToDisabledThenUnregisterFeature() = runTest {
+        vpnRemoteFeatures.showExcludeAppPrompt().setEnabled(Toggle.State(enable = false))
         testee.onNetpToggleClicked(false)
 
         verify(networkProtectionState).clearVPNConfigurationAndStop()
@@ -578,6 +581,7 @@ class NetworkProtectionManagementViewModelTest {
         }
     }
 
+    @SuppressLint("DenyListedApi")
     @Test
     fun whenExcludeAppPromptEnabledAndToggleTurnedOffThenShowPrompt() = runTest {
         vpnRemoteFeatures.showExcludeAppPrompt().setEnabled(Toggle.State(enable = true))
@@ -595,6 +599,7 @@ class NetworkProtectionManagementViewModelTest {
         }
     }
 
+    @SuppressLint("DenyListedApi")
     @Test
     fun whenPermanentDisableExcludeAppPromptThenDontShowPrompt() = runTest {
         vpnRemoteFeatures.showExcludeAppPrompt().setEnabled(Toggle.State(enable = true))