Skip to content

Commit a5f9e51

Browse files
authored
Add missing omnibarTextInputClickCatcher to "old" new_omnibars (#6401)
Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1210803032371220?focus=true ### Description Adds the missing `omnibarTextInputClickCatcher` to the old omnibars to stop the app crashing if the user is seeing these omnibar variants ### Steps to test this PR _Old top omnibar_ - [x] Ensure old top omnibar is visible (no hovering text input box, duck ai icon inside text input) You might need to delete `@Toggle.InternalAlwaysEnabled` from `singleOmnibarFeature` if testing on internalDebug - [x] App does not crash - [x] Search or enter a website - [x] Search or website loads _Old bottom omnibar_ - [x] Ensure old bottom omnibar is visible (no hovering text input box, duck ai icon inside text input) - [x] App does not crash - [x] Search or enter a website - [x] Search or website loads ### UI changes N/A
1 parent fec7475 commit a5f9e51

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

app/src/main/res/layout/view_new_omnibar.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,20 @@
209209
app:layout_constraintBottom_toBottomOf="parent"
210210
app:layout_constraintTop_toTopOf="parent" />
211211

212+
<View
213+
android:id="@+id/omnibarTextInputClickCatcher"
214+
android:layout_width="0dp"
215+
android:layout_height="0dp"
216+
android:background="@android:color/transparent"
217+
android:clickable="true"
218+
android:focusable="false"
219+
android:focusableInTouchMode="false"
220+
android:visibility="gone"
221+
app:layout_constraintBottom_toBottomOf="@id/omnibarTextInput"
222+
app:layout_constraintEnd_toEndOf="@id/omnibarTextInput"
223+
app:layout_constraintStart_toStartOf="@id/omnibarTextInput"
224+
app:layout_constraintTop_toTopOf="@id/omnibarTextInput" />
225+
212226
<com.duckduckgo.common.ui.view.text.DaxTextView
213227
android:id="@+id/trackersBlockedTextView"
214228
android:layout_width="0dp"

app/src/main/res/layout/view_new_omnibar_bottom.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,20 @@
210210
app:layout_constraintBottom_toBottomOf="parent"
211211
app:layout_constraintTop_toTopOf="parent" />
212212

213+
<View
214+
android:id="@+id/omnibarTextInputClickCatcher"
215+
android:layout_width="0dp"
216+
android:layout_height="0dp"
217+
android:background="@android:color/transparent"
218+
android:clickable="true"
219+
android:focusable="false"
220+
android:focusableInTouchMode="false"
221+
android:visibility="gone"
222+
app:layout_constraintBottom_toBottomOf="@id/omnibarTextInput"
223+
app:layout_constraintEnd_toEndOf="@id/omnibarTextInput"
224+
app:layout_constraintStart_toStartOf="@id/omnibarTextInput"
225+
app:layout_constraintTop_toTopOf="@id/omnibarTextInput" />
226+
213227
<com.duckduckgo.common.ui.view.text.DaxTextView
214228
android:id="@+id/trackersBlockedTextView"
215229
android:layout_width="0dp"

0 commit comments

Comments
 (0)