Keep fallback for subscription events

Author: CrisBarreiro

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

@@ -1214,27 +1214,33 @@ class BrowserTabFragment :
     private fun onOmnibarCustomTabPrivacyDashboardPressed() {
         val params = PrivacyDashboardPrimaryScreen(tabId)
         val intent = globalActivityStarter.startIntent(requireContext(), params)
-        adsJsContentScopeScripts.postMessage(createBreakageReportingEventData())
-        // contentScopeScripts.sendSubscriptionEvent(createBreakageReportingEventData())
+        postBreakageReportingEvent()
         intent?.let { activityResultPrivacyDashboard.launch(intent) }
         pixel.fire(CustomTabPixelNames.CUSTOM_TABS_PRIVACY_DASHBOARD_OPENED)
     }
 
+    private fun postBreakageReportingEvent() {
+        appCoroutineScope.launch {
+            val eventData = createBreakageReportingEventData()
+            if (!adsJsContentScopeScripts.postMessage(eventData)) {
+                contentScopeScripts.sendSubscriptionEvent(eventData)
+            }
+        }
+    }
+
     private fun onFireButtonPressed() {
         val isFocusedNtp = omnibar.viewMode == ViewMode.NewTab && omnibar.getText().isEmpty() && omnibar.omnibarTextInput.hasFocus()
         browserActivity?.launchFire(launchedFromFocusedNtp = isFocusedNtp)
         viewModel.onFireMenuSelected()
     }
 
     private fun onBrowserMenuButtonPressed() {
-        adsJsContentScopeScripts.postMessage(createBreakageReportingEventData())
-        // contentScopeScripts.sendSubscriptionEvent(createBreakageReportingEventData())
+        postBreakageReportingEvent()
         viewModel.onBrowserMenuClicked(isCustomTab = isActiveCustomTab())
     }
 
     private fun onOmnibarPrivacyShieldButtonPressed() {
-        adsJsContentScopeScripts.postMessage(createBreakageReportingEventData())
-        // contentScopeScripts.sendSubscriptionEvent(createBreakageReportingEventData())
+        postBreakageReportingEvent()
         viewModel.onOmnibarPrivacyShieldButtonPressed()
         launchPrivacyDashboard(toggle = false)
     }

app/src/main/java/com/duckduckgo/app/browser/RealDuckDuckGoWebView.kt

@@ -487,10 +487,13 @@ class RealDuckDuckGoWebView : DuckDuckGoWebView, NestedScrollingChild3 {
     override suspend fun safePostMessage(
         replyProxy: JavaScriptReplyProxy,
         response: String,
-    ) {
-        runCatching {
-            if (webViewCapabilityChecker.isSupported(WebViewCapability.WebMessageListener)) {
+    ): Boolean {
+        return runCatching {
+            return if (webViewCapabilityChecker.isSupported(WebViewCapability.WebMessageListener)) {
                 replyProxy.postMessage(response)
+                true
+            } else {
+                false
             }
         }.getOrElse { exception ->
             logcat(ERROR) { "Error posting message: ${exception.asLog()}" }

browser-api/src/main/java/com/duckduckgo/app/browser/api/DuckDuckGoWebView.kt

@@ -58,8 +58,15 @@ abstract class DuckDuckGoWebView(
 
     abstract fun isDestroyed(): Boolean
 
+    /**
+     * Sends a message to the specified JavaScriptReplyProxy.
+     *
+     * @param replyProxy The proxy to send the message to.
+     * @param response The message content to send.
+     * @return `true` if the message was sent successfully, `false` otherwise.
+     */
     abstract suspend fun safePostMessage(
         replyProxy: JavaScriptReplyProxy,
         response: String,
-    )
+    ): Boolean
 }

content-scope-scripts/content-scope-scripts-impl/src/main/java/com/duckduckgo/contentscopescripts/impl/messaging/AdsjsContentScopeMessaging.kt

@@ -168,8 +168,8 @@ class AdsjsContentScopeMessaging @Inject constructor(
         }
     }
 
-    override fun postMessage(subscriptionEventData: SubscriptionEventData) {
-        runCatching {
+    override suspend fun postMessage(subscriptionEventData: SubscriptionEventData): Boolean {
+        return runCatching {
             val subscriptionEvent = SubscriptionEvent(
                 context = context,
                 featureName = subscriptionEventData.featureName,
@@ -179,14 +179,16 @@ class AdsjsContentScopeMessaging @Inject constructor(
                 moshi.adapter(SubscriptionEvent::class.java).toJson(it)
             }
 
-            appCoroutineScope.launch(dispatcherProvider.main()) {
+            withContext(dispatcherProvider.main()) {
                 globalReplyProxy?.let {
                     (webView as? DuckDuckGoWebView)?.safePostMessage(
                         it,
                         subscriptionEvent,
                     )
-                }
+                } ?: false
             }
+        }.getOrElse {
+            false
         }
     }
 }

js-messaging/js-messaging-api/src/main/java/com/duckduckgo/js/messaging/api/AdsjsMessaging.kt

@@ -30,7 +30,12 @@ interface AdsjsMessaging {
     )
     suspend fun unregister(webView: WebView)
 
-    fun postMessage(subscriptionEventData: SubscriptionEventData)
+    /**
+     * Sends a message to the JS layer.
+     * @param subscriptionEventData Data to be sent.
+     * @return true if the message was sent successfully, false otherwise.
+     */
+    suspend fun postMessage(subscriptionEventData: SubscriptionEventData): Boolean
 
     /**
      * Context name