Skip to content

Commit a9ee7c6

Browse files
authored
Use translated string for edit text (#6797)
Task/Issue URL: https://app.asana.com/1/137249556945/project/414730916066338/task/1211322673312843?focus=true ### Description Previously, we are using newTabPageMenuEdit which is in donottranslate.xml. I don't think we should use a non translated screen here if everything else on the page is translated. ### Steps to test this PR - [ ] Change language to any aside from English - [ ] Open Bookmarks and press the context menu - [ ] Verify that all strings in the menu are translated ### UI changes | Before | After | | ------ | ----- | |(<img width="349" height="132" alt="Screenshot 2025-09-15 at 10 57 36" src="https://github.com/user-attachments/assets/2b046a0b-d33d-446d-a508-d3afb2521fcd" />)|(<img width="360" height="173" alt="Screenshot 2025-09-15 at 10 57 43" src="https://github.com/user-attachments/assets/01a00aea-1a77-4816-a045-1f51f6b1f38c" />)|
1 parent 2246760 commit a9ee7c6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

saved-sites/saved-sites-impl/src/main/res/menu/bookmark_popup_menu.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<menu xmlns:android="http://schemas.android.com/apk/res/android">
1818
<item
1919
android:id="@+id/bookmark_edit"
20-
android:title="@string/newTabPageMenuEdit" />
20+
android:title="@string/savedSiteDialogTitleEdit" />
2121
<item
2222
android:id="@+id/bookmark_add_to_favorites"
2323
android:title="@string/addToFavorites" />

0 commit comments

Comments
 (0)