Skip to content

Commit afe434a

Browse files
authored
deactivate serp experiments (#790)
* deactivate serp experiments * better test naming that is future proof * fix merge issue
1 parent 8ba6e4b commit afe434a

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,16 @@ class VariantManagerTest {
3030
// SERP Experiment(s)
3131

3232
@Test
33-
fun serpControlVariantIsInactiveAndHasNoFeatures() {
33+
fun serpControlVariantHasExpectedWeightAndNoFeatures() {
3434
val variant = variants.first { it.key == "sc" }
35-
assertEqualsDouble(1.0, variant.weight)
35+
assertEqualsDouble(0.0, variant.weight)
3636
assertEquals(0, variant.features.size)
3737
}
3838

3939
@Test
40-
fun serpExperimentalVariantIsInactiveAndHasNoFeatures() {
40+
fun serpExperimentalVariantHasExpectedWeightAndNoFeatures() {
4141
val variant = variants.first { it.key == "se" }
42-
assertEqualsDouble(1.0, variant.weight)
42+
assertEqualsDouble(0.0, variant.weight)
4343
assertEquals(0, variant.features.size)
4444
}
4545

app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ interface VariantManager {
4040
val ACTIVE_VARIANTS = listOf(
4141
// SERP variants. "sc" may also be used as a shared control for mobile experiments in
4242
// the future if we can filter by app version
43-
Variant(key = "sc", weight = 1.0, features = emptyList(), filterBy = { noFilter() }),
44-
Variant(key = "se", weight = 1.0, features = emptyList(), filterBy = { noFilter() })
43+
Variant(key = "sc", weight = 0.0, features = emptyList(), filterBy = { noFilter() }),
44+
Variant(key = "se", weight = 0.0, features = emptyList(), filterBy = { noFilter() })
4545

4646
// All groups in an experiment (control and variants) MUST use the same filters
4747
)

0 commit comments

Comments
 (0)