Attempt to fix animations running between dialog closing and new dialog opening

It would result in some parts of the content e.g. the primary CTA button being visible when the dialog was opened and used for a new CTA type.

Author: mikescamell

app/src/main/java/com/duckduckgo/app/cta/ui/Cta.kt

@@ -1144,6 +1144,8 @@ sealed class DaxBubbleCta(
 ) : Cta, ViewCta, DaxCta {
 
     var isModifiedControlOnboardingExperimentEnabled: Boolean? = null
+    private var buckAnimators: List<ViewPropertyAnimator> = emptyList()
+    private var bbAnimators: List<ViewPropertyAnimator> = emptyList()
 
     protected var ctaView: View? = null
 
@@ -1326,13 +1328,13 @@ sealed class DaxBubbleCta(
             val afterAnimation = {
                 daxBubbleDialogTitle.finishAnimation()
                 dialogTextCta.finishAnimation()
-                placeholder?.let { placeholderImageView.fadeIn() }
-                primaryCta.fadeIn()
-                secondaryCta.fadeIn()
+                placeholder?.let { bbAnimators += placeholderImageView.fadeIn() }
+                bbAnimators += primaryCta.fadeIn()
+                bbAnimators += secondaryCta.fadeIn()
                 options?.let {
                     optionsViews.forEachIndexed { index, buttonView ->
                         if (it.size > index) {
-                            buttonView.fadeIn()
+                            bbAnimators += buttonView.fadeIn()
                         }
                     }
                 }
@@ -1357,9 +1359,9 @@ sealed class DaxBubbleCta(
                 }
             }
 
-            root.fadeIn().setStartDelay(500).withEndAction {
+            bbAnimators += root.fadeIn().setStartDelay(500).withEndAction {
                 if (configuration is DaxEndCta) {
-                    headerImage.fadeIn().withEndAction {
+                    bbAnimators += headerImage.fadeIn().withEndAction {
                         runTypingAnimations()
                     }
                 } else {
@@ -1455,13 +1457,13 @@ sealed class DaxBubbleCta(
 
             val afterAnimation = {
                 dialogTextCta.finishAnimation()
-                placeholder?.let { placeholderImageView.fadeIn() }
-                primaryCta.fadeIn()
-                secondaryCta.fadeIn()
+                placeholder?.let { buckAnimators += placeholderImageView.fadeIn() }
+                buckAnimators += primaryCta.fadeIn()
+                buckAnimators += secondaryCta.fadeIn()
                 options?.let {
                     optionsViews.forEachIndexed { index, buttonView ->
                         if (it.size > index) {
-                            buttonView.fadeIn()
+                            buckAnimators += buttonView.fadeIn()
                         }
                     }
                 }
@@ -1472,8 +1474,8 @@ sealed class DaxBubbleCta(
             with(buckOnboardingDialogView) {
                 animateEntrance(
                     onAnimationEnd = {
-                        daxDialogDismissButton.fadeIn()
-                        daxBubbleDialogTitle.fadeIn()
+                        buckAnimators += daxDialogDismissButton.fadeIn()
+                        buckAnimators += daxBubbleDialogTitle.fadeIn()
                             .withEndAction {
                                 dialogTextCta.startTypingAnimation(daxText, true) {
                                     afterAnimation()
@@ -1508,17 +1510,33 @@ sealed class DaxBubbleCta(
 
     private fun clearBubbleBuckDialog(binding: IncludeOnboardingBubbleBuckDialogBinding) {
         binding.apply {
+            buckAnimators.forEach { it.cancel() }
+            buckAnimators = emptyList()
+            daxBubbleDialogTitle.text = ""
+            dialogTextCta.cancelAnimation()
+            dialogTextCta.text = ""
             this.daxDialogDismissButton.alpha = 0f
             this.primaryCta.gone()
+            this.primaryCta.alpha = 0f
             this.secondaryCta.gone()
+            this.secondaryCta.alpha = 0f
+            this.daxDialogOption1.alpha = 0f
             this.daxDialogOption1.gone()
+            this.daxDialogOption2.alpha = 0f
             this.daxDialogOption2.gone()
+            this.daxDialogOption3.alpha = 0f
             this.daxDialogOption3.gone()
         }
     }
 
     private fun clearBubbleBBDialog(binding: IncludeOnboardingBubbleBbDialogBinding) {
         binding.apply {
+            bbAnimators.forEach { it.cancel() }
+            bbAnimators = emptyList()
+            daxBubbleDialogTitle.cancelAnimation()
+            daxBubbleDialogTitle.text = ""
+            dialogTextCta.cancelAnimation()
+            dialogTextCta.text = ""
             primaryCta.alpha = 0f
             primaryCta.gone()
             secondaryCta.alpha = 0f