Skip to content

Commit b264e84

Browse files
authored
Feature/cristian/enable se sc variants (#746)
* Enabling search variants * Finish LaunchBridgeActivity after routing to OnboardingActivity
1 parent 5237329 commit b264e84

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ class VariantManagerTest {
3232
@Test
3333
fun serpControlVariantIsInactiveAndHasNoFeatures() {
3434
val variant = variants.first { it.key == "sc" }
35-
assertEqualsDouble(0.0, variant.weight)
35+
assertEqualsDouble(1.0, variant.weight)
3636
assertEquals(0, variant.features.size)
3737
}
3838

3939
@Test
4040
fun serpExperimentalVariantIsInactiveAndHasNoFeatures() {
4141
val variant = variants.first { it.key == "se" }
42-
assertEqualsDouble(0.0, variant.weight)
42+
assertEqualsDouble(1.0, variant.weight)
4343
assertEquals(0, variant.features.size)
4444
}
4545

app/src/main/java/com/duckduckgo/app/launch/LaunchBridgeActivity.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ class LaunchBridgeActivity : DuckDuckGoActivity() {
6767
} else {
6868
startActivity(OnboardingActivity.intent(this))
6969
}
70+
finish()
7071
}
7172

7273
private fun showHome() {

app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ interface VariantManager {
4848
val ACTIVE_VARIANTS = listOf(
4949
// SERP variants. "sc" may also be used as a shared control for mobile experiments in
5050
// the future if we can filter by app version
51-
Variant(key = "sc", weight = 0.0, features = emptyList(), filterBy = { noFilter() }),
52-
Variant(key = "se", weight = 0.0, features = emptyList(), filterBy = { noFilter() }),
51+
Variant(key = "sc", weight = 1.0, features = emptyList(), filterBy = { noFilter() }),
52+
Variant(key = "se", weight = 1.0, features = emptyList(), filterBy = { noFilter() }),
5353

5454
// Concept test experiment
5555
Variant(key = "mc", weight = 0.0, features = emptyList(), filterBy = { isEnglishLocale() }),

0 commit comments

Comments
 (0)