Skip to content

Commit b8e0f50

Browse files
committed
Fix test
1 parent e4c0262 commit b8e0f50

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

app/src/androidTest/java/com/duckduckgo/app/browser/BrowserWebViewClientTest.kt

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ import com.duckduckgo.common.test.CoroutineTestRule
7272
import com.duckduckgo.common.utils.CurrentTimeProvider
7373
import com.duckduckgo.common.utils.device.DeviceInfo
7474
import com.duckduckgo.common.utils.plugins.PluginPoint
75-
import com.duckduckgo.contentscopescripts.api.contentscopeExperiments.ContentScopeExperiments
7675
import com.duckduckgo.cookies.api.CookieManagerProvider
7776
import com.duckduckgo.duckchat.api.DuckChat
7877
import com.duckduckgo.duckplayer.api.DuckPlayer
@@ -111,6 +110,8 @@ import org.mockito.kotlin.verify
111110
import org.mockito.kotlin.verifyNoInteractions
112111
import org.mockito.kotlin.whenever
113112

113+
private val mockToggle: Toggle = mock()
114+
114115
class BrowserWebViewClientTest {
115116

116117
@get:Rule
@@ -165,15 +166,12 @@ class BrowserWebViewClientTest {
165166
mock(),
166167
)
167168
private val mockDuckChat: DuckChat = mock()
168-
private val mockContentScopeExperiments: ContentScopeExperiments = mock()
169169

170170
@UiThreadTest
171171
@Before
172172
fun setup() = runTest {
173173
webView = TestWebView(context)
174174
whenever(mockDuckPlayer.observeShouldOpenInNewTab()).thenReturn(openInNewTabFlow)
175-
val toggle: Toggle = mock()
176-
whenever(mockContentScopeExperiments.getActiveExperiments()).thenReturn(listOf(toggle))
177175
testee = BrowserWebViewClient(
178176
webViewHttpAuthStore,
179177
trustedCertificateStore,
@@ -206,7 +204,6 @@ class BrowserWebViewClientTest {
206204
mockUriLoadedManager,
207205
mockAndroidFeaturesHeaderPlugin,
208206
mockDuckChat,
209-
mockContentScopeExperiments,
210207
)
211208
testee.webViewClientListener = listener
212209
whenever(webResourceRequest.url).thenReturn(Uri.EMPTY)
@@ -226,11 +223,8 @@ class BrowserWebViewClientTest {
226223
@UiThreadTest
227224
@Test
228225
fun whenOnPageStartedCalledThenListenerNotified() = runTest {
229-
val toggle: Toggle = mock()
230-
whenever(mockContentScopeExperiments.getActiveExperiments()).thenReturn(listOf(toggle))
231-
232226
testee.onPageStarted(webView, EXAMPLE_URL, null)
233-
verify(listener).pageStarted(any(), eq(listOf(toggle)))
227+
verify(listener).pageStarted(any(), eq(listOf(mockToggle)))
234228
}
235229

236230
@UiThreadTest
@@ -1195,23 +1189,21 @@ class BrowserWebViewClientTest {
11951189

11961190
override fun onInit(
11971191
webView: WebView,
1198-
activeExperiments: List<Toggle>,
11991192
) {
12001193
}
12011194

12021195
override fun onPageStarted(
12031196
webView: WebView,
12041197
url: String?,
12051198
isDesktopMode: Boolean?,
1206-
activeExperiments: List<Toggle>,
1207-
) {
1199+
): List<Toggle> {
12081200
countStarted++
1201+
return listOf(mockToggle)
12091202
}
12101203

12111204
override fun onPageFinished(
12121205
webView: WebView,
12131206
url: String?,
1214-
activeExperiments: List<Toggle>,
12151207
) {
12161208
countFinished++
12171209
}

0 commit comments

Comments
 (0)