Fix rx network error crash

• Use mergeDelayError to keep completable alive until all requests are done
• Remove ott stack traces from ordinary event logging e.g network request failing
• Set job property that was never set

Author: subsymbolic

app/src/main/java/com/duckduckgo/app/global/DuckDuckGoApplication.kt

@@ -116,7 +116,7 @@ class DuckDuckGoApplication : HasActivityInjector, HasServiceInjector, Applicati
                 .doAfterTerminate({
                     appConfigurationSyncer.scheduleRegularSync(this)
                 })
-                .subscribe({}, { Timber.w(it, "Failed to download initial app configuration") })
+                .subscribe({}, { Timber.w("Failed to download initial app configuration ${it.localizedMessage}") })
     }
 
     override fun activityInjector(): AndroidInjector<Activity> = activityInjector

app/src/main/java/com/duckduckgo/app/job/AppConfigurationDownloader.kt

@@ -38,7 +38,7 @@ class AppConfigurationDownloader @Inject constructor(
         val disconnectDownload = trackerDataDownloader.downloadList(Client.ClientName.DISCONNECT)
         val httpsUpgradeDownload = httpsUpgradeListDownloader.downloadList()
 
-        return Completable.merge(listOf(
+        return Completable.mergeDelayError(listOf(
                 easyListDownload.subscribeOn(Schedulers.io()),
                 easyPrivacyDownload.subscribeOn(Schedulers.io()),
                 trackersWhitelist.subscribeOn(Schedulers.io()),

app/src/main/java/com/duckduckgo/app/job/AppConfigurationJobService.kt

@@ -40,13 +40,13 @@ class AppConfigurationJobService : JobService() {
     override fun onStartJob(params: JobParameters?): Boolean {
         Timber.i("onStartJob")
 
-        appConfigurationDownloader.downloadTask()
+        downloadTask= appConfigurationDownloader.downloadTask()
             .subscribeOn(Schedulers.io())
             .subscribe({
                 Timber.i("Successfully downloaded all data")
                 jobFinishedSuccessfully(params)
             }, {
-                Timber.w(it, "Failed to download app configuration")
+                Timber.w("Failed to download app configuration ${it.localizedMessage}")
                 jobFinishedFailed(params)
             })