Skip to content

Commit bf1a5d2

Browse files
authored
Expose upgrade and purchase screens to in-app deeplink (#7795)
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1213400521825647?focus=true ### Description Adds entry point to purchase and upgrade screen through in-app navigation (deeplink). Plan is to use them from RMF promo ### Steps to test this PR _Feature 1_ - [ ] This can be tested by using `https://api.jsonblob.com/019c8a43-d692-7e2c-86c4-a5439d27ffdf` ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)| <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Annotation-only change that affects navigation/deeplink registration for purchase/upgrade screens; risk is limited to potential misrouting if the `screenName` values are incorrect. > > **Overview** > **Expose purchase/upgrade screens to in-app navigation** by updating `SubscriptionsWebViewActivity`’s `@ContributeToActivityStarter` entries for `SubscriptionPurchase` and `SubscriptionUpgrade` to include explicit `screenName`s (`subscriptions.purchase` / `subscriptions.upgrade`). > > This makes these flows addressable via the app’s screen-name based routing/deeplink mechanism without changing the underlying webview behavior. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4184d8f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent e4dc045 commit bf1a5d2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

subscriptions/subscriptions-impl/src/main/java/com/duckduckgo/subscriptions/impl/ui/SubscriptionsWebViewActivity.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ data class SubscriptionsWebViewActivityWithParams(
134134
scope = ActivityScope::class,
135135
delayGeneration = true, // Delayed because it has a dependency on DownloadConfirmationFragment from another module
136136
)
137-
@ContributeToActivityStarter(SubscriptionPurchase::class)
138-
@ContributeToActivityStarter(SubscriptionUpgrade::class)
137+
@ContributeToActivityStarter(SubscriptionPurchase::class, screenName = "subscriptions.purchase")
138+
@ContributeToActivityStarter(SubscriptionUpgrade::class, screenName = "subscriptions.upgrade")
139139
@ContributeToActivityStarter(SubscriptionsWebViewActivityWithParams::class)
140140
class SubscriptionsWebViewActivity : DuckDuckGoActivity(), DownloadConfirmationDialogListener {
141141

0 commit comments

Comments
 (0)