Skip to content

Commit cb7bba0

Browse files
authored
Visual Designs: Review II (#6047)
Task/Issue URL: https://app.asana.com/1/137249556945/project/1174433894299346/task/1210223529532768?focus=true ### Description This PR adds the latest changes asked in the design review
1 parent 8834fc2 commit cb7bba0

File tree

5 files changed

+9
-4
lines changed

5 files changed

+9
-4
lines changed

common/common-ui/src/main/res/drawable/ic_arrow_left_24.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
android:viewportWidth="24"
55
android:viewportHeight="24">
66
<path
7-
android:pathData="M12.207,4.707a1,1 0,0 0,-1.414 -1.414l-8,8a1,1 0,0 0,0 1.414l8,8a1,1 0,0 0,1.414 -1.414L5.914,13H20.5a1,1 0,1 0,0 -2H5.914z"
8-
android:fillColor="@color/primary_icon_color_selector"/>
7+
android:pathData="M10.805,4.031a0.75,0.75 0,0 0,-1.06 -1.06l-7.014,7.01a2.5,2.5 0,0 0,0 3.536l7.013,7.012a0.75,0.75 0,1 0,1.06 -1.06L3.837,12.5h17.415a0.75,0.75 0,0 0,0 -1.5H3.836l6.969,-6.969Z"
8+
android:fillColor="?attr/daxColorPrimaryIcon"/>
99
</vector>

common/common-ui/src/main/res/drawable/ic_arrow_right_24.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
android:viewportWidth="24"
55
android:viewportHeight="24">
66
<path
7-
android:pathData="M11.793,4.707a1,1 0,0 1,1.414 -1.414l8,8a1,1 0,0 1,0 1.414l-8,8a1,1 0,0 1,-1.414 -1.414L18.086,13H3.5a1,1 0,1 1,0 -2h14.586z"
8-
android:fillColor="@color/primary_icon_color_selector"/>
7+
android:pathData="M13.196,4.031a0.75,0.75 0,0 1,1.06 -1.06l7.012,7.011a2.5,2.5 0,0 1,0 3.536l-7.012,7.012a0.75,0.75 0,0 1,-1.06 -1.06l6.969,-6.97H2.75a0.75,0.75 0,0 1,0 -1.5h17.415l-6.97,-6.969Z"
8+
android:fillColor="?attr/daxColorPrimaryIcon"/>
99
</vector>

common/common-ui/src/main/res/drawable/text_cursor.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,5 @@
1818
android:shape="rectangle">
1919
<size android:width="2dp" />
2020
<solid android:color="?attr/daxColorAccentBlue" />
21+
<corners android:radius="1dp" />
2122
</shape>

common/common-ui/src/main/res/layout/view_dax_text_input.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
android:layout_width="match_parent"
3636
android:layout_height="wrap_content"
3737
android:gravity="top"
38+
android:textCursorDrawable="@drawable/text_cursor"
3839
android:textColor="?attr/daxColorPrimaryText" />
3940

4041
</com.google.android.material.textfield.TextInputLayout>

common/common-ui/src/main/res/values/widgets.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -394,6 +394,9 @@
394394
<!-- The color of the cursor comes from the theme, not the widget itself -->
395395
<style name="Widget.DuckDuckGo.TextInputCursor">
396396
<item name="android:colorControlActivated">?attr/daxColorAccentBlue</item>
397+
<item name="colorControlActivated">?attr/daxColorAccentBlue</item>
398+
<item name="android:colorPrimary">?attr/daxColorAccentBlue</item>
399+
<item name="colorPrimary">?attr/daxColorAccentBlue</item>
397400
</style>
398401

399402
<style name="Widget.DuckDuckGo.RoundedDialog" parent="@style/ThemeOverlay.MaterialComponents.MaterialAlertDialog">

0 commit comments

Comments
 (0)