Visual design: Autocomplete (#6082)

Task/Issue URL:
https://app.asana.com/1/137249556945/project/1204284606155124/task/1210251609451243?focus=true

### Description
Remove extra padding for items, so that the touch listener can also look
nicer

Author: malmstein

app/src/main/res/layout/item_autocomplete_bookmark_suggestion.xml

@@ -20,10 +20,8 @@
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     xmlns:app="http://schemas.android.com/apk/res-auto"
-    android:layout_marginBottom="8dp"
-    android:layout_marginTop="6dp"
     android:background="?attr/selectableItemBackground"
-    android:paddingVertical="@dimen/keyline_2"
+    android:paddingVertical="?attr/autocompleteListItemVerticalPadding"
     android:paddingStart="?attr/autocompleteListItemStartPadding"
     android:paddingEnd="?attr/autocompleteListItemWithoutTrailIconEndPadding">
 

app/src/main/res/layout/item_autocomplete_default.xml

@@ -20,8 +20,6 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:layout_marginBottom="8dp"
-    android:layout_marginTop="6dp"
     android:background="?attr/selectableItemBackground"
     android:paddingVertical="@dimen/keyline_2"
     android:paddingStart="?attr/autocompleteListItemStartPadding"

app/src/main/res/layout/item_autocomplete_history_search_suggestion.xml

@@ -19,10 +19,8 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:layout_marginTop="6dp"
-    android:layout_marginBottom="8dp"
     android:background="?attr/selectableItemBackground"
-    android:paddingVertical="@dimen/keyline_2"
+    android:paddingVertical="?attr/autocompleteListItemVerticalPadding"
     android:paddingStart="?attr/autocompleteListItemStartPadding"
     android:paddingEnd="?attr/autocompleteListItemWithoutTrailIconEndPadding">
 

app/src/main/res/layout/item_autocomplete_history_suggestion.xml

@@ -20,10 +20,8 @@
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     xmlns:app="http://schemas.android.com/apk/res-auto"
-    android:layout_marginBottom="8dp"
-    android:layout_marginTop="6dp"
     android:background="?attr/selectableItemBackground"
-    android:paddingVertical="@dimen/keyline_2"
+    android:paddingVertical="?attr/autocompleteListItemVerticalPadding"
     android:paddingStart="?attr/autocompleteListItemStartPadding"
     android:paddingEnd="?attr/autocompleteListItemWithoutTrailIconEndPadding">
 

app/src/main/res/layout/item_autocomplete_search_suggestion.xml

@@ -20,10 +20,8 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:layout_marginBottom="8dp"
-    android:layout_marginTop="6dp"
     android:background="?attr/selectableItemBackground"
-    android:paddingVertical="@dimen/keyline_2"
+    android:paddingVertical="?attr/autocompleteListItemVerticalPadding"
     android:paddingStart="?attr/autocompleteListItemStartPadding"
     android:paddingEnd="?attr/autocompleteListItemEndPadding">
 

app/src/main/res/layout/item_autocomplete_switch_to_tab_suggestion.xml

@@ -19,12 +19,10 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:layout_marginTop="6dp"
-    android:layout_marginBottom="8dp"
+    android:paddingVertical="?attr/autocompleteListItemVerticalPadding"
     android:background="?attr/selectableItemBackground"
     android:paddingStart="?attr/autocompleteListItemStartPadding"
-    android:paddingEnd="?attr/autocompleteListItemWithoutTrailIconEndPadding"
-    android:paddingVertical="@dimen/keyline_2">
+    android:paddingEnd="?attr/autocompleteListItemWithoutTrailIconEndPadding">
 
     <ImageView
         android:id="@+id/switchToTabIndicator"

common/common-ui/src/main/res/values/design-system-attrs.xml

@@ -24,6 +24,7 @@
     <attr name="autocompleteListItemEndPadding" format="dimension"/>
     <attr name="autocompleteListItemIconMargin" format="dimension"/>
     <attr name="autocompleteListItemWithoutTrailIconEndPadding" format="dimension"/>
+    <attr name="autocompleteListItemVerticalPadding" format="dimension"/>
 
     <attr name="cookiesAnimationRadius" format="dimension"/>
     <attr name="cookiesAnimationHeight" format="dimension"/>

common/common-ui/src/main/res/values/design-system-theming.xml

@@ -138,6 +138,7 @@
         <item name="autocompleteListItemEndPadding">@dimen/keyline_2</item>
         <item name="autocompleteListItemIconMargin">10dp</item>
         <item name="autocompleteListItemWithoutTrailIconEndPadding">@dimen/keyline_4</item>
+        <item name="autocompleteListItemVerticalPadding">14dp</item>
 
         <item name="cookiesAnimationRadius">@dimen/smallShapeCornerRadius</item>
         <item name="cookiesAnimationHeight">@dimen/omnibarCookieAnimationBannerHeight</item>