Skip to content

Commit cc92e8a

Browse files
committed
Merge branch 'release/5.70.0' into main
2 parents 2db6f0e + d31e640 commit cc92e8a

File tree

98 files changed

+2843
-447
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

98 files changed

+2843
-447
lines changed

CONTRIBUTING.md

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,20 @@ If you have a great idea you really want to implement, start by logging an issue
3333

3434
We care about clean code. Refer to our [style guide](styleguide/STYLEGUIDE.md).
3535

36-
3736
### Commit Messages
3837

38+
See Chris Beams' guide to writing good commit messages https://chris.beams.io/posts/git-commit/
39+
40+
### Why is a build failing?
41+
42+
Bitrise as a our CI environment, [all builds can be seen here](https://app.bitrise.io/app/dc22e377b9a9ccbf#/builds).
43+
We use [Spotless](https://github.com/diffplug/spotless) as a code formatter, and every build in Bitrise will trigger a check for several rules.
44+
If your PR is failing because of that, please make sure that you have our [style guide](styleguide/STYLEGUIDE.md) imported and the code formatted.
45+
You can also trigger an automatic code formatting of the code by executing:
46+
47+
```
48+
./gradleW app:spotlessApply
49+
```
50+
51+
3952
See Chris Beams' guide to writing good commit messages https://chris.beams.io/posts/git-commit/

app/build.gradle

Lines changed: 14 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ apply plugin: 'kotlin-android'
44
apply plugin: 'kotlin-android-extensions'
55
apply plugin: 'kotlin-kapt'
66
apply from: '../versioning.gradle'
7-
apply from: "$rootDir/ktlint.gradle"
7+
apply from: "$rootDir/spotless.gradle"
88

99
ext {
1010
USE_ORCHESTRATOR = project.hasProperty('orchestrator') ? project.property('orchestrator') : false
@@ -96,23 +96,23 @@ android {
9696
}
9797

9898
ext {
99-
androidX = "1.2.0-beta01"
100-
materialDesign = "1.2.0-alpha05"
101-
swipeRefreshLayout = "1.0.0"
99+
androidX = "1.2.0"
100+
materialDesign = "1.2.1"
101+
swipeRefreshLayout = "1.1.0"
102102
architectureComponents = "1.1.1"
103103
architectureComponentsExtensions = "1.1.1"
104-
androidKtxCore = "1.2.0"
105-
fragmentKtx = "1.2.3"
106-
constraintLayout = "2.0.0-beta4"
104+
androidKtxCore = "1.3.2"
105+
fragmentKtx = "1.2.5"
106+
constraintLayout = "2.0.4"
107107
lifecycle = "2.2.0"
108108
room = "2.2.5"
109-
workManager = "2.3.4"
109+
workManager = "2.4.0"
110110
legacySupport = "1.0.0"
111111
coreTesting = "2.1.0"
112-
testRunner = "1.2.0"
112+
testRunner = "1.3.0"
113113
coroutines = "1.3.5"
114114
retrofitCoroutinesAdapter = "0.9.2"
115-
webkit = "1.2.0"
115+
webkit = "1.3.0"
116116
referrerLibrary = "1.1.2"
117117

118118
junit = "4.12"
@@ -126,9 +126,9 @@ ext {
126126
rxAndroid = "2.0.2"
127127
timber = "4.7.1"
128128
rxRelay = "2.0.0"
129-
leakCanary = "2.0"
130-
mockito = "2.18.3"
131-
mockitoKotlin = "2.0.0"
129+
leakCanary = "2.5"
130+
mockito = "3.4.6"
131+
mockitoKotlin = "2.2.0"
132132
commonsMath = "3.6.1"
133133
}
134134

@@ -213,18 +213,11 @@ dependencies {
213213
implementation("com.android.installreferrer:installreferrer:$referrerLibrary")
214214

215215
// Testing dependencies
216-
testImplementation "org.mockito:mockito-core:$mockito"
217-
testImplementation "com.nhaarman.mockitokotlin2:mockito-kotlin:$mockitoKotlin"
218-
testImplementation "junit:junit:$junit"
219-
220216
androidTestImplementation "androidx.test:runner:$testRunner"
221217
androidTestImplementation "androidx.test:rules:$testRunner"
222218
androidTestUtil "androidx.test:orchestrator:$testRunner"
223219
androidTestImplementation "org.mockito:mockito-android:$mockito"
224-
androidTestImplementation "com.squareup.okhttp3:mockwebserver:$okHttp"
225220
androidTestImplementation "com.nhaarman.mockitokotlin2:mockito-kotlin:$mockitoKotlin"
221+
androidTestImplementation "com.squareup.okhttp3:mockwebserver:$okHttp"
226222
androidTestImplementation "org.jetbrains.kotlin:kotlin-reflect:$kotlin_version"
227-
228-
kapt "com.android.tools.build.jetifier:jetifier-core:$jetifier"
229-
annotationProcessor "com.android.tools.build.jetifier:jetifier-core:$jetifier"
230223
}

0 commit comments

Comments
 (0)