Remove SplashScreen Animation (#5842)

Task/Issue URL: https://app.asana.com/0/0/1209841844839950 

### Description

Removes the splashscreen animation as we started to receive user
complaints pertaining to launch speed.

### Steps to test this PR

_Static Launch Screen_
- [x] Open the app on various supported SDK version e.g. 26, 30, 34
- [x] Check that the previous static logo shows on cold launch

### UI changes


https://github.com/user-attachments/assets/7abbb7ad-b0ac-4ea8-b290-4792d260053d

Author: mikescamell

app/src/main/java/com/duckduckgo/app/global/api/PixelParamRemovalInterceptor.kt

@@ -101,8 +101,6 @@ object PixelInterceptorPixelsRequiringDataCleaning : PixelParamRemovalPlugin {
             AppPixelName.SET_AS_DEFAULT_PROMPT_CLICK.pixelName to PixelParameter.removeAll(),
             AppPixelName.SET_AS_DEFAULT_PROMPT_DISMISSED.pixelName to PixelParameter.removeAll(),
             AppPixelName.SET_AS_DEFAULT_IN_MENU_CLICK.pixelName to PixelParameter.removeAll(),
-            AppPixelName.SPLASHSCREEN_SHOWN.pixelName to PixelParameter.removeAll(),
-            AppPixelName.SPLASHSCREEN_FAILED_TO_LAUNCH.pixelName to PixelParameter.removeAll(),
             AppPixelName.MENU_ACTION_NEW_TAB_PRESSED_FROM_SITE.pixelName to PixelParameter.removeAll(),
             AppPixelName.MENU_ACTION_NEW_TAB_PRESSED_FROM_SERP.pixelName to PixelParameter.removeAll(),
             AppPixelName.SETTINGS_SYNC_PRESSED.pixelName to PixelParameter.removeAtb(),

app/src/main/java/com/duckduckgo/app/launch/LaunchBridgeActivity.kt

@@ -16,8 +16,6 @@
 
 package com.duckduckgo.app.launch
 
-import android.content.Intent
-import android.content.pm.PackageManager
 import android.os.Bundle
 import androidx.core.splashscreen.SplashScreen.Companion.installSplashScreen
 import androidx.lifecycle.lifecycleScope
@@ -27,9 +25,6 @@ import com.duckduckgo.app.browser.R
 import com.duckduckgo.app.onboarding.ui.OnboardingActivity
 import com.duckduckgo.common.ui.DuckDuckGoActivity
 import com.duckduckgo.di.scopes.ActivityScope
-import java.time.Instant
-import java.time.temporal.ChronoUnit
-import kotlinx.coroutines.delay
 import kotlinx.coroutines.launch
 
 @InjectWith(ActivityScope::class)
@@ -40,29 +35,13 @@ class LaunchBridgeActivity : DuckDuckGoActivity() {
     override fun onCreate(savedInstanceState: Bundle?) {
         val splashScreen = installSplashScreen()
         super.onCreate(savedInstanceState)
+        splashScreen.setKeepOnScreenCondition { true }
 
         setContentView(R.layout.activity_launch)
 
         configureObservers()
 
-        viewModel.launchSplashScreenFailToExitJob(getLauncherPackageName())
-
-        splashScreen.setOnExitAnimationListener { splashScreenView ->
-            viewModel.cancelSplashScreenFailToExitJob()
-
-            val splashScreenAnimationEndTime =
-                Instant.ofEpochMilli(splashScreenView.iconAnimationStartMillis + splashScreenView.iconAnimationDurationMillis)
-            val remainingAnimationTime = Instant.now().until(
-                splashScreenAnimationEndTime,
-                ChronoUnit.MILLIS,
-            )
-
-            lifecycleScope.launch {
-                viewModel.sendWelcomeScreenPixel()
-                delay(remainingAnimationTime)
-                viewModel.determineViewToShow()
-            }
-        }
+        lifecycleScope.launch { viewModel.determineViewToShow() }
     }
 
     private fun configureObservers() {
@@ -93,12 +72,4 @@ class LaunchBridgeActivity : DuckDuckGoActivity() {
         overridePendingTransition(0, 0)
         finish()
     }
-
-    // Temporary to track splashscreen errors
-    private fun getLauncherPackageName(): String? {
-        val intent = Intent(Intent.ACTION_MAIN)
-        intent.addCategory(Intent.CATEGORY_HOME)
-        val resolveInfo = packageManager.resolveActivity(intent, PackageManager.MATCH_DEFAULT_ONLY)
-        return resolveInfo?.activityInfo?.packageName
-    }
 }

app/src/main/java/com/duckduckgo/app/launch/LaunchViewModel.kt

@@ -17,46 +17,31 @@
 package com.duckduckgo.app.launch
 
 import androidx.lifecycle.ViewModel
-import androidx.lifecycle.viewModelScope
 import com.duckduckgo.anvil.annotations.ContributesViewModel
 import com.duckduckgo.app.onboarding.store.UserStageStore
 import com.duckduckgo.app.onboarding.store.isNewUser
-import com.duckduckgo.app.pixels.AppPixelName.SPLASHSCREEN_FAILED_TO_LAUNCH
-import com.duckduckgo.app.pixels.AppPixelName.SPLASHSCREEN_SHOWN
 import com.duckduckgo.app.referral.AppInstallationReferrerStateListener
 import com.duckduckgo.app.referral.AppInstallationReferrerStateListener.Companion.MAX_REFERRER_WAIT_TIME_MS
-import com.duckduckgo.app.statistics.pixels.Pixel
 import com.duckduckgo.common.utils.SingleLiveEvent
 import com.duckduckgo.di.scopes.ActivityScope
 import javax.inject.Inject
-import kotlin.time.Duration.Companion.seconds
-import kotlinx.coroutines.Job
-import kotlinx.coroutines.delay
-import kotlinx.coroutines.launch
 import kotlinx.coroutines.withTimeoutOrNull
 import timber.log.Timber
 
 @ContributesViewModel(ActivityScope::class)
 class LaunchViewModel @Inject constructor(
     private val userStageStore: UserStageStore,
     private val appReferrerStateListener: AppInstallationReferrerStateListener,
-    private val pixel: Pixel,
 ) :
     ViewModel() {
 
-    private var splashScreenFailToExitJob: Job? = null
-
     val command: SingleLiveEvent<Command> = SingleLiveEvent()
 
     sealed class Command {
         data object Onboarding : Command()
         data class Home(val replaceExistingSearch: Boolean = false) : Command()
     }
 
-    fun sendWelcomeScreenPixel() {
-        pixel.fire(SPLASHSCREEN_SHOWN)
-    }
-
     suspend fun determineViewToShow() {
         waitForReferrerData()
 
@@ -67,19 +52,6 @@ class LaunchViewModel @Inject constructor(
         }
     }
 
-    fun launchSplashScreenFailToExitJob(launcherPackageName: String?) {
-        splashScreenFailToExitJob = viewModelScope.launch {
-            delay(1.5.seconds)
-            sendWelcomeScreenPixel()
-            determineViewToShow()
-            sendSplashScreenFailedToLaunchPixel(launcherPackageName)
-        }
-    }
-
-    fun cancelSplashScreenFailToExitJob() {
-        splashScreenFailToExitJob?.cancel()
-    }
-
     private suspend fun waitForReferrerData() {
         val startTime = System.currentTimeMillis()
 
@@ -90,14 +62,4 @@ class LaunchViewModel @Inject constructor(
 
         Timber.d("Waited ${System.currentTimeMillis() - startTime}ms for referrer")
     }
-
-    // Temporary to track splashscreen errors
-    private fun sendSplashScreenFailedToLaunchPixel(launcherPackageName: String?) {
-        val resolvedLauncherPackageName = launcherPackageName ?: "unknown"
-        val params = mapOf(
-            "launcherPackageName" to resolvedLauncherPackageName,
-            "api" to android.os.Build.VERSION.SDK_INT.toString(),
-        )
-        pixel.fire(pixel = SPLASHSCREEN_FAILED_TO_LAUNCH, parameters = params)
-    }
 }

app/src/main/java/com/duckduckgo/app/pixels/AppPixelName.kt

@@ -37,9 +37,6 @@ enum class AppPixelName(override val pixelName: String) : Pixel.PixelName {
     BROKEN_SITE_ALLOWLIST_REMOVE("m_broken_site_allowlist_remove"),
     PROTECTION_TOGGLE_BROKEN_SITE_REPORT("m_protection-toggled-off-breakage-report"),
 
-    SPLASHSCREEN_SHOWN("m_splashscreen_shown"),
-    SPLASHSCREEN_FAILED_TO_LAUNCH("m_splashscreen_failed_to_launch"),
-
     PREONBOARDING_INTRO_SHOWN_UNIQUE("m_preonboarding_intro_shown_unique"),
     PREONBOARDING_COMPARISON_CHART_SHOWN_UNIQUE("m_preonboarding_comparison_chart_shown_unique"),
     PREONBOARDING_CHOOSE_BROWSER_PRESSED("m_preonboarding_choose_browser_pressed"),

app/src/test/java/com/duckduckgo/app/launch/LaunchViewModelTest.kt

@@ -22,22 +22,15 @@ import com.duckduckgo.app.launch.LaunchViewModel.Command.Home
 import com.duckduckgo.app.launch.LaunchViewModel.Command.Onboarding
 import com.duckduckgo.app.onboarding.store.AppStage
 import com.duckduckgo.app.onboarding.store.UserStageStore
-import com.duckduckgo.app.pixels.AppPixelName
 import com.duckduckgo.app.referral.StubAppReferrerFoundStateListener
 import com.duckduckgo.common.test.CoroutineTestRule
-import com.duckduckgo.fakes.FakePixel
-import kotlin.time.Duration.Companion.seconds
-import kotlinx.coroutines.ExperimentalCoroutinesApi
-import kotlinx.coroutines.test.advanceTimeBy
 import kotlinx.coroutines.test.runTest
 import org.junit.After
-import org.junit.Assert.assertTrue
 import org.junit.Rule
 import org.junit.Test
 import org.mockito.kotlin.any
 import org.mockito.kotlin.mock
 import org.mockito.kotlin.verify
-import org.mockito.kotlin.verifyNoInteractions
 import org.mockito.kotlin.whenever
 
 class LaunchViewModelTest {
@@ -52,22 +45,18 @@ class LaunchViewModelTest {
     private val userStageStore = mock<UserStageStore>()
     private val mockCommandObserver: Observer<LaunchViewModel.Command> = mock()
 
-    private val fakePixel: FakePixel = FakePixel()
-
     private lateinit var testee: LaunchViewModel
 
     @After
     fun after() {
         testee.command.removeObserver(mockCommandObserver)
-        fakePixel.firedPixels.clear()
     }
 
     @Test
     fun whenOnboardingShouldShowAndReferrerDataReturnsQuicklyThenCommandIsOnboarding() = runTest {
         testee = LaunchViewModel(
             userStageStore,
             StubAppReferrerFoundStateListener("xx"),
-            fakePixel,
         )
         whenever(userStageStore.getUserAppStage()).thenReturn(AppStage.NEW)
         testee.command.observeForever(mockCommandObserver)
@@ -82,7 +71,6 @@ class LaunchViewModelTest {
         testee = LaunchViewModel(
             userStageStore,
             StubAppReferrerFoundStateListener("xx", mockDelayMs = 1_000),
-            fakePixel,
         )
         whenever(userStageStore.getUserAppStage()).thenReturn(AppStage.NEW)
         testee.command.observeForever(mockCommandObserver)
@@ -97,7 +85,6 @@ class LaunchViewModelTest {
         testee = LaunchViewModel(
             userStageStore,
             StubAppReferrerFoundStateListener("xx", mockDelayMs = Long.MAX_VALUE),
-            fakePixel,
         )
         whenever(userStageStore.getUserAppStage()).thenReturn(AppStage.NEW)
         testee.command.observeForever(mockCommandObserver)
@@ -112,7 +99,6 @@ class LaunchViewModelTest {
         testee = LaunchViewModel(
             userStageStore,
             StubAppReferrerFoundStateListener("xx"),
-            fakePixel,
         )
         whenever(userStageStore.getUserAppStage()).thenReturn(AppStage.DAX_ONBOARDING)
         testee.command.observeForever(mockCommandObserver)
@@ -125,7 +111,6 @@ class LaunchViewModelTest {
         testee = LaunchViewModel(
             userStageStore,
             StubAppReferrerFoundStateListener("xx", mockDelayMs = 1_000),
-            fakePixel,
         )
         whenever(userStageStore.getUserAppStage()).thenReturn(AppStage.DAX_ONBOARDING)
         testee.command.observeForever(mockCommandObserver)
@@ -138,72 +123,10 @@ class LaunchViewModelTest {
         testee = LaunchViewModel(
             userStageStore,
             StubAppReferrerFoundStateListener("xx", mockDelayMs = Long.MAX_VALUE),
-            fakePixel,
         )
         whenever(userStageStore.getUserAppStage()).thenReturn(AppStage.DAX_ONBOARDING)
         testee.command.observeForever(mockCommandObserver)
         testee.determineViewToShow()
         verify(mockCommandObserver).onChanged(any<Home>())
     }
-
-    @Test
-    fun whenSendingWelcomeScreenPixelThenSplashScreenShownPixelIsSent() = runTest {
-        testee = LaunchViewModel(
-            userStageStore,
-            StubAppReferrerFoundStateListener("xx", mockDelayMs = Long.MAX_VALUE),
-            fakePixel,
-        )
-
-        testee.sendWelcomeScreenPixel()
-
-        assertTrue(fakePixel.firedPixels.containsKey(AppPixelName.SPLASHSCREEN_SHOWN.pixelName))
-    }
-
-    @OptIn(ExperimentalCoroutinesApi::class)
-    @Test
-    fun whenLaunchSplashScreenFailToExitJobCalledThenItExecutesFallbackAfterDelay() = runTest {
-        whenever(userStageStore.getUserAppStage()).thenReturn(AppStage.ESTABLISHED)
-
-        testee = LaunchViewModel(
-            userStageStore,
-            StubAppReferrerFoundStateListener("xx", mockDelayMs = Long.MAX_VALUE),
-            fakePixel,
-        )
-
-        testee.command.observeForever(mockCommandObserver)
-        testee.launchSplashScreenFailToExitJob("testLauncher")
-
-        // Wait for fail to exit timeout and referrer timeout
-        advanceTimeBy(3.5.seconds)
-
-        assertTrue(fakePixel.firedPixels.containsKey(AppPixelName.SPLASHSCREEN_FAILED_TO_LAUNCH.pixelName))
-
-        val pixelParams = fakePixel.firedPixels[AppPixelName.SPLASHSCREEN_FAILED_TO_LAUNCH.pixelName]
-        assertTrue(pixelParams!!.containsValue("testLauncher"))
-        assertTrue(pixelParams.containsKey("api"))
-
-        verify(mockCommandObserver).onChanged(any<Home>())
-    }
-
-    @OptIn(ExperimentalCoroutinesApi::class)
-    @Test
-    fun whenCancelSplashScreenFailToExitJobThenStopsFallback() = runTest {
-        whenever(userStageStore.getUserAppStage()).thenReturn(AppStage.ESTABLISHED)
-
-        testee = LaunchViewModel(
-            userStageStore,
-            StubAppReferrerFoundStateListener("xx", mockDelayMs = Long.MAX_VALUE),
-            fakePixel,
-        )
-
-        testee.command.observeForever(mockCommandObserver)
-        testee.launchSplashScreenFailToExitJob("testLauncher")
-        testee.cancelSplashScreenFailToExitJob()
-
-        // advance time to ensure that the code does not execute after the delay
-        advanceTimeBy(3.seconds)
-
-        assertTrue(fakePixel.firedPixels.isEmpty())
-        verifyNoInteractions(mockCommandObserver)
-    }
 }

app/src/test/java/com/duckduckgo/fakes/FakePixel.kt

@@ -22,15 +22,15 @@ import com.duckduckgo.app.statistics.pixels.Pixel.PixelType
 
 internal class FakePixel : Pixel {
 
-    val firedPixels = mutableMapOf<String, Map<String, String>>()
+    val firedPixels = mutableListOf<String>()
 
     override fun fire(
         pixel: PixelName,
         parameters: Map<String, String>,
         encodedParameters: Map<String, String>,
         type: PixelType,
     ) {
-        firedPixels[pixel.pixelName] = parameters
+        firedPixels.add(pixel.pixelName)
     }
 
     override fun fire(
@@ -39,22 +39,22 @@ internal class FakePixel : Pixel {
         encodedParameters: Map<String, String>,
         type: PixelType,
     ) {
-        firedPixels[pixelName] = parameters
+        firedPixels.add(pixelName)
     }
 
     override fun enqueueFire(
         pixel: PixelName,
         parameters: Map<String, String>,
         encodedParameters: Map<String, String>,
     ) {
-        firedPixels[pixel.pixelName] = parameters
+        firedPixels.add(pixel.pixelName)
     }
 
     override fun enqueueFire(
         pixelName: String,
         parameters: Map<String, String>,
         encodedParameters: Map<String, String>,
     ) {
-        firedPixels[pixelName] = parameters
+        firedPixels.add(pixelName)
     }
 }