Skip to content

Commit ea88c24

Browse files
authored
Android: Dax Dialogs - quick improvements on big screens (#756)
* UI fixes for tablets. - changing alignment and max-width for dax dialogs
1 parent 2da93e6 commit ea88c24

File tree

4 files changed

+16
-12
lines changed

4 files changed

+16
-12
lines changed

app/src/main/res/layout-land/content_onboarding_welcome.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,12 @@
5959

6060
<include
6161
layout="@layout/include_dax_dialog_cta"
62-
android:layout_width="match_parent"
63-
android:layout_height="0dp"
62+
android:layout_width="0dp"
63+
android:layout_height="wrap_content"
6464
android:layout_marginTop="93dp"
6565
app:layout_constraintEnd_toEndOf="parent"
6666
app:layout_constraintStart_toStartOf="parent"
67-
app:layout_constraintTop_toTopOf="parent" />
67+
app:layout_constraintTop_toTopOf="parent"
68+
app:layout_constraintWidth_max="600dp"/>
6869

6970
</androidx.constraintlayout.widget.ConstraintLayout>

app/src/main/res/layout/content_dax_dialog.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
android:layout_marginStart="24dp"
6161
android:layout_marginBottom="16dp"
6262
app:layout_constraintBottom_toTopOf="@id/cardView"
63-
app:layout_constraintStart_toStartOf="parent"
63+
app:layout_constraintStart_toStartOf="@id/cardView"
6464
app:srcCompat="@drawable/ic_dax_icon" />
6565

6666
<androidx.appcompat.widget.AppCompatImageView
@@ -74,7 +74,7 @@
7474

7575
<androidx.cardview.widget.CardView
7676
android:id="@+id/cardView"
77-
android:layout_width="match_parent"
77+
android:layout_width="0dp"
7878
android:layout_height="wrap_content"
7979
android:layout_marginStart="8dp"
8080
android:layout_marginEnd="8dp"
@@ -83,7 +83,8 @@
8383
app:cardCornerRadius="20dp"
8484
app:layout_constraintBottom_toBottomOf="parent"
8585
app:layout_constraintEnd_toEndOf="parent"
86-
app:layout_constraintStart_toStartOf="parent">
86+
app:layout_constraintStart_toStartOf="parent"
87+
app:layout_constraintWidth_max="600dp">
8788

8889
<LinearLayout
8990
android:id="@+id/cardContainer"

app/src/main/res/layout/content_onboarding_welcome.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,12 @@
5959

6060
<include
6161
layout="@layout/include_dax_dialog_cta"
62-
android:layout_width="match_parent"
63-
android:layout_height="0dp"
62+
android:layout_width="0dp"
63+
android:layout_height="wrap_content"
6464
android:layout_marginTop="93dp"
6565
app:layout_constraintEnd_toEndOf="parent"
6666
app:layout_constraintStart_toStartOf="parent"
67-
app:layout_constraintTop_toTopOf="parent" />
67+
app:layout_constraintTop_toTopOf="parent"
68+
app:layout_constraintWidth_max="600dp"/>
6869

6970
</androidx.constraintlayout.widget.ConstraintLayout>

app/src/main/res/layout/include_new_browser_tab.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,13 @@
5454

5555
<include
5656
layout="@layout/include_dax_dialog_cta"
57-
android:layout_width="match_parent"
58-
android:layout_height="0dp"
57+
android:layout_width="0dp"
58+
android:layout_height="wrap_content"
5959
android:layout_marginTop="40dp"
6060
app:layout_constraintEnd_toEndOf="parent"
6161
app:layout_constraintStart_toStartOf="parent"
62-
app:layout_constraintTop_toTopOf="parent" />
62+
app:layout_constraintTop_toTopOf="parent"
63+
app:layout_constraintWidth_max="600dp"/>
6364

6465
<LinearLayout
6566
android:id="@+id/ctaContainer"

0 commit comments

Comments
 (0)