Cache assets path loading (#5142)

Task/Issue URL:
https://app.asana.com/0/1202552961248957/1208539373099857/f

### Description

### Steps to test this PR

_Feature 1_
- Smoke test Duck Player and navigation

### UI changes
| Before  | After |
| ------ | ----- |
!(Upload before screenshot)|(Upload after screenshot)|

Author: CrisBarreiro

app/src/main/java/com/duckduckgo/app/browser/SpecialUrlDetector.kt

@@ -26,6 +26,7 @@ import android.net.Uri
 import androidx.core.net.toUri
 import com.duckduckgo.app.browser.SpecialUrlDetector.UrlType
 import com.duckduckgo.app.browser.applinks.ExternalAppIntentFlagsFeature
+import com.duckduckgo.common.utils.DispatcherProvider
 import com.duckduckgo.duckplayer.api.DuckPlayer
 import com.duckduckgo.privacy.config.api.AmpLinkType
 import com.duckduckgo.privacy.config.api.AmpLinks
@@ -45,6 +46,7 @@ class SpecialUrlDetectorImpl(
     private val externalAppIntentFlagsFeature: ExternalAppIntentFlagsFeature,
     private val duckPlayer: DuckPlayer,
     private val scope: CoroutineScope,
+    private val dispatcherProvider: DispatcherProvider,
 ) : SpecialUrlDetector {
 
     override fun determineType(initiatingUrl: String?, uri: Uri): UrlType {
@@ -90,9 +92,9 @@ class SpecialUrlDetectorImpl(
 
         val uri = uriString.toUri()
 
-        val willNavigateToDuckPlayerDeferred = scope.async { duckPlayer.willNavigateToDuckPlayer(uri) }
+        val willNavigateToDuckPlayerDeferred = scope.async(dispatcherProvider.io()) { duckPlayer.willNavigateToDuckPlayer(uri) }
 
-        val willNavigateToDuckPlayer = runBlocking { willNavigateToDuckPlayerDeferred.await() }
+        val willNavigateToDuckPlayer = runBlocking(dispatcherProvider.io()) { willNavigateToDuckPlayerDeferred.await() }
 
         if (willNavigateToDuckPlayer) {
             return UrlType.ShouldLaunchDuckPlayerLink(url = uri)

app/src/main/java/com/duckduckgo/app/browser/di/BrowserModule.kt

@@ -189,6 +189,7 @@ class BrowserModule {
         externalAppIntentFlagsFeature: ExternalAppIntentFlagsFeature,
         duckPlayer: DuckPlayer,
         @AppCoroutineScope appCoroutineScope: CoroutineScope,
+        dispatcherProvider: DispatcherProvider,
     ): SpecialUrlDetector = SpecialUrlDetectorImpl(
         packageManager,
         ampLinks,
@@ -197,6 +198,7 @@ class BrowserModule {
         externalAppIntentFlagsFeature,
         duckPlayer,
         appCoroutineScope,
+        dispatcherProvider = dispatcherProvider,
     )
 
     @Provides

app/src/test/java/com/duckduckgo/app/browser/SpecialUrlDetectorImplTest.kt

@@ -80,6 +80,7 @@ class SpecialUrlDetectorImplTest {
             externalAppIntentFlagsFeature = externalAppIntentFlagsFeature,
             duckPlayer = mockDuckPlayer,
             scope = coroutineRule.testScope,
+            dispatcherProvider = coroutineRule.testDispatcherProvider,
         )
         whenever(mockPackageManager.queryIntentActivities(any(), anyInt())).thenReturn(emptyList())
         whenever(mockDuckPlayer.willNavigateToDuckPlayer(any())).thenReturn(false)

duckplayer/duckplayer-impl/src/main/java/com/duckduckgo/duckplayer/impl/DuckPlayerLocalFilesPath.kt

@@ -17,19 +17,39 @@
 package com.duckduckgo.duckplayer.impl
 
 import android.content.res.AssetManager
+import com.duckduckgo.app.di.AppCoroutineScope
+import com.duckduckgo.common.utils.DispatcherProvider
 import com.duckduckgo.di.scopes.AppScope
 import com.squareup.anvil.annotations.ContributesBinding
+import dagger.SingleInstanceIn
 import java.io.IOException
 import javax.inject.Inject
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Deferred
+import kotlinx.coroutines.async
+import kotlinx.coroutines.withContext
 
 interface DuckPlayerLocalFilesPath {
-    val assetsPath: List<String>
+    suspend fun assetsPath(): List<String>
 }
 
 @ContributesBinding(AppScope::class)
-class RealDuckPlayerLocalFilesPath @Inject constructor(private val assetManager: AssetManager) : DuckPlayerLocalFilesPath {
+@SingleInstanceIn(AppScope::class)
+class RealDuckPlayerLocalFilesPath @Inject constructor(
+    private val assetManager: AssetManager,
+    @AppCoroutineScope appCoroutineScope: CoroutineScope,
+    private val dispatcherProvider: DispatcherProvider,
+) : DuckPlayerLocalFilesPath {
 
-    override val assetsPath: List<String> = getAllAssetFilePaths("duckplayer")
+    private val assetsPathDeferred: Deferred<List<String>> = appCoroutineScope.async(dispatcherProvider.io()) {
+        getAllAssetFilePaths("duckplayer")
+    }
+
+    override suspend fun assetsPath(): List<String> {
+        return withContext(dispatcherProvider.io()) {
+            assetsPathDeferred.await()
+        }
+    }
 
     private fun getAllAssetFilePaths(directory: String): List<String> {
         val filePaths = mutableListOf<String>()

duckplayer/duckplayer-impl/src/main/java/com/duckduckgo/duckplayer/impl/RealDuckPlayer.kt

@@ -223,7 +223,7 @@ class RealDuckPlayer @Inject constructor(
     }
 
     override suspend fun isSimulatedYoutubeNoCookie(uri: Uri): Boolean {
-        val validPaths = duckPlayerLocalFilesPath.assetsPath
+        val validPaths = duckPlayerLocalFilesPath.assetsPath()
         val embedUrl = duckPlayerFeatureRepository.getYouTubeEmbedUrl()
         return (
             uri.host?.removePrefix("www.") ==
@@ -353,15 +353,8 @@ class RealDuckPlayer @Inject constructor(
     }
 
     private suspend fun doesYoutubeUrlComeFromDuckPlayer(url: Uri, request: WebResourceRequest? = null): Boolean {
-        val referer = request?.requestHeaders?.keys?.firstOrNull { it in duckPlayerFeatureRepository.getYouTubeReferrerHeaders() }
-            ?.let { url.getQueryParameter(it) }
-        val previousUrl = duckPlayerFeatureRepository.getYouTubeReferrerQueryParams()
-            .firstOrNull { url.getQueryParameter(it) != null }
-            ?.let { url.getQueryParameter(it) }
-
         val videoIdQueryParam = duckPlayerFeatureRepository.getVideoIDQueryParam()
         val requestedVideoId = url.getQueryParameter(videoIdQueryParam)
-
         val isSimulated: suspend (String?) -> Boolean = { uri ->
             uri?.let { isSimulatedYoutubeNoCookie(it.toUri()) } == true
         }
@@ -370,8 +363,16 @@ class RealDuckPlayer @Inject constructor(
             uri?.toUri()?.getQueryParameter(DUCK_PLAYER_VIDEO_ID_QUERY_PARAM) == requestedVideoId
         }
 
-        return isSimulated(referer) && isMatchingVideoId(referer) ||
-            isSimulated(previousUrl) && isMatchingVideoId(previousUrl)
+        val referer = request?.requestHeaders?.keys?.firstOrNull { it in duckPlayerFeatureRepository.getYouTubeReferrerHeaders() }
+            ?.let { url.getQueryParameter(it) }
+
+        if (isSimulated(referer) && isMatchingVideoId(referer)) return true
+
+        val previousUrl = duckPlayerFeatureRepository.getYouTubeReferrerQueryParams()
+            .firstOrNull { url.getQueryParameter(it) != null }
+            ?.let { url.getQueryParameter(it) }
+
+        return isSimulated(previousUrl) && isMatchingVideoId(previousUrl)
     }
 
     private suspend fun processDuckPlayerUri(
@@ -424,8 +425,8 @@ class RealDuckPlayer @Inject constructor(
     ): Boolean {
         return (
             isFeatureEnabled &&
-                isYoutubeWatchUrl(destinationUrl) &&
                 getUserPreferences().privatePlayerMode == Enabled &&
+                isYoutubeWatchUrl(destinationUrl) &&
                 !(shouldForceYTNavigation || doesYoutubeUrlComeFromDuckPlayer(destinationUrl))
             )
     }

duckplayer/duckplayer-impl/src/test/kotlin/com/duckduckgo/duckplayer/impl/RealDuckPlayerTest.kt

@@ -370,7 +370,7 @@ class RealDuckPlayerTest {
 
     @Test
     fun whenUrHostIsEmbedAndFileIsAvailableLocally_isSimulatedYoutubeNoCookieReturnsTrue() = runTest {
-        whenever(mockDuckPlayerLocalFilesPath.assetsPath).thenReturn(listOf("js/duckplayer.js"))
+        whenever(mockDuckPlayerLocalFilesPath.assetsPath()).thenReturn(listOf("js/duckplayer.js"))
         val uri = "https://www.youtube-nocookie.com/js/duckplayer.js".toUri()
 
         val result = testee.isSimulatedYoutubeNoCookie(uri)
@@ -380,7 +380,7 @@ class RealDuckPlayerTest {
 
     @Test
     fun whenUrHostIsEmbedAndFileIsNotAvailableLocally_isSimulatedYoutubeNoCookieReturnsFalse() = runTest {
-        whenever(mockDuckPlayerLocalFilesPath.assetsPath).thenReturn(listOf("css/duckplayer.css"))
+        whenever(mockDuckPlayerLocalFilesPath.assetsPath()).thenReturn(listOf("css/duckplayer.css"))
         val uri = "https://www.youtube-nocookie.com/js/duckplayer.js".toUri()
 
         val result = testee.isSimulatedYoutubeNoCookie(uri)
@@ -390,7 +390,7 @@ class RealDuckPlayerTest {
 
     @Test
     fun whenUrHostIsEmbedAndPathContainsEmbed_isSimulatedYoutubeNoCookieReturnsFalse() = runTest {
-        whenever(mockDuckPlayerLocalFilesPath.assetsPath).thenReturn(listOf())
+        whenever(mockDuckPlayerLocalFilesPath.assetsPath()).thenReturn(listOf())
         val uri = "https://www.youtube-nocookie.com/embed/js/duckplayer.js".toUri()
 
         val result = testee.isSimulatedYoutubeNoCookie(uri)