Bottom Navigation (#778)

* added simple bottom navigation bar

* adding a new behaviour that hides the bottom bar when scrolling down the content, but shows it when scrolling up

* cleaning up the bottombar, proper inheritance

* added tabswitcher button to bottomnavigationbar

* enabling buttons in bottom bar based on state

* removing all scrolling layout flags from the xml, we use the OmnibarScrolling for that

* adding snapping behaviour to the bottom bar

* cleaning up the behaviour

* added missing menu for browser activity

* added experiment decorator that will handle UI for different experiments

* implemented decorator variants as per current designs

* PopupMenu also knows about the experiment we are running

* added swipe to refresh

* using bottom bar for now

* cleaning up the code

* cleaning up

* binding all buttons in bottom bar

* added popupmenu that anchors to the bottombar

* we can now decorate the toolbar based on the experiment

* added experiment variants for the bottom navigation

* always showing the omnibar background

* no need for old custom webview, scroll is already properly supported

* removing pull to refresh for now

* using the search experiment by default

* removed the second experiment, binding popup and bottom bar click listeners

* added new icons for bottom bar and popup menu

* popup menu now also respect light / dark theme

* using new color attribute for dark / light theme

* ignoring variant tests for now, we are lying

* bottom bar is only visible if the omnibar has no focus

* the search icon is shown only when the serp has focus, and the privacy grade works the opposite way

* cleaning up the tabs switcher and removing its animation

* updating version for internal release

* proper padding of items in bottom bar

* remove unused file

* add new tabs screen

* we have a new activity to show tabs with the experiment

* we only use the new activity if the experiment is on

* more ui work

* Update popup_window_browser_bottom_tab_menu.xml

checkbox should also be tinted

* all toolbars should be the same

* ui tweaks with Robert

* improved elevation for the bottom bar

* ensure keyboard is not shown if the omnibar does not have focus

* search icon / privacy grade should be properly updated

* ensure grade button is hidden

* added pixels to track experiment engagement

* added missing fire icon pixel

* ensure we also animate the bottom bar after animating the toolbar

* moving search next to the fire icon

* added proper background for the bottom bar

* ensure that the widget cta is sitting in top of the bottom navigation bar

* added delay to keyboard animation so it doesn't look wonky

* ensure cta container respects the bottom bar height

* remove the animation when hiding the keyboard

* make sure that the first time the container shows we respect the bottom bar height

* updated pixel values for the experiment

* swapped order of icons in bottom bar

* adding tests for the variant manager

* updated version for release

* fixed tds hast test

* fixed etag test

* enable for now

* improved color selection for api 21

* fixing vector drawables so they show the proper path

* these tests should be running

* addressing some PR comments

* cleaning up double assignation

* clean up some comments

* more code cleanup

* swap experiment with feature for readibility

* revert experiments to original values, it's not this PR responsibility to remove them

* updating experiment names

* proper reference

* ensure all pixels trigger the variant key

* revert wrong variant change

* cleaning up colors and selectors

* no need for this

* cleaning up the toolbar, make sure we show the icons for both experiments

* returning experiments back to original distibution

* hide new menu buttons when in bottomnav mode

* no need for this selector because we use theming now

* ensure the omnibar is using full width

* ensure widget container is shown properly

* removing the behaviour so the omnibar is properly updated

* revert this to what it was

* revert this to fix tests

* proper style for checkbox

* cleaning up state and visibility of the toolbar

* updated etag for tests

* revert tdstest changes

* cleanup references

* add missing pixel after opening a new tab

* move this to the decorator

* duplicate call

* better method naming

* remove duplicate call for this method

* ensure bottombar is visible after opening a new tab

* another redundant call

* renaming bottom bar only icons

* no longer used

* proper icon name

* removing unnecessary method

* fix color reference pointing to wrong attribute

Author: malmstein

app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt

@@ -611,16 +611,18 @@ class BrowserTabViewModelTest {
     }
 
     @Test
-    fun whenBrowserNotShownAndOmnibarInputDoesNotHaveFocusThenPrivacyGradeIsNotShown() {
+    fun whenOmnibarDoesNotHaveFocusThenPrivacyGradeIsShownAndSearchIconIsHidden() {
         testee.onOmnibarInputStateChanged(query = "", hasFocus = false, hasQueryChanged = false)
-        assertFalse(browserViewState().showPrivacyGrade)
+        assertTrue(browserViewState().showPrivacyGrade)
+        assertFalse(browserViewState().showSearchIcon)
     }
 
     @Test
-    fun whenBrowserShownAndOmnibarInputDoesNotHaveFocusThenPrivacyGradeIsShown() {
+    fun whenBrowserShownAndOmnibarInputDoesNotHaveFocusThenPrivacyGradeIsShownAndSearchIconIsHidden() {
         testee.onUserSubmittedQuery("foo")
         testee.onOmnibarInputStateChanged(query = "", hasFocus = false, hasQueryChanged = false)
         assertTrue(browserViewState().showPrivacyGrade)
+        assertFalse(browserViewState().showSearchIcon)
     }
 
     @Test
@@ -630,10 +632,11 @@ class BrowserTabViewModelTest {
     }
 
     @Test
-    fun whenBrowserShownAndOmnibarInputHasFocusThenPrivacyGradeIsShown() {
+    fun whenBrowserShownAndOmnibarInputHasFocusThenSearchIconIsShownAndPrivacyGradeIsHidden() {
         testee.onUserSubmittedQuery("foo")
         testee.onOmnibarInputStateChanged("", true, hasQueryChanged = false)
-        assertTrue(browserViewState().showPrivacyGrade)
+        assertFalse(browserViewState().showPrivacyGrade)
+        assertTrue(browserViewState().showSearchIcon)
     }
 
     @Test

app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt

@@ -43,6 +43,23 @@ class VariantManagerTest {
         assertEquals(0, variant.features.size)
     }
 
+    // Bottom Bar Navigation Experiment
+
+    @Test
+    fun bottomBarNavigationControlVariantIsActiveAndHasNoFeatures() {
+        val variant = variants.first { it.key == "mm" }
+        assertEqualsDouble(1.0, variant.weight)
+        assertEquals(0, variant.features.size)
+    }
+
+    @Test
+    fun bottomBarNavigationVariantIsActiveAndHasBottomBarNavigationFeature() {
+        val variant = variants.first { it.key == "mn" }
+        assertEqualsDouble(1.0, variant.weight)
+        assertEquals(1, variant.features.size)
+        assertTrue(variant.hasFeature(BottomBarNavigation))
+    }
+
     @Test
     fun verifyNoDuplicateVariantNames() {
         val existingNames = mutableSetOf<String>()

app/src/main/AndroidManifest.xml

@@ -234,6 +234,10 @@
             android:name="com.duckduckgo.app.tabs.ui.TabSwitcherActivity"
             android:label="@string/tabActivityTitle" />
 
+        <activity
+            android:name="com.duckduckgo.app.tabs.ui.TabSwitcherBottomBarFeatureActivity"
+            android:label="@string/tabActivityTitle" />
+
         <activity
             android:name="com.duckduckgo.app.privacy.ui.PrivacyDashboardActivity"
             android:label="@string/privacyDashboardActivityTitle"

app/src/main/java/com/duckduckgo/app/about/AboutDuckDuckGoActivity.kt

@@ -31,19 +31,14 @@ class AboutDuckDuckGoActivity : DuckDuckGoActivity() {
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_about_duck_duck_go)
-        configureActionBar()
+        setupToolbar(toolbar)
 
         learnMoreLink.setOnClickListener {
             startActivity(BrowserActivity.intent(this, Url.ABOUT))
             finish()
         }
     }
 
-    private fun configureActionBar() {
-        setSupportActionBar(toolbar)
-        supportActionBar?.setDisplayHomeAsUpEnabled(true)
-    }
-
     companion object {
         fun intent(context: Context): Intent {
             return Intent(context, AboutDuckDuckGoActivity::class.java)

app/src/main/java/com/duckduckgo/app/bookmarks/ui/BookmarksActivity.kt

@@ -59,7 +59,7 @@ class BookmarksActivity : DuckDuckGoActivity() {
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_bookmarks)
-        setupActionBar()
+        setupToolbar(toolbar)
         setupBookmarksRecycler()
         observeViewModel()
     }
@@ -72,11 +72,6 @@ class BookmarksActivity : DuckDuckGoActivity() {
         recycler.addItemDecoration(separator)
     }
 
-    private fun setupActionBar() {
-        setSupportActionBar(toolbar)
-        supportActionBar?.setDisplayHomeAsUpEnabled(true)
-    }
-
     private fun observeViewModel() {
         viewModel.viewState.observe(this, Observer<BookmarksViewModel.ViewState> { viewState ->
             viewState?.let {

app/src/main/java/com/duckduckgo/app/brokensite/BrokenSiteActivity.kt

@@ -31,7 +31,6 @@ import kotlinx.android.synthetic.main.content_broken_sites.*
 import kotlinx.android.synthetic.main.include_toolbar.*
 import org.jetbrains.anko.longToast
 
-
 class BrokenSiteActivity : DuckDuckGoActivity() {
     private val viewModel: BrokenSiteViewModel by bindViewModel()
 
@@ -40,17 +39,12 @@ class BrokenSiteActivity : DuckDuckGoActivity() {
         setContentView(R.layout.activity_broken_site)
         configureListeners()
         configureObservers()
-        setupActionBar()
+        setupToolbar(toolbar)
         if (savedInstanceState == null) {
             consumeIntentExtra()
         }
     }
 
-    private fun setupActionBar() {
-        setSupportActionBar(toolbar)
-        supportActionBar?.setDisplayHomeAsUpEnabled(true)
-    }
-
     private fun consumeIntentExtra() {
         val url = intent.getStringExtra(URL_EXTRA)
         val blockedTrackers = intent.getStringExtra(BLOCKED_TRACKERS_EXTRA)

app/src/main/java/com/duckduckgo/app/browser/BrowserPopupMenu.kt

@@ -24,15 +24,17 @@ import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup.LayoutParams.WRAP_CONTENT
 import android.widget.PopupWindow
+import com.duckduckgo.app.statistics.Variant
+import com.duckduckgo.app.statistics.VariantManager
 
-class BrowserPopupMenu : PopupWindow {
+class BrowserPopupMenu(layoutInflater: LayoutInflater, variant: Variant, view: View = inflate(layoutInflater, variant)) :
+    PopupWindow(view, WRAP_CONTENT, WRAP_CONTENT, true) {
 
-    constructor(layoutInflater: LayoutInflater, view: View = BrowserPopupMenu.inflate(layoutInflater))
-            : super(view, WRAP_CONTENT, WRAP_CONTENT, true) {
+    // popupwindow gets stuck on the screen on API 22 (tested on 23) without a background
+    // color.  Adding it however garbles the elevation so we cannot have elevation here.
 
+    init {
         if (SDK_INT <= 22) {
-            // popupwindow gets stuck on the screen on API 22 (tested on 23) without a background
-            // color.  Adding it however garbles the elevation so we cannot have elevation here.
             setBackgroundDrawable(ColorDrawable(Color.WHITE))
         } else {
             elevation = 6.toFloat()
@@ -59,10 +61,21 @@ class BrowserPopupMenu : PopupWindow {
 
         private const val margin = 30
 
-        fun inflate(layoutInflater: LayoutInflater): View {
+        fun inflate(layoutInflater: LayoutInflater, variant: Variant): View {
+            return if (variant.hasFeature(VariantManager.VariantFeature.BottomBarNavigation)) {
+                inflateBottomBarWithSearchFeature(layoutInflater)
+            } else {
+                inflateToolbarOnly(layoutInflater)
+            }
+        }
+
+        private fun inflateToolbarOnly(layoutInflater: LayoutInflater): View {
             return layoutInflater.inflate(R.layout.popup_window_browser_menu, null)
         }
 
+        private fun inflateBottomBarWithSearchFeature(layoutInflater: LayoutInflater): View {
+            return layoutInflater.inflate(R.layout.popup_window_browser_bottom_tab_menu, null)
+        }
     }
 }