Skip to content

Commit f5f783d

Browse files
authored
Split statistics module into :api and :impl (#4662)
Task/Issue URL: https://app.asana.com/0/1205648422731273/1203121956327036/f ### Description This PR splits the existing statistics module into statistics-impl and statistics-api modules. ### Steps to test this PR No behavior changes are expected. For smoke testing: - [x] Check if the app is still sending pixels. - [x] Create a crash and check that the corresponding pixel is sent. - [x] Create an ANR and chcek that the corresponding pixel is sent. ### No UI changes
1 parent 0019593 commit f5f783d

File tree

73 files changed

+395
-184
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

73 files changed

+395
-184
lines changed

ad-click/ad-click-impl/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ dependencies {
4040
implementation project(path: ':ad-click-api')
4141
implementation project(path: ':di')
4242
implementation project(path: ':common-utils')
43-
implementation project(path: ':statistics')
43+
implementation project(path: ':statistics-api')
4444
implementation project(path: ':privacy-config-api')
4545
implementation project(path: ':feature-toggles-api')
4646
implementation project(path: ':app-build-config-api')

anrs/anrs-impl/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ dependencies {
3333
implementation project(':di')
3434
implementation project(':browser-api')
3535
implementation project(':custom-tabs-api')
36-
implementation project(':statistics')
36+
implementation project(':statistics-api')
3737
implementation project(':verified-installation-api')
3838
implementation project(':library-loader-api')
3939
implementation project(':feature-toggles-api')

anrs/anrs-internal/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dependencies {
3434
implementation project(':common-ui')
3535
implementation project(':common-utils')
3636
implementation project(':navigation-api')
37-
implementation project(':statistics')
37+
implementation project(':statistics-api')
3838
implementation project(':internal-features-api')
3939
implementation project(':feature-toggles-api')
4040
implementation project(":app-build-config-api") // needed for feature toggles

app-tracking-protection/vpn-impl/build.gradle

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,12 @@ dependencies {
5555
implementation project(':di')
5656
implementation project(':common-utils')
5757
implementation project(':common-ui')
58-
implementation project(':statistics')
58+
implementation project(':statistics-api')
5959
implementation project(':app-build-config-api')
6060
implementation project(':feature-toggles-api')
6161
implementation project(':privacy-config-api')
6262
implementation project(':vpn-network-api')
6363
implementation project(':remote-messaging-api')
64-
implementation project(':statistics')
6564
implementation project(':library-loader-api')
6665
implementation project(':network-protection-api')
6766
implementation project(':data-store-api')

app/build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,8 @@ dependencies {
212212

213213
implementation project(':app-build-config-api')
214214
implementation project(':browser-api')
215-
implementation project(':statistics')
215+
implementation project(":statistics-api")
216+
implementation project(':statistics-impl')
216217
implementation project(':experiments-api')
217218
implementation project(':experiments-impl')
218219
implementation project(':common-utils')

app/src/main/java/com/duckduckgo/app/browser/pageloadpixel/firstpaint/PagePaintedOfflinePixelSender.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,9 @@
1717
package com.duckduckgo.app.browser.pageloadpixel.firstpaint
1818

1919
import com.duckduckgo.app.browser.WebViewPixelName
20-
import com.duckduckgo.app.browser.pageloadpixel.*
2120
import com.duckduckgo.app.statistics.api.OfflinePixel
2221
import com.duckduckgo.app.statistics.api.PixelSender
2322
import com.duckduckgo.app.statistics.pixels.Pixel
24-
import com.duckduckgo.app.statistics.pixels.Pixel.PixelParameter.WEBVIEW_VERSION
2523
import com.duckduckgo.di.scopes.AppScope
2624
import com.squareup.anvil.annotations.ContributesMultibinding
2725
import io.reactivex.Completable

autoconsent/autoconsent-impl/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ dependencies {
4242
implementation project(path: ':app-build-config-api')
4343
implementation project(path: ':app-store')
4444
implementation project(path: ':autoconsent-api')
45-
implementation project(path: ':statistics')
45+
implementation project(path: ':statistics-api')
4646
implementation project(path: ':browser-api')
4747
implementation project(path: ':navigation-api')
4848

autofill/autofill-impl/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ dependencies {
3636
implementation project(path: ':autofill-api')
3737
implementation project(path: ':browser-api')
3838
implementation project(path: ':autofill-store')
39-
implementation project(path: ':statistics')
39+
implementation project(path: ':statistics-api')
4040
testImplementation project(path: ':autofill-test')
4141
implementation project(path: ':sync-api')
4242
implementation project(path: ':navigation-api')

broken-site/broken-site-impl/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ dependencies {
3939
implementation project(path: ':browser-api')
4040
implementation project(path: ':di')
4141
implementation project(path: ':common-utils')
42-
implementation project(path: ':statistics')
42+
implementation project(path: ':statistics-api')
4343
implementation project(path: ':app-build-config-api')
4444
implementation project(path: ':broken-site-store')
4545

cookies/cookies-impl/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dependencies {
3434
implementation project(':cookies-api')
3535
implementation project(':cookies-store')
3636
implementation project(':browser-api')
37-
implementation project(':statistics')
37+
implementation project(':statistics-api')
3838
implementation project(':content-scope-scripts-api')
3939

4040
implementation JakeWharton.timber

0 commit comments

Comments
 (0)