Skip to content

Commit fd53891

Browse files
malmsteinkarlenDimla
authored andcommitted
Fix autocomplete pixels not being sent (#4866)
Task/Issue URL: https://app.asana.com/0/inbox/1157893581871899/1207984745988817/1207988320986561 ### Description Autocomplete pixels stopped being sent after the NTP refactor. This PR fixes that. ### Steps to test this PR _Pixels sent_ - [x] Fresh install - [x] Start typing on the URL bar so that the autocomplete view appears - [x] Close it, so that the autocomplete view dissappears - [x] Verify autocomplete pixels are sent - [x] 13:52:22.781 V Pixel sent: m_autocomplete_displayed_website with params: {} {} --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1207984745988817
1 parent 2157b22 commit fd53891

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3551,13 +3551,15 @@ class BrowserTabFragment :
35513551
if (viewState.showSuggestions || viewState.showFavorites) {
35523552
if (viewState.favorites.isNotEmpty() && viewState.showFavorites) {
35533553
showFocusedView()
3554+
viewModel.autoCompleteSuggestionsGone()
35543555
binding.autoCompleteSuggestionsList.gone()
35553556
} else {
35563557
binding.autoCompleteSuggestionsList.show()
35573558
autoCompleteSuggestionsAdapter.updateData(viewState.searchResults.query, viewState.searchResults.suggestions)
35583559
hideFocusedView()
35593560
}
35603561
} else {
3562+
viewModel.autoCompleteSuggestionsGone()
35613563
binding.autoCompleteSuggestionsList.gone()
35623564
hideFocusedView()
35633565
}

0 commit comments

Comments
 (0)