Sanitize intents in BrowserActivity (#1101)

Author: tvalle

app/src/main/java/com/duckduckgo/app/browser/BrowserActivity.kt

@@ -43,6 +43,7 @@ import com.duckduckgo.app.global.ApplicationClearDataState
 import com.duckduckgo.app.global.DuckDuckGoActivity
 import com.duckduckgo.app.global.events.db.UserEventsStore
 import com.duckduckgo.app.global.intentText
+import com.duckduckgo.app.global.sanitize
 import com.duckduckgo.app.global.view.*
 import com.duckduckgo.app.location.ui.LocationPermissionsActivity
 import com.duckduckgo.app.onboarding.ui.page.DefaultBrowserPage
@@ -133,6 +134,9 @@ class BrowserActivity : DuckDuckGoActivity(), CoroutineScope by MainScope() {
     override fun onNewIntent(intent: Intent?) {
         super.onNewIntent(intent)
         Timber.i("onNewIntent: $intent")
+
+        intent?.sanitize()
+
         dataClearerForegroundAppRestartPixel.registerIntent(intent)
 
         if (dataClearer.dataClearerState.value == ApplicationClearDataState.FINISHED) {

app/src/main/java/com/duckduckgo/app/global/IntentExtension.kt

@@ -17,8 +17,27 @@
 package com.duckduckgo.app.global
 
 import android.content.Intent
+import android.os.BadParcelableException
+import android.os.Bundle
+import timber.log.Timber
 
 val Intent.intentText: String?
     get() {
         return data?.toString() ?: getStringExtra(Intent.EXTRA_TEXT)
     }
+
+fun Intent.sanitize() {
+
+    try {
+        // The strings are empty to force unparcel() call in BaseBundle
+        getStringExtra("")
+        getBooleanExtra("", false)
+    } catch (e: BadParcelableException) {
+        Timber.e(e, "Failed to read Parcelable from intent")
+        replaceExtras(Bundle())
+
+    } catch (e: RuntimeException) {
+        Timber.e(e, "Failed to receive extras from intent")
+        replaceExtras(Bundle())
+    }
+}