From fe049dcda417cd296dc5ba59283b9f8dd37cd57a Mon Sep 17 00:00:00 2001 From: Mike Scamell Date: Wed, 23 Jul 2025 11:48:33 +0200 Subject: [PATCH 1/3] Stop warnings about android-large-runner --- .github/actionlint.yaml | 4 ++++ .github/workflows/validate_workflows.yml | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .github/actionlint.yaml diff --git a/.github/actionlint.yaml b/.github/actionlint.yaml new file mode 100644 index 000000000000..71bbb1d2cad5 --- /dev/null +++ b/.github/actionlint.yaml @@ -0,0 +1,4 @@ +self-hosted-runner: + labels: + # Stops incorrect warning of android-large-runner being used + - android-large-runner \ No newline at end of file diff --git a/.github/workflows/validate_workflows.yml b/.github/workflows/validate_workflows.yml index 1f55b4e3db03..7913163c33d6 100644 --- a/.github/workflows/validate_workflows.yml +++ b/.github/workflows/validate_workflows.yml @@ -26,4 +26,5 @@ jobs: github_token: ${{ secrets.GT_DAXMOBILE }} reporter: github-pr-review level: warning - fail_level: warning \ No newline at end of file + fail_level: warning + actionlint_flags: --config-file .github/actionlint.yaml \ No newline at end of file From ad4a3943dbd3cf05f4b697dde111e48e44cb6717 Mon Sep 17 00:00:00 2001 From: Mike Scamell Date: Wed, 23 Jul 2025 12:33:20 +0200 Subject: [PATCH 2/3] =?UTF-8?q?Fix=20useless=20cat=20=F0=9F=90=88?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit "shellcheck reported issue in this script: SC2002:style:1:5: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead [shellcheck]" --- .github/workflows/ci.yml | 2 +- .github/workflows/external-css-tests.yml | 2 +- .github/workflows/external-ref-tests.yml | 2 +- .github/workflows/nightly.yml | 2 +- .github/workflows/privacy.yml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b55b82aa3706..893152b1babe 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -185,7 +185,7 @@ jobs: if: | failure() && steps.check-alignment.outcome == 'success' - run: cat build/fladle/fladleResults/HtmlErrorReport.html | cut -d\` -f2 >> results.json + run: cut -d\` -f2 < build/fladle/fladleResults/HtmlErrorReport.html >> results.json - name: Print failure report if: | diff --git a/.github/workflows/external-css-tests.yml b/.github/workflows/external-css-tests.yml index 318e48284f73..f12c9702878f 100644 --- a/.github/workflows/external-css-tests.yml +++ b/.github/workflows/external-css-tests.yml @@ -66,7 +66,7 @@ jobs: - name: Generate json file with failures if: ${{ failure() }} - run: cat build/fladle/fladleResults/HtmlErrorReport.html | cut -d\` -f2 >> results.json + run: cut -d\` -f2 < build/fladle/fladleResults/HtmlErrorReport.html >> results.json - name: Print failure report if: ${{ failure() }} diff --git a/.github/workflows/external-ref-tests.yml b/.github/workflows/external-ref-tests.yml index 1e2eecc82cea..13de63f9d8f4 100644 --- a/.github/workflows/external-ref-tests.yml +++ b/.github/workflows/external-ref-tests.yml @@ -106,7 +106,7 @@ jobs: - name: Generate json file with failures if: ${{ failure() }} - run: cat build/fladle/fladleResults/HtmlErrorReport.html | cut -d\` -f2 >> results.json + run: cut -d\` -f2 < build/fladle/fladleResults/HtmlErrorReport.html >> results.json - name: Print failure report if: ${{ failure() }} diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index a6b5efc71e5a..7e46e32d38de 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -149,7 +149,7 @@ jobs: - name: Generate json file with failures if: ${{ failure() }} - run: cat build/fladle/fladleResults/HtmlErrorReport.html | cut -d\` -f2 >> results.json + run: cut -d\` -f2 < build/fladle/fladleResults/HtmlErrorReport.html >> results.json - name: Print failure report if: ${{ failure() }} diff --git a/.github/workflows/privacy.yml b/.github/workflows/privacy.yml index fd1a445e3452..9cd313f50fc7 100644 --- a/.github/workflows/privacy.yml +++ b/.github/workflows/privacy.yml @@ -66,7 +66,7 @@ jobs: - name: Generate json file with failures if: ${{ failure() }} - run: cat build/fladle/fladleResults/HtmlErrorReport.html | cut -d\` -f2 >> results.json + run: cut -d\` -f2 < build/fladle/fladleResults/HtmlErrorReport.html >> results.json - name: Print failure report if: ${{ failure() }} From cefe9bae9969e674fd3c12df2dae8a911ad15a7c Mon Sep 17 00:00:00 2001 From: Mike Scamell Date: Wed, 23 Jul 2025 12:35:54 +0200 Subject: [PATCH 3/3] Fix globbing "shellcheck reported issue in this script: SC2086:info:1:6: Double quote to prevent globbing and word splitting [shellcheck]" --- .github/workflows/ci.yml | 2 +- .github/workflows/external-css-tests.yml | 2 +- .github/workflows/external-ref-tests.yml | 2 +- .github/workflows/nightly.yml | 2 +- .github/workflows/privacy.yml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 893152b1babe..4e850e1cd98c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -141,7 +141,7 @@ jobs: - name: Decode secret env: FLANK: ${{ secrets.FLANK }} - run: echo $FLANK > flank.json + run: echo "$FLANK" > flank.json - name: Setup Gradle uses: gradle/actions/setup-gradle@v3 diff --git a/.github/workflows/external-css-tests.yml b/.github/workflows/external-css-tests.yml index f12c9702878f..dbd8b06add61 100644 --- a/.github/workflows/external-css-tests.yml +++ b/.github/workflows/external-css-tests.yml @@ -49,7 +49,7 @@ jobs: - name: Decode secret env: FLANK: ${{ secrets.FLANK }} - run: echo $FLANK > flank.json + run: echo "$FLANK" > flank.json - name: Setup Gradle uses: gradle/actions/setup-gradle@v3 diff --git a/.github/workflows/external-ref-tests.yml b/.github/workflows/external-ref-tests.yml index 13de63f9d8f4..a58b59bec321 100644 --- a/.github/workflows/external-ref-tests.yml +++ b/.github/workflows/external-ref-tests.yml @@ -89,7 +89,7 @@ jobs: - name: Decode secret env: FLANK: ${{ secrets.FLANK }} - run: echo $FLANK > flank.json + run: echo "$FLANK" > flank.json - name: Setup Gradle uses: gradle/actions/setup-gradle@v3 diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 7e46e32d38de..9ac7cd3ba0de 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -132,7 +132,7 @@ jobs: - name: Decode secret env: FLANK: ${{ secrets.FLANK }} - run: echo $FLANK > flank.json + run: echo "$FLANK" > flank.json - name: Setup Gradle uses: gradle/actions/setup-gradle@v3 diff --git a/.github/workflows/privacy.yml b/.github/workflows/privacy.yml index 9cd313f50fc7..76985658894f 100644 --- a/.github/workflows/privacy.yml +++ b/.github/workflows/privacy.yml @@ -49,7 +49,7 @@ jobs: - name: Decode secret env: FLANK: ${{ secrets.FLANK }} - run: echo $FLANK > flank.json + run: echo "$FLANK" > flank.json - name: Setup Gradle uses: gradle/actions/setup-gradle@v3