From a052176287f598eb0600414e31c61595ec2459a8 Mon Sep 17 00:00:00 2001 From: 0nko Date: Wed, 13 Aug 2025 13:01:10 +0200 Subject: [PATCH 1/4] Update the corner radius of all buttons to 12dp --- .../main/java/com/duckduckgo/common/ui/view/button/DaxButton.kt | 1 + 1 file changed, 1 insertion(+) diff --git a/common/common-ui/src/main/java/com/duckduckgo/common/ui/view/button/DaxButton.kt b/common/common-ui/src/main/java/com/duckduckgo/common/ui/view/button/DaxButton.kt index ce43ec9c65fe..9504d93c0ce9 100644 --- a/common/common-ui/src/main/java/com/duckduckgo/common/ui/view/button/DaxButton.kt +++ b/common/common-ui/src/main/java/com/duckduckgo/common/ui/view/button/DaxButton.kt @@ -63,6 +63,7 @@ open class DaxButton @JvmOverloads constructor( minHeight = resources.getDimensionPixelSize(Size.dimension(buttonSize)) setPadding(sidePadding, topPadding, sidePadding, topPadding) + setCornerRadiusResource(R.dimen.mediumShapeCornerRadius) } } From 7576f433676e3d8bd568fe48225f56a9cbfbd10d Mon Sep 17 00:00:00 2001 From: 0nko Date: Thu, 14 Aug 2025 10:35:47 +0200 Subject: [PATCH 2/4] Apply the radius in style instead --- .../com/duckduckgo/common/ui/view/button/DaxButton.kt | 1 - common/common-ui/src/main/res/values/widgets.xml | 8 ++++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/common/common-ui/src/main/java/com/duckduckgo/common/ui/view/button/DaxButton.kt b/common/common-ui/src/main/java/com/duckduckgo/common/ui/view/button/DaxButton.kt index 9504d93c0ce9..ce43ec9c65fe 100644 --- a/common/common-ui/src/main/java/com/duckduckgo/common/ui/view/button/DaxButton.kt +++ b/common/common-ui/src/main/java/com/duckduckgo/common/ui/view/button/DaxButton.kt @@ -63,7 +63,6 @@ open class DaxButton @JvmOverloads constructor( minHeight = resources.getDimensionPixelSize(Size.dimension(buttonSize)) setPadding(sidePadding, topPadding, sidePadding, topPadding) - setCornerRadiusResource(R.dimen.mediumShapeCornerRadius) } } diff --git a/common/common-ui/src/main/res/values/widgets.xml b/common/common-ui/src/main/res/values/widgets.xml index ac25bfdde003..00e6a0c648e8 100644 --- a/common/common-ui/src/main/res/values/widgets.xml +++ b/common/common-ui/src/main/res/values/widgets.xml @@ -139,6 +139,7 @@ ?attr/textAppearanceButton ?shapeAppearanceSmallComponent @dimen/keyline_2 + @dimen/mediumShapeCornerRadius