Skip to content

Enable swiping on favorites #6581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2025
Merged

Enable swiping on favorites #6581

merged 3 commits into from
Aug 22, 2025

Conversation

joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Aug 14, 2025 •
edited by LukasPaczos
Loading

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1210986778088960?focus=true

Description

  • Enables swiping on favorites on the Input Screen.

Steps to test this PR

  • Add some favorites
  • Go to the Input Screen
  • Swipe on the favorites
  • Verify that the ViewPager swipes to Duck.ai
  • Long press on a favorite
  • Verify that the Edit menu is shown
  • Drag a favorite
  • Verify that the favorite drags as expected
  • Go to the browser
  • Swipe between tabs
  • Verify that tabs swipe correctly
  • On a new tab, drag on favorites
  • Verify that the tabs swipe correctly

Feature flag disabled

  • In feature flag inventory, disable “favoritesSwipeHandling”
  • Verify that you can no longer swipe on favorites
  • Verify that swiping tabs still works

@joshliebe joshliebe requested a review from malmstein as a code owner August 14, 2025 09:45
@joshliebe Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joshliebe joshliebe force-pushed the feature/josh/swiping-favorites branch 2 times, most recently from ca877b9 to d775b14 Compare August 14, 2025 12:25
@LukasPaczos LukasPaczos force-pushed the feature/josh/swiping-favorites branch from d775b14 to e46495c Compare August 22, 2025 09:55
@LukasPaczos
Copy link
Contributor

Rebased to make sure changes here are compatible with #6632.

LukasPaczos
LukasPaczos approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works well!

@LukasPaczos LukasPaczos merged commit 0e82a54 into develop Aug 22, 2025
9 checks passed
@LukasPaczos LukasPaczos deleted the feature/josh/swiping-favorites branch August 22, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasPaczos LukasPaczos LukasPaczos approved these changes

@malmstein malmstein Awaiting requested review from malmstein malmstein is a code owner

Assignees

@LukasPaczos LukasPaczos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshliebe @LukasPaczos