Skip to content

Commit 017ac78

Browse files
mgurgelayoy
andauthored
Release Notes copy change - remove Privacy Pro from heading (#1917)
* Rename 'For Privacy Pro subscribers' to 'For DuckDuckGo subscribers' * Translation key update * Translations for Release Notes header --------- Co-authored-by: Dominik Kapusta <[email protected]>
1 parent e4075b2 commit 017ac78

File tree

14 files changed

+37
-37
lines changed

14 files changed

+37
-37
lines changed

special-pages/pages/new-tab/app/update-notification/integration-tests/update-notification.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ test.describe('newtab update notifications', () => {
4343
- list:
4444
- listitem: We're excited to introduce a new browsing feature - Fire Windows. These special windows work the same way as normal windows, except they isolate your activity from other browsing data and self-destruct when closed. This means you can use a Fire Window to browse without saving local history or to sign into a site with a different account. You can open a new Fire Window anytime from the Fire Button menu.
4545
- listitem: Try the new bookmark management view that opens in a tab for more robust bookmark organization.
46-
- paragraph: For Privacy Pro subscribers
46+
- paragraph: For DuckDuckGo subscribers
4747
- list:
4848
- listitem: VPN notifications are now available to help communicate VPN status.
4949
- listitem: Some apps aren't compatible with VPNs. You can now exclude these apps to use them while connected to the VPN.

special-pages/pages/new-tab/app/update-notification/mocks/update-notification.data.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export const updateNotificationExamples = {
2424
notes: [
2525
`• We're excited to introduce a new browsing feature - Fire Windows. These special windows work the same way as normal windows, except they isolate your activity from other browsing data and self-destruct when closed. This means you can use a Fire Window to browse without saving local history or to sign into a site with a different account. You can open a new Fire Window anytime from the Fire Button menu.`,
2626
`• Try the new bookmark management view that opens in a tab for more robust bookmark organization.`,
27-
`For Privacy Pro subscribers`,
27+
`For DuckDuckGo subscribers`,
2828
`• VPN notifications are now available to help communicate VPN status.`,
2929
`• Some apps aren't compatible with VPNs. You can now exclude these apps to use them while connected to the VPN.`,
3030
`• Visit https://duckduckgo.com/pro for more information.`,

special-pages/pages/release-notes/app/Components.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export function Components() {
3939
},
4040
{
4141
icon: 'PrivacyPro',
42-
title: t('forPrivacyProSubscribers'),
42+
title: t('forSubscribers'),
4343
notes: [
4444
'Cras egestas, dui eu sodales congue, ex augue vehicula ipsum, sed egestas est justo in enim.',
4545
'Duis varius in ex at vestibulum. Morbi finibus fringilla urna, ac varius quam vestibulum sit amet.',

special-pages/pages/release-notes/app/components/ReleaseNotes.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ export function CardContents({ releaseData }) {
237237
if (releaseNotesPrivacyPro?.length) {
238238
notes.push({
239239
icon: 'PrivacyPro',
240-
title: t('forPrivacyProSubscribers'),
240+
title: t('forSubscribers'),
241241
notes: [
242242
...releaseNotesPrivacyPro,
243243
/* The following should only get translated when the contents of the Release Notes update message are localized */

special-pages/pages/release-notes/integration-tests/release-notes.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ export class ReleaseNotesPage {
197197
await expect(page.getByTestId('placeholder')).toBeVisible();
198198

199199
await expect(page.getByRole('heading', { name: 'May 20 2024 New' })).not.toBeVisible();
200-
await expect(page.getByRole('heading', { name: 'For Privacy Pro Subscribers' })).not.toBeVisible();
200+
await expect(page.getByRole('heading', { name: 'For DuckDuckGo Subscribers' })).not.toBeVisible();
201201
await expect(page.getByRole('button', { name: 'Restart To Update' })).not.toBeVisible();
202202
}
203203

@@ -209,7 +209,7 @@ export class ReleaseNotesPage {
209209
await expect(page.getByRole('button', { name: 'Reload Summary' })).toBeVisible();
210210

211211
await expect(page.getByRole('heading', { name: 'May 20 2024 New' })).not.toBeVisible();
212-
await expect(page.getByRole('heading', { name: 'For Privacy Pro Subscribers' })).not.toBeVisible();
212+
await expect(page.getByRole('heading', { name: 'For DuckDuckGo Subscribers' })).not.toBeVisible();
213213
await expect(page.getByRole('button', { name: 'Restart To Update' })).not.toBeVisible();
214214
}
215215

@@ -221,7 +221,7 @@ export class ReleaseNotesPage {
221221
await expect(page.getByTestId('placeholder')).toBeVisible();
222222

223223
await expect(page.getByRole('heading', { name: 'May 20 2024 New' })).not.toBeVisible();
224-
await expect(page.getByRole('heading', { name: 'For Privacy Pro Subscribers' })).not.toBeVisible();
224+
await expect(page.getByRole('heading', { name: 'For DuckDuckGo Subscribers' })).not.toBeVisible();
225225
await expect(page.getByRole('button', { name: 'Restart To Update' })).not.toBeVisible();
226226
}
227227

@@ -233,7 +233,7 @@ export class ReleaseNotesPage {
233233
await expect(page.getByTestId('placeholder')).toBeVisible();
234234

235235
await expect(page.getByRole('heading', { name: 'May 20 2024 New' })).not.toBeVisible();
236-
await expect(page.getByRole('heading', { name: 'For Privacy Pro Subscribers' })).not.toBeVisible();
236+
await expect(page.getByRole('heading', { name: 'For DuckDuckGo Subscribers' })).not.toBeVisible();
237237
await expect(page.getByRole('button', { name: 'Restart To Update' })).not.toBeVisible();
238238
}
239239

@@ -326,14 +326,14 @@ export class ReleaseNotesPage {
326326
).not.toBeVisible();
327327
await expect(page.getByText('Privacy Pro is currently available to U.S. residents only')).not.toBeVisible();
328328

329-
await expect(page.getByRole('heading', { name: 'For Privacy Pro Subscribers' })).not.toBeVisible();
329+
await expect(page.getByRole('heading', { name: 'For DuckDuckGo Subscribers' })).not.toBeVisible();
330330
await expect(page.getByRole('link', { name: 'duckduckgo.com/pro' })).not.toBeVisible();
331331
}
332332

333333
async didShowReleaseNotesList() {
334334
const { page } = this;
335335

336-
await expect(page.getByRole('heading', { name: 'For Privacy Pro Subscribers' })).toBeVisible();
336+
await expect(page.getByRole('heading', { name: 'For DuckDuckGo Subscribers' })).toBeVisible();
337337
await expect(page.getByRole('link', { name: 'duckduckgo.com/pro' })).toBeVisible();
338338

339339
await expect(

special-pages/pages/release-notes/public/locales/de/release-notes.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@
6868
"title" : "Update nochmal versuchen",
6969
"note" : "Label for a button that retries applying the failed update"
7070
},
71-
"forPrivacyProSubscribers" : {
72-
"title" : "Für Privacy Pro-Abonnenten",
73-
"note" : "Heading label for release notes specific to Privacy Pro Subscribers (do not translate Privacy Pro)"
71+
"forSubscribers" : {
72+
"title" : "Für DuckDuckGo-Abonnenten",
73+
"note" : "Heading label for release notes specific to DuckDuckGo Subscribers"
7474
},
7575
"new" : {
7676
"title" : "Neu",

special-pages/pages/release-notes/public/locales/en/release-notes.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@
6868
"title": "Retry Update",
6969
"note": "Label for a button that retries applying the failed update"
7070
},
71-
"forPrivacyProSubscribers": {
72-
"title": "For Privacy Pro Subscribers",
73-
"note": "Heading label for release notes specific to Privacy Pro Subscribers (do not translate Privacy Pro)"
71+
"forSubscribers": {
72+
"title": "For DuckDuckGo Subscribers",
73+
"note": "Heading label for release notes specific to DuckDuckGo Subscribers"
7474
},
7575
"new": {
7676
"title": "New",

special-pages/pages/release-notes/public/locales/es/release-notes.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@
6868
"title" : "Reintentar actualización",
6969
"note" : "Label for a button that retries applying the failed update"
7070
},
71-
"forPrivacyProSubscribers" : {
72-
"title" : "Para suscriptores de Privacy Pro",
73-
"note" : "Heading label for release notes specific to Privacy Pro Subscribers (do not translate Privacy Pro)"
71+
"forSubscribers" : {
72+
"title" : "Para suscriptores de DuckDuckGo",
73+
"note" : "Heading label for release notes specific to DuckDuckGo Subscribers"
7474
},
7575
"new" : {
7676
"title" : "Nuevo",

special-pages/pages/release-notes/public/locales/fr/release-notes.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@
6868
"title" : "Réessayer la mise à jour",
6969
"note" : "Label for a button that retries applying the failed update"
7070
},
71-
"forPrivacyProSubscribers" : {
72-
"title" : "Pour les abonnés Privacy Pro",
73-
"note" : "Heading label for release notes specific to Privacy Pro Subscribers (do not translate Privacy Pro)"
71+
"forSubscribers" : {
72+
"title" : "Pour les abonnés DuckDuckGo",
73+
"note" : "Heading label for release notes specific to DuckDuckGo Subscribers"
7474
},
7575
"new" : {
7676
"title" : "Nouveau",

special-pages/pages/release-notes/public/locales/it/release-notes.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@
6868
"title" : "Riprova l'aggiornamento",
6969
"note" : "Label for a button that retries applying the failed update"
7070
},
71-
"forPrivacyProSubscribers" : {
72-
"title" : "Per gli abbonati a Privacy Pro",
73-
"note" : "Heading label for release notes specific to Privacy Pro Subscribers (do not translate Privacy Pro)"
71+
"forSubscribers" : {
72+
"title" : "Per gli abbonati a DuckDuckGo",
73+
"note" : "Heading label for release notes specific to DuckDuckGo Subscribers"
7474
},
7575
"new" : {
7676
"title" : "Nuova",

0 commit comments

Comments
 (0)