Skip to content

Commit 340b8dd

Browse files
authored
Deprecate visibilityMenuItems in contextMenu notification (#1938)
1 parent a053eb8 commit 340b8dd

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

special-pages/pages/new-tab/app/new-tab.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ children:
3434
- Sent when the user right-clicks in the page
3535
- Note: Other widgets might prevent this (and send their own, eg: favorites)
3636
- Sends: {@link "NewTab Messages".ContextMenuNotify}
37+
- **DEPRECATED**: The `visibilityMenuItems` property is deprecated and will be removed in a future version. Native apps should populate the context menu themselves instead of relying on frontend to tell it what widgets exist in the New Tab Page.
3738
- Example:
3839

3940
```json

special-pages/pages/new-tab/messages/contextMenu.notify.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
"properties": {
66
"visibilityMenuItems": {
77
"type": "array",
8+
"deprecated": true,
9+
"description": "DEPRECATED: This property is deprecated and will be removed in a future version. Native apps should populate the context menu themselves instead of relying on frontend to tell it what widgets exist in the New Tab Page.",
810
"items": {
911
"type": "object",
1012
"title": "Visibility Menu Item",

special-pages/pages/new-tab/types/new-tab.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,10 @@ export interface ContextMenuNotification {
239239
params: ContextMenuNotify;
240240
}
241241
export interface ContextMenuNotify {
242+
/**
243+
* @deprecated
244+
* DEPRECATED: This property is deprecated and will be removed in a future version. Native apps should populate the context menu themselves instead of relying on frontend to tell it what widgets exist in the New Tab Page.
245+
*/
242246
visibilityMenuItems: VisibilityMenuItem[];
243247
}
244248
export interface VisibilityMenuItem {

0 commit comments

Comments
 (0)