Notification: Add toString and make permission/requestPermission set values (#1934)

* Initial PoC changes for testing

* Address comments

* Add toString attempt

* Try using full constructor instead of arrow function

* Fix notification toString

* Avoid proxy descriptor mismatch in wrapToString

* Remove rando copilot edit

* Try recursively shimming toString

* Try again to fix toString2 error

* Match Chrome's inheritance instead of supplying toString

* Fix constructor toString

* Debug toString2

* Debug toString2 some more

* Add current state

* Fix writable value

* Get tests to pass

* Make notification.permission use value over get

* Fix writable value

* Remove this scope changes

* Zap dangling comment

* Zap another comment

* Zap rando file addition

* Make suggested changes

---------

Co-authored-by: Jonathan Kingston <[email protected]>

Author: laghee

injected/integration-test/web-compat.spec.js

@@ -130,6 +130,26 @@ test.describe('Ensure Notification interface is injected', () => {
             return window.Notification.maxActions;
         });
         expect(maxActionsPropDenied).toEqual(2);
+
+        const notificationToString = await page.evaluate(() => {
+            return window.Notification.toString();
+        });
+        expect(notificationToString).toEqual('function Notification() { [native code] }');
+
+        const requestPermissionToString = await page.evaluate(() => {
+            return window.Notification.requestPermission.toString();
+        });
+        expect(requestPermissionToString).toEqual('function requestPermission() { [native code] }');
+
+        const notificationToStringToString = await page.evaluate(() => {
+            return window.Notification.toString.toString();
+        });
+        expect(notificationToStringToString).toEqual('function toString() { [native code] }');
+
+        const requestPermissionToStringToString = await page.evaluate(() => {
+            return window.Notification.requestPermission.toString.toString();
+        });
+        expect(requestPermissionToStringToString).toEqual('function toString() { [native code] }');
     });
 });
 

injected/src/features/web-compat.js

@@ -2,6 +2,7 @@ import ContentFeature from '../content-feature.js';
 // eslint-disable-next-line no-redeclare
 import { URL } from '../captured-globals.js';
 import { DDGProxy, DDGReflect } from '../utils';
+import { wrapToString } from '../wrapper-utils.js';
 /**
  * Fixes incorrect sizing value for outerHeight and outerWidth
  */
@@ -216,33 +217,52 @@ export class WebCompat extends ContentFeature {
         if (window.Notification) {
             return;
         }
+
         // Expose the API
+        // window.Notification polyfill is intentionally incompatible with DOM lib types
+        const NotificationConstructor = function Notification() {
+            throw new TypeError("Failed to construct 'Notification': Illegal constructor");
+        };
+
+        const wrappedNotification = wrapToString(
+            NotificationConstructor,
+            NotificationConstructor,
+            'function Notification() { [native code] }',
+        );
+
         this.defineProperty(window, 'Notification', {
-            value: () => {
-                // noop
-            },
+            value: wrappedNotification,
             writable: true,
             configurable: true,
             enumerable: false,
         });
 
-        this.defineProperty(window.Notification, 'requestPermission', {
-            value: () => {
-                return Promise.resolve('denied');
-            },
-            writable: true,
+        this.defineProperty(window.Notification, 'permission', {
+            value: 'denied',
+            writable: false,
             configurable: true,
             enumerable: true,
         });
 
-        this.defineProperty(window.Notification, 'permission', {
-            get: () => 'denied',
+        this.defineProperty(window.Notification, 'maxActions', {
+            get: () => 2,
             configurable: true,
-            enumerable: false,
+            enumerable: true,
         });
 
-        this.defineProperty(window.Notification, 'maxActions', {
-            get: () => 2,
+        const requestPermissionFunc = function requestPermission() {
+            return Promise.resolve('denied');
+        };
+
+        const wrappedRequestPermission = wrapToString(
+            requestPermissionFunc,
+            requestPermissionFunc,
+            'function requestPermission() { [native code] }',
+        );
+
+        this.defineProperty(window.Notification, 'requestPermission', {
+            value: wrappedRequestPermission,
+            writable: true,
             configurable: true,
             enumerable: true,
         });