New onDuckPlayerScriptsReady event

Author: mgurgel

injected/src/features/duck-player.js

@@ -65,6 +65,12 @@ export default class DuckPlayerFeature extends ContentFeature {
          */
         if (isBeingFramed()) return;
 
+        /**
+         * TODO: Remove this when ready to re-enable Duck Player classic
+         */
+        console.warn('Not initializing Duck Player classic');
+        return;
+
         /**
          * Just the 'overlays' part of the settings object.
          * @type {import("@duckduckgo/privacy-configuration/schema/features/duckplayer").DuckPlayerSettings['overlays']}

injected/src/features/duckplayer-native/constants.js

@@ -5,4 +5,5 @@ export const MSG_NAME_MUTE_AUDIO = 'onMuteAudio';
 export const MSG_NAME_SERP_NOTIFY = 'onSerpNotify';
 export const MSG_NAME_YOUTUBE_ERROR = 'onYoutubeError';
 export const MSG_NAME_URL_CHANGE = 'onUrlChanged';
-export const MSG_NAME_FEATURE_READY = 'onDuckPlayerReady';
+export const MSG_NAME_FEATURE_READY = 'onDuckPlayerFeatureReady';
+export const MSG_NAME_SCRIPTS_READY = 'onDuckPlayerScriptsReady';

injected/src/features/duckplayer-native/duckplayer-native.js

@@ -96,7 +96,7 @@ export class DuckPlayerNative {
             this.onLoad(this.sideEffects, this.logger);
         }
 
-        this.messages.notifyFeatureIsReady();
+        this.messages.notifyScriptIsReady();
     }
 }
 

injected/src/features/duckplayer-native/messages.js

@@ -97,10 +97,18 @@ export class DuckPlayerNativeMessages {
     }
 
     /**
-     * Notifies browser that the feature
+     * Notifies browser that the feature is ready
      */
     notifyFeatureIsReady() {
-        console.log('FIRING ONDUCKPLAYERREADY');
+        console.log('FIRING', constants.MSG_NAME_FEATURE_READY);
         this.messaging.notify(constants.MSG_NAME_FEATURE_READY, {});
     }
+
+    /**
+     * Notifies browser that scripts are ready to be acalled
+     */
+    notifyScriptIsReady() {
+        console.log('FIRING', constants.MSG_NAME_SCRIPTS_READY);
+        this.messaging.notify(constants.MSG_NAME_SCRIPTS_READY, {});
+    }
 }

messaging/lib/webkit.js

@@ -154,6 +154,7 @@ export class WebkitMessagingTransport {
      * @param {import('../index.js').RequestMessage} msg
      */
     async request(msg) {
+        console.log('MESSAGE', msg);
         const data = await this.wkSendAndWait(msg.context, msg);
 
         if (isResponseFor(msg, data)) {