Skip to content

Commit 527b3f1

Browse files
Simplify breakage report. Don't trigger expanded on frame
1 parent 933620c commit 527b3f1

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

injected/src/features/breakage-reporting.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,10 @@ export default class BreakageReporting extends ContentFeature {
1212
referrer,
1313
};
1414
if (isExpandedPerformanceMetricsEnabled) {
15-
result.expandedPerformanceMetrics = getExpandedPerformanceMetrics();
15+
const expandedPerformanceMetrics = getExpandedPerformanceMetrics();
16+
if (expandedPerformanceMetrics.success) {
17+
result.expandedPerformanceMetrics = expandedPerformanceMetrics.metrics;
18+
}
1619
}
1720
this.messaging.notify('breakageReportResult', result);
1821
});

injected/src/features/performance-metrics.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import ContentFeature from '../content-feature';
22
import { getExpandedPerformanceMetrics, getJsPerformanceMetrics } from './breakage-reporting/utils.js';
3+
import { isBeingFramed } from '../utils.js';
34

45
export default class PerformanceMetrics extends ContentFeature {
56
init() {
@@ -8,6 +9,10 @@ export default class PerformanceMetrics extends ContentFeature {
89
this.messaging.notify('vitalsResult', { vitals });
910
});
1011

12+
// If the document is being framed, we don't want to collect expanded performance metrics
13+
if (isBeingFramed()) return;
14+
15+
// If the feature is enabled, we want to collect expanded performance metrics
1116
if (this.getFeatureSettingEnabled('expandedPerformanceMetricsOnLoad', 'enabled')) {
1217
document.addEventListener('load', () => {
1318
this.triggerExpandedPerformanceMetrics();

0 commit comments

Comments
 (0)