Test fix

Author: mgurgel

injected/integration-test/duckplayer-mobile.spec.js

@@ -152,8 +152,8 @@ test.describe('Reporting exceptions', () => {
     test('initial setup error', async ({ page }, workerInfo) => {
         const overlays = DuckplayerOverlays.create(page, workerInfo);
         await overlays.withRemoteConfig({ locale: 'en' });
-        await overlays.initialSetupError();
+        await overlays.messagingError();
         await overlays.gotoPlayerPage();
-        await overlays.didSendInitialSetupErrorException();
+        await overlays.didSendMessagingException();
     });
 });

injected/integration-test/duckplayer.spec.js

@@ -374,8 +374,8 @@ test.describe('Reporting exceptions', () => {
     test('initial setup error', async ({ page }, workerInfo) => {
         const overlays = DuckplayerOverlays.create(page, workerInfo);
         await overlays.withRemoteConfig({ locale: 'en' });
-        await overlays.initialSetupError();
+        await overlays.messagingError();
         await overlays.gotoPlayerPage();
-        await overlays.didSendInitialSetupErrorException();
+        await overlays.didSendMessagingException();
     });
 });

injected/integration-test/page-objects/duckplayer-overlays.js

@@ -305,7 +305,10 @@ export class DuckplayerOverlays {
         });
     }
 
-    async initialSetupError() {
+    /**
+     * Simulates a messaging error by passing an empty initialSetup object
+     */
+    async messagingError() {
         await this.build.switch({
             android: async () => {
                 await this.collector.updateMockResponse({
@@ -520,20 +523,20 @@ export class DuckplayerOverlays {
         ]);
     }
 
-    async didSendInitialSetupErrorException() {
+    async didSendMessagingException() {
         await this.build.switch({
             android: async () => {
                 // Android produces a TypeError due to how its messaging lib is wired up
                 await this.didSendException('TypeError', "Cannot read properties of undefined (reading 'privatePlayerMode')");
             },
             apple: async () => {
-                await this.didSendException('InitialSetupError', 'Error: an unknown error occurred');
+                await this.didSendException('MessagingError', 'an unknown error occurred');
             },
             'apple-isolated': async () => {
-                await this.didSendException('InitialSetupError', 'Error: an unknown error occurred', 'contentScopeScriptsIsolated');
+                await this.didSendException('MessagingError', 'an unknown error occurred', 'contentScopeScriptsIsolated');
             },
             windows: async () => {
-                await this.didSendException('InitialSetupError', 'Error: unknown error');
+                await this.didSendException('MessagingError', 'unknown error');
             },
         });
     }

special-pages/pages/duckplayer/integration-tests/duck-player.js

@@ -145,17 +145,16 @@ export class DuckPlayerPage {
         this.mocks.defaultResponses(clone);
     }
 
-    initialSetupError() {
+    /**
+     * Simulates a messaging error by passing an empty initialSetup object
+     */
+    messagingError() {
         const clone = structuredClone(this.defaults);
 
         this.build.switch({
             android: () => {
                 // @ts-expect-error - this is a test
-                clone.initialSetup = {
-                    locale: 'en',
-                    env: 'development',
-                    platform: this.platform.name === 'windows' ? undefined : { name: this.platform.name },
-                };
+                clone.initialSetup = {};
                 this.mocks.defaultResponses(clone);
             },
             apple: () => {
@@ -592,17 +591,17 @@ export class DuckPlayerPage {
         return this.didSendReportMetric({ metricName: 'exception', params: { kind, message } });
     }
 
-    async didSendInitialSetupErrorException() {
+    async didSendMessagingException() {
         await this.build.switch({
             android: async () => {
                 // Android produces a TypeError due to how its messaging lib is wired up
                 await this.didSendException('TypeError', "undefined is not an object (evaluating 'init2.settings.pip')");
             },
             apple: async () => {
-                await this.didSendException('InitialSetupError', 'Max attempts reached: Error: an unknown error occurred');
+                await this.didSendException('MessagingError', 'an unknown error occurred');
             },
             windows: async () => {
-                await this.didSendException('InitialSetupError', 'Max attempts reached: Error: unknown error');
+                await this.didSendException('MessagingError', 'unknown error');
             },
         });
     }

special-pages/pages/duckplayer/integration-tests/duckplayer.spec.js

@@ -344,9 +344,9 @@ test.describe('reporting exceptions', () => {
     test('initial setup error', async ({ page }, workerInfo) => {
         const duckplayer = DuckPlayerPage.create(page, workerInfo);
         // load as normal
-        duckplayer.initialSetupError();
+        duckplayer.messagingError();
         await duckplayer.openWithVideoID();
-        await duckplayer.didSendInitialSetupErrorException();
+        await duckplayer.didSendMessagingException();
     });
 });
 

special-pages/pages/duckplayer/src/index.js

@@ -6,8 +6,6 @@ import { initStorage } from './storage.js';
 import '../../../shared/live-reload.js';
 import {
     ReportMetric,
-    EXCEPTION_KIND_GENERIC_ERROR,
-    EXCEPTION_KIND_INITIAL_SETUP_ERROR,
     EXCEPTION_KIND_MESSAGING_ERROR,
 } from '../../../shared/report-metric.js';
 
@@ -46,7 +44,7 @@ export class DuckplayerPage {
         try {
             return await this.messaging.request('initialSetup');
         } catch (e) {
-            this.metrics.reportException({ message: e?.message, kind: EXCEPTION_KIND_INITIAL_SETUP_ERROR });
+            this.metrics.reportException({ message: e?.message, kind: EXCEPTION_KIND_MESSAGING_ERROR });
             throw e;
         }
     }
@@ -197,13 +195,11 @@ const duckplayerPage = new DuckplayerPage(messaging, import.meta.injectName);
 const telemetry = new Telemetry(messaging);
 
 init(duckplayerPage, telemetry, baseEnvironment).catch((e) => {
-    // messages.
     console.error(e);
-    const message = typeof e?.message === 'string' ? e.message : 'unknown error';
-    const kind = typeof e?.name === 'string' ? e.name : EXCEPTION_KIND_GENERIC_ERROR;
-    duckplayerPage.metrics.reportException({ message, kind });
+    duckplayerPage.metrics.reportExceptionWithError(e);
 
     // TODO: Remove this event once all native platforms are responding to 'reportMetric: exception'
+    const message = typeof e?.message === 'string' ? e.message : 'unknown error';
     duckplayerPage.reportInitException({ message });
 });