Skip to content

Commit 63cb06f

Browse files
authored
NTP: Fix omnibar colour when using a custom background (#1846)
* Fix tab switcher dark theme styling * Improve omnibar coloring on custom backgrounds
1 parent 0f0258c commit 63cb06f

File tree

4 files changed

+16
-6
lines changed

4 files changed

+16
-6
lines changed

special-pages/pages/new-tab/app/omnibar/components/AiChatForm.module.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@
1616
padding: 11px 15px 0;
1717
resize: none;
1818

19+
&::placeholder {
20+
color: var(--ntp-text-muted);
21+
}
22+
1923
&:focus {
2024
outline: none;
2125
}

special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@
2323
position: absolute;
2424
right: var(--sp-1);
2525

26+
&::placeholder {
27+
color: var(--ntp-text-muted);
28+
}
29+
2630
&:focus {
2731
outline: none;
2832
}

special-pages/pages/new-tab/app/omnibar/components/TabSwitcher.module.css

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
overflow: hidden;
88
padding: var(--sp-0_5);
99
position: relative;
10+
11+
[data-theme="dark"] & {
12+
box-shadow: 0 1px 0 0 rgba(0, 0, 0, 0.16) inset;
13+
}
1014
}
1115

1216
.tab {
@@ -28,10 +32,9 @@
2832
}
2933

3034
.blob {
31-
background-color: var(--color-white);
35+
background-color: var(--ntp-controls-raised-fill-primary);
3236
border-radius: 18px;
3337
box-shadow: 0 4px 4px rgba(0, 0, 0, 0.08), 0 1px 2px rgba(0, 0, 0, 0.08), inset 0 1px 0 rgba(255, 255, 255, 0.48);
34-
color: var(--ntp-controls-raised-fill-primary);
3538
height: var(--sp-8);
3639
left: 0;
3740
position: absolute;
@@ -42,7 +45,6 @@
4245
will-change: translate;
4346

4447
[data-theme="dark"] & {
45-
background-color: #6B6B6B;
4648
box-shadow: 0 4px 4px rgba(0, 0, 0, 0.24), 0 1px 2px rgba(0, 0, 0, 0.24), inset 0 1px 0 rgba(255, 255, 255, 0.06);
4749
}
4850

special-pages/pages/new-tab/app/styles/ntp-theme.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,9 @@ body {
7272
--focus-ring: 0px 0px 0px 1px var(--ntp-focus-outline-color), 0px 0px 0px 3px var(--color-white);
7373
--focus-ring-thin: 0px 0px 0px 1px var(--color-white), 0px 0px 0px 1px var(--ntp-focus-outline-color);
7474
--focus-ring-primary: 0px 0px 0px 1px var(--default-dark-background-color), 0px 0px 0px 3px var(--ntp-color-primary);
75-
--ntp-surface-tertiary: #474747;
76-
--ntp-controls-raised-backdrop: var(--color-white-at-12);
77-
--ntp-controls-raised-fill-primary: #6B6B6B;
75+
--ntp-surface-tertiary: rgba(71, 71, 71, 0.66);
76+
--ntp-controls-raised-backdrop: var(--color-black-at-60);
77+
--ntp-controls-raised-fill-primary: var(--color-white-at-18);
7878
}
7979

8080
/* This comes from the application settings */

0 commit comments

Comments
 (0)