Skip to content

Commit 6f675d9

Browse files
Add configurable timeout for perf metrics (#2057)
* Add timeout parameter to performance metrics function Added timeout parameter to getExpandedPerformanceMetrics function to control waiting time for largest contentful paint. * Pass permissableDelayMs to getExpandedPerformanceMetrics
1 parent bd12a7b commit 6f675d9

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

injected/src/features/breakage-reporting/utils.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ function waitForLCP(timeoutMs = 500) {
6464
* Get the expanded performance metrics
6565
* @returns {Promise<ErrorObject | PerformanceMetricsResponse>}
6666
*/
67-
export async function getExpandedPerformanceMetrics() {
67+
export async function getExpandedPerformanceMetrics(timeoutMs = 500) {
6868
try {
6969
if (document.readyState !== 'complete') {
7070
return returnError('Document not ready');
@@ -80,7 +80,7 @@ export async function getExpandedPerformanceMetrics() {
8080
// Get largest contentful paint if available
8181
let largestContentfulPaint = null;
8282
if (PerformanceObserver.supportedEntryTypes.includes('largest-contentful-paint')) {
83-
largestContentfulPaint = await waitForLCP();
83+
largestContentfulPaint = await waitForLCP(timeoutMs);
8484
}
8585

8686
// Calculate total resource sizes

injected/src/features/performance-metrics.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ export default class PerformanceMetrics extends ContentFeature {
3939
}
4040

4141
async triggerExpandedPerformanceMetrics() {
42-
const expandedPerformanceMetrics = await getExpandedPerformanceMetrics();
42+
const permissableDelayMs = this.getFeatureSetting('expandedTimeoutMs') ?? 5000;
43+
const expandedPerformanceMetrics = await getExpandedPerformanceMetrics(permissableDelayMs);
4344
this.messaging.notify('expandedPerformanceMetricsResult', expandedPerformanceMetrics);
4445
}
4546
}

0 commit comments

Comments
 (0)