ntp: send background-tab on windows middle-click

Author: shakyShane

special-pages/pages/new-tab/app/favorites/integration-tests/favorites.page.js

@@ -32,6 +32,16 @@ export class FavoritesPage {
         expect(calls[1].payload.params).toStrictEqual({ id: 'id-many-1', url: 'https://example.com/?id=id-many-1', target: 'new-window' });
     }
 
+    async opensInBackgroundTab() {
+        await this.nthFavorite(0).click({ button: 'middle' });
+        const calls = await this.ntp.mocks.waitForCallCount({ method: 'favorites_open', count: 1 });
+        expect(calls[0].payload.params).toStrictEqual({
+            id: 'id-many-1',
+            url: 'https://example.com/?id=id-many-1',
+            target: 'background-tab',
+        });
+    }
+
     async opensInSameTab() {
         await this.nthFavorite(0).click();
         const calls = await this.ntp.mocks.waitForCallCount({ method: 'favorites_open', count: 1 });

special-pages/pages/new-tab/app/favorites/integration-tests/favorites.spec.js

@@ -51,6 +51,13 @@ test.describe('newtab favorites', () => {
         await ntp.openPage({ platformName: 'macos' });
         await favorites.opensInNewWindow();
     });
+    test('Opens a favorite in background tab', async ({ page }, workerInfo) => {
+        const ntp = NewtabPage.create(page, workerInfo);
+        const favorites = new FavoritesPage(ntp);
+        await ntp.reducedMotion();
+        await ntp.openPage({ platformName: 'windows' });
+        await favorites.opensInBackgroundTab();
+    });
     test('Adds an item', async ({ page }, workerInfo) => {
         const ntp = NewtabPage.create(page, workerInfo);
         const favorites = new FavoritesPage(ntp);

special-pages/pages/new-tab/app/utils.js

@@ -70,7 +70,12 @@ export function eventToTarget(event, platformName) {
     const isControlClick = platformName === 'macos' ? event.metaKey : event.ctrlKey;
     if (isControlClick) {
         return 'new-tab';
-    } else if (event.shiftKey || event.button === 1 /* middle click */) {
+    } else if (event.shiftKey) {
+        return 'new-window';
+    } else if (event.button === 1 /* middle click */) {
+        if (platformName === 'windows') {
+            return 'background-tab';
+        }
         return 'new-window';
     }
     return 'same-tab';

special-pages/pages/new-tab/messages/types/open-target.json

@@ -2,5 +2,5 @@
   "$schema": "http://json-schema.org/draft-07/schema#",
   "title": "Open Target",
   "type": "string",
-  "enum": ["same-tab", "new-tab", "new-window"]
+  "enum": ["same-tab", "new-tab", "new-window", "background-tab"]
 }

special-pages/pages/new-tab/types/new-tab.ts

@@ -6,7 +6,7 @@
  * @module NewTab Messages
  */
 
-export type OpenTarget = "same-tab" | "new-tab" | "new-window";
+export type OpenTarget = "same-tab" | "new-tab" | "new-window" | "background-tab";
 /**
  * Represents the expansion state of a widget
  */