Force search mode when Duck.ai is disabled in Omnibar (#1895)

Author: noisysocks

special-pages/pages/new-tab/app/omnibar/integration-tests/omnibar.page.js

@@ -69,6 +69,10 @@ export class OmnibarPage {
         return this.context().getByRole('button', { name: 'Close' });
     }
 
+    root() {
+        return this.context().locator('[data-mode]');
+    }
+
     /**
      * @param {number} count
      */
@@ -132,6 +136,13 @@ export class OmnibarPage {
         }
     }
 
+    /**
+     * @param {'search' | 'ai'} mode
+     */
+    async expectDataMode(mode) {
+        await expect(this.root()).toHaveAttribute('data-mode', mode);
+    }
+
     /**
      * @param {string} method
      * @param {number} count

special-pages/pages/new-tab/app/omnibar/integration-tests/omnibar.spec.js

@@ -280,6 +280,29 @@ test.describe('omnibar widget', () => {
         await expect(omnibar.tabList()).toHaveCount(0);
     });
 
+    test('forces mode to search when Duck.ai is disabled while in ai mode', async ({ page }, workerInfo) => {
+        const ntp = NewtabPage.create(page, workerInfo);
+        const omnibar = new OmnibarPage(ntp);
+        await ntp.reducedMotion();
+
+        await ntp.openPage({ additional: { omnibar: true } });
+        await omnibar.ready();
+
+        // Switch to AI mode
+        await omnibar.aiTab().click();
+        await omnibar.expectMode('ai');
+
+        // Disable Duck.ai via Customize panel
+        await omnibar.customizeButton().click();
+        await omnibar.toggleDuckAiButton().click();
+
+        // Mode should be forced back to search since tab switcher is now hidden
+        await omnibar.expectDataMode('search');
+
+        // Tab selector should be gone
+        await expect(omnibar.tabList()).toHaveCount(0);
+    });
+
     test('hiding Omnibar widget hides Duck.ai toggle', async ({ page }, workerInfo) => {
         const ntp = NewtabPage.create(page, workerInfo);
         const omnibar = new OmnibarPage(ntp);

special-pages/pages/new-tab/app/omnibar/omnibar.service.js

@@ -74,6 +74,8 @@ export class OmnibarService {
             return {
                 ...old,
                 enableAi,
+                // Force mode to 'search' when Duck.ai is disabled to prevent getting stuck in 'ai' mode
+                mode: enableAi ? old.mode : 'search',
             };
         });
     }