Skip to content

Commit a165e7a

Browse files
committed
Address bot comment, fix failing tests
1 parent c98b9e7 commit a165e7a

File tree

4 files changed

+7
-11
lines changed

4 files changed

+7
-11
lines changed

injected/integration-test/page-objects/results-collector.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -234,10 +234,6 @@ export class ResultsCollector {
234234
windows: () => wrapWindowsScripts,
235235
});
236236

237-
// Extract trackerData from config settings for tracker-protection tests
238-
// trackerData must be an object (not a JSON string)
239-
const trackerDataFromConfig = config?.features?.trackerProtection?.settings?.trackerData;
240-
241237
// read the built file from disk and do replacements
242238
const injectedJS = wrapFn(this.build.artifact, {
243239
$CONTENT_SCOPE$: config,
@@ -250,8 +246,6 @@ export class ResultsCollector {
250246
javascriptInterface: this.messagingContextName,
251247
messagingContextName: this.messagingContextName,
252248
locale,
253-
// trackerData from config as default; explicit #userPreferences.trackerData wins
254-
...(trackerDataFromConfig && { trackerData: trackerDataFromConfig }),
255249
...this.#userPreferences,
256250
},
257251
});

injected/src/config-feature.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ export default class ConfigFeature {
7070
* messagingConfig?: import('@duckduckgo/messaging').MessagingConfig,
7171
* messagingContextName: string,
7272
* currentCohorts?: Array<{feature: string, cohort: string, subfeature: string}>,
73+
* trackerData?: import('./features/tracker-protection/tracker-resolver.js').TrackerData,
7374
* } | null}
7475
*/
7576
#args;

injected/src/content-scope-features.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const isHTMLDocument =
3838
* @property {Record<string, unknown>} [featureSettings]
3939
* @property {import('./content-feature.js').AssetConfig} [assets]
4040
* @property {Record<string, string[]>} [stringExemptionLists]
41-
* @property {{trackers: Record<string, unknown>, entities: Record<string, unknown>, domains: Record<string, string>, cnames?: Record<string, string>}} [trackerData]
41+
* @property {import('./features/tracker-protection/tracker-resolver.js').TrackerData} [trackerData]
4242
*/
4343

4444
/**

injected/src/features/tracker-protection.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,12 @@ function getTabURL() {
2929
framingOrigin = globalThis.top?.location.href;
3030
} catch {
3131
framingOrigin = globalThis.document.referrer;
32-
}
3332

34-
// ancestorOrigins gives us the actual top frame URL in cross-origin iframes
35-
if ('ancestorOrigins' in globalThis.location && globalThis.location.ancestorOrigins.length) {
36-
framingOrigin = globalThis.location.ancestorOrigins.item(globalThis.location.ancestorOrigins.length - 1);
33+
// ancestorOrigins only needed as fallback when top.location.href is inaccessible (e.g., cross-origin iframe).
34+
// Avoid overriding full top-level URL when we already have it.
35+
if ('ancestorOrigins' in globalThis.location && globalThis.location.ancestorOrigins.length) {
36+
framingOrigin = globalThis.location.ancestorOrigins.item(globalThis.location.ancestorOrigins.length - 1);
37+
}
3738
}
3839

3940
try {

0 commit comments

Comments
 (0)